forked from mirror/go-ethereum
eth/gasprice: lighter gas price oracle for light client (#20409)
This PR reduces the bandwidth used by the light client to compute the recommended gas price. The current mechanism for suggesting the price is: - retrieve recent 20 blocks - get the lowest gas price of these blocks - sort the price array and return the middle(60%) one This works for full nodes, which have all blocks available locally. However, this is very expensive for the light client because the light client needs to retrieve block bodies from the network. The PR changes the default options for light client. With the new config, the light client only retrieves the two latest blocks, but in order to collect more sample transactions, the 3 lowest prices are collected from each block. This PR also changes the behavior for empty blocks. If the block is empty, the lastest price is reused for sampling.release/1.9
parent
07a95ce571
commit
61270e5e1c
@ -0,0 +1,118 @@ |
||||
// Copyright 2020 The go-ethereum Authors
|
||||
// This file is part of the go-ethereum library.
|
||||
//
|
||||
// The go-ethereum library is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Lesser General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// The go-ethereum library is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Lesser General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Lesser General Public License
|
||||
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package gasprice |
||||
|
||||
import ( |
||||
"context" |
||||
"math" |
||||
"math/big" |
||||
"testing" |
||||
|
||||
"github.com/ethereum/go-ethereum/common" |
||||
"github.com/ethereum/go-ethereum/consensus/ethash" |
||||
"github.com/ethereum/go-ethereum/core" |
||||
"github.com/ethereum/go-ethereum/core/rawdb" |
||||
"github.com/ethereum/go-ethereum/core/types" |
||||
"github.com/ethereum/go-ethereum/core/vm" |
||||
"github.com/ethereum/go-ethereum/crypto" |
||||
"github.com/ethereum/go-ethereum/params" |
||||
"github.com/ethereum/go-ethereum/rpc" |
||||
) |
||||
|
||||
type testBackend struct { |
||||
chain *core.BlockChain |
||||
} |
||||
|
||||
func (b *testBackend) HeaderByNumber(ctx context.Context, number rpc.BlockNumber) (*types.Header, error) { |
||||
if number == rpc.LatestBlockNumber { |
||||
return b.chain.CurrentBlock().Header(), nil |
||||
} |
||||
return b.chain.GetHeaderByNumber(uint64(number)), nil |
||||
} |
||||
|
||||
func (b *testBackend) BlockByNumber(ctx context.Context, number rpc.BlockNumber) (*types.Block, error) { |
||||
if number == rpc.LatestBlockNumber { |
||||
return b.chain.CurrentBlock(), nil |
||||
} |
||||
return b.chain.GetBlockByNumber(uint64(number)), nil |
||||
} |
||||
|
||||
func (b *testBackend) ChainConfig() *params.ChainConfig { |
||||
return b.chain.Config() |
||||
} |
||||
|
||||
func newTestBackend(t *testing.T) *testBackend { |
||||
var ( |
||||
key, _ = crypto.HexToECDSA("b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291") |
||||
addr = crypto.PubkeyToAddress(key.PublicKey) |
||||
gspec = &core.Genesis{ |
||||
Config: params.TestChainConfig, |
||||
Alloc: core.GenesisAlloc{addr: {Balance: big.NewInt(math.MaxInt64)}}, |
||||
} |
||||
signer = types.NewEIP155Signer(gspec.Config.ChainID) |
||||
) |
||||
engine := ethash.NewFaker() |
||||
db := rawdb.NewMemoryDatabase() |
||||
genesis, _ := gspec.Commit(db) |
||||
|
||||
// Generate testing blocks
|
||||
blocks, _ := core.GenerateChain(params.TestChainConfig, genesis, engine, db, 32, func(i int, b *core.BlockGen) { |
||||
b.SetCoinbase(common.Address{1}) |
||||
tx, err := types.SignTx(types.NewTransaction(b.TxNonce(addr), common.HexToAddress("deadbeef"), big.NewInt(100), 21000, big.NewInt(int64(i+1)*params.GWei), nil), signer, key) |
||||
if err != nil { |
||||
t.Fatalf("failed to create tx: %v", err) |
||||
} |
||||
b.AddTx(tx) |
||||
}) |
||||
// Construct testing chain
|
||||
diskdb := rawdb.NewMemoryDatabase() |
||||
gspec.Commit(diskdb) |
||||
chain, err := core.NewBlockChain(diskdb, nil, params.TestChainConfig, engine, vm.Config{}, nil, nil) |
||||
if err != nil { |
||||
t.Fatalf("Failed to create local chain, %v", err) |
||||
} |
||||
chain.InsertChain(blocks) |
||||
return &testBackend{chain: chain} |
||||
} |
||||
|
||||
func (b *testBackend) CurrentHeader() *types.Header { |
||||
return b.chain.CurrentHeader() |
||||
} |
||||
|
||||
func (b *testBackend) GetBlockByNumber(number uint64) *types.Block { |
||||
return b.chain.GetBlockByNumber(number) |
||||
} |
||||
|
||||
func TestSuggestPrice(t *testing.T) { |
||||
config := Config{ |
||||
Blocks: 3, |
||||
Percentile: 60, |
||||
Default: big.NewInt(params.GWei), |
||||
} |
||||
backend := newTestBackend(t) |
||||
oracle := NewOracle(backend, config) |
||||
|
||||
// The gas price sampled is: 32G, 31G, 30G, 29G, 28G, 27G
|
||||
got, err := oracle.SuggestPrice(context.Background()) |
||||
if err != nil { |
||||
t.Fatalf("Failed to retrieve recommended gas price: %v", err) |
||||
} |
||||
expect := big.NewInt(params.GWei * int64(30)) |
||||
if got.Cmp(expect) != 0 { |
||||
t.Fatalf("Gas price mismatch, want %d, got %d", expect, got) |
||||
} |
||||
} |
Loading…
Reference in new issue