From fca3333f7f586832daba9e70a7ecd711baa163a9 Mon Sep 17 00:00:00 2001
From: Vitalik Buterin <v@buterin.com>
Date: Wed, 13 May 2015 20:46:23 -0400
Subject: [PATCH 1/2] Created separate family and ancestors environment objects

---
 miner/worker.go | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/miner/worker.go b/miner/worker.go
index f737be507..e714b5063 100644
--- a/miner/worker.go
+++ b/miner/worker.go
@@ -45,7 +45,8 @@ type environment struct {
 	state              *state.StateDB     // apply state changes here
 	coinbase           *state.StateObject // the miner's account
 	block              *types.Block       // the new block
-	family             *set.Set           // family set (used for checking uncles)
+	ancestors          *set.Set           // ancestor set (used for checking uncle parent validity)
+	family             *set.Set           // family set (used for checking uncle invalidity)
 	uncles             *set.Set           // uncle set
 	remove             *set.Set           // tx which will be removed
 	tcount             int                // tx count in cycle
@@ -62,6 +63,7 @@ func env(block *types.Block, eth core.Backend) *environment {
 		totalUsedGas: new(big.Int),
 		state:        state,
 		block:        block,
+		ancestors:    set.New(),
 		family:       set.New(),
 		uncles:       set.New(),
 		coinbase:     state.GetOrNewStateObject(block.Coinbase()),
@@ -265,6 +267,12 @@ func (self *worker) makeCurrent() {
 
 	current := env(block, self.eth)
 	for _, ancestor := range self.chain.GetAncestors(block, 7) {
+		current.ancestors.Add(ancestor.Hash())
+	}
+	for _, ancestor := range self.chain.GetAncestors(block, 7) {
+		for _, uncle := range ancestor.Uncles() {
+			current.family.Add(uncle.Hash())
+		}
 		current.family.Add(ancestor.Hash())
 	}
 	accounts, _ := self.eth.AccountManager().Accounts()
@@ -363,7 +371,7 @@ func (self *worker) commitUncle(uncle *types.Header) error {
 	}
 	self.current.uncles.Add(uncle.Hash())
 
-	if !self.current.family.Has(uncle.ParentHash) {
+	if !self.current.ancestors.Has(uncle.ParentHash) {
 		return core.UncleError(fmt.Sprintf("Uncle's parent unknown (%x)", uncle.ParentHash[0:4]))
 	}
 

From bdec8c3e41acf56f1cb7914b216c1d12b15b657b Mon Sep 17 00:00:00 2001
From: Vitalik Buterin <v@buterin.com>
Date: Thu, 14 May 2015 05:02:15 -0400
Subject: [PATCH 2/2] Combined two loops

---
 miner/worker.go | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/miner/worker.go b/miner/worker.go
index e714b5063..c70ded434 100644
--- a/miner/worker.go
+++ b/miner/worker.go
@@ -266,14 +266,12 @@ func (self *worker) makeCurrent() {
 	block.Header().Extra = self.extra
 
 	current := env(block, self.eth)
-	for _, ancestor := range self.chain.GetAncestors(block, 7) {
-		current.ancestors.Add(ancestor.Hash())
-	}
 	for _, ancestor := range self.chain.GetAncestors(block, 7) {
 		for _, uncle := range ancestor.Uncles() {
 			current.family.Add(uncle.Hash())
 		}
 		current.family.Add(ancestor.Hash())
+		current.ancestors.Add(ancestor.Hash())
 	}
 	accounts, _ := self.eth.AccountManager().Accounts()
 	// Keep track of transactions which return errors so they can be removed