It is expected to be "focus" in a number of places inside lib-jitsi-meet
and that won't change anytime soon.
Allowing users to change it is just asking for trouble.
Fixes: https://github.com/jitsi/lib-jitsi-meet/issues/2191
It's not enabled by default and there is no way to disable it any
longer.
We keep setting the flags in config.js though, this is so old mobile
versions without the new default behavior can enable it.
The new variable has a better purposed name, and supports a comma
separated list of IPs instead of a single one, which should help those
running split-horizon setups.
* Migrating configuration to use secure octo configuration by default
Adding a new JVB_OCTO_RELAY_ID to configure videobridge.relay.relay-id (with a fallback to the old JVB_OCTO_BIND_ADDRESS to be used as relay-id)
* Adding a configuration check to verify that Octo cannot be enabled without the ENABLE_COLIBRI_WEBSOCKET environment variable set to "1"
* Fixing ENABLE_RECORDING issue
In https://github.com/jitsi/docker-jitsi-meet/pull/1372, I made a change to allow the web component to set ENABLE_RECORDING and still enable recording (in order to have "service recording" disabled but Dropbox recording enabled.
I failed to notice that the ENABLE_RECORDING environment variable is also used in Prosody (and in a number of places) as a global switch.
With the new variable semantic (as proposed in #1372), in order to know if Jibri must be enabled or not, we need 3 variables (ENABLE_RECORDING, DROPBOX_APPKEY and ENABLE_LIVESTREAMING).
This means we should also propagate those variables to Prosody.
To be honest, having the "DROPBOX_APPKEY" forwarded to Prosody just to know if we should enable or disable recording is a bit weird.
So I feel it is a better idea to revert back the meaning of "ENABLE_RECORDING" to be a global switch.
I'm therefore reverting back to old behaviour and adding a new environment variable (ENABLE_SERVICE_RECORDING) that allows turning on or off the "service recording".
* Setting ENABLE_SERVICE_RECORDING default value to ENABLE_SERVICE_RECORDING
* b670959 prosody: simplify container build
* e05a9c2 fixup: template syntax for newly added variables (#1355)
* 164d28b web: migrate deprecated recordings options, add some more
* f126f7a web: set config.videoQuality.maxBitratesVideo to null if no bitrates are specified
* 0364d94 jibri: remove deprecated PulseAudio module
* 1c93e1b web: add support for brandingDataUrl (#1346)
* 4372717 web: add support for wav files to nginx default
* d804ba4 misc: make ignore rule more generic
* b224131 prosody: use ENABLE_IPV6 environment variable
* be8c41f etherpad,jigasi: fix compose file version
* d7cee00 misc: working on unstable
Saúl Ibarra Corretgé
Debendra Oli
Charles Zablit
Adam Skoglund
bgrozev
David Négrier
Marcel Bieberbach
Mustafa Ayberk Kale
wfleischer
Ben Banfield-Zanin
Rhys