Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)
This PR follows #22599 and #23450
The major improvements:
1. The `aria-*.js` are totally transparent now, no need to call
`attachDropdownAria` explicitly anymore.
* It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch
works.
* It makes all dynamically generated checkbox/dropdown work with a11y
without any change
* eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js`
2. Since it's totally transparent now, it could be easier to modify or
remove in the future.
3. It handles all selection labels as well (by onLabelCreate), so it
supports "multiple selection dropdown" now.
* It partially completes one of my TODOs: `TODO: multiple selection is
not supported yet.`
4. The code structure is clearer, code blocks are splitted into
different functions.
* The old `attachOneDropdownAria` was splitted into separate functions.
* It makes it easier to add more fine tunes in the future, and co-work
with contributors.
6. The code logic is similar as before, only two new parts:
1. the `ariaCheckboxFn` and `ariaDropdownFn` functions
2. the `onLabelCreate` and `updateSelectionLabel` functions
In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I
think the code is still understandable, otherwise the code would be much
more complex to read.
Thanks to fsologureng for the idea about "improving the 'delete icon'
with aria attributes".
If there is anything unclear or incorrect, feel free to ask and discuss,
or propose new PRs for it.
2 years ago
|
|
|
let ariaIdCounter = 0;
|
|
|
|
|
|
|
|
|
|
export function generateAriaId() {
|
|
|
|
|
return `_aria_auto_id_${ariaIdCounter++}`;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function linkLabelAndInput(label, input) {
|
|
|
|
|
const labelFor = label.getAttribute('for');
|
|
|
|
|
const inputId = input.getAttribute('id');
|
|
|
|
|
|
|
|
|
|
if (inputId && !labelFor) { // missing "for"
|
|
|
|
|
label.setAttribute('for', inputId);
|
|
|
|
|
} else if (!inputId && !labelFor) { // missing both "id" and "for"
|
|
|
|
|
const id = generateAriaId();
|
|
|
|
|
input.setAttribute('id', id);
|
|
|
|
|
label.setAttribute('for', id);
|
|
|
|
|
}
|
|
|
|
|
}
|
