mirror
/
gitea
mirror of https://github.com/go-gitea/gitea
2
0
Fork 0
Code Issues Releases Wiki Activity

Set the initial commit status to Success otherwise it will always be Pending (#10317) (#10318)

Browse Source 
Backport #10317

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
pull/10319/head^2
zeripath 5 years ago committed by GitHub
parent 4529a262c0
commit 117dcf1c02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 2
      services/pull/commit_status.go

2
services/pull/commit_status.go
Unescape View File

@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess return structs.CommitStatusSuccess
} }
var returnedStatus = structs.CommitStatusPending var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts { for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses { for _, commitStatus := range commitStatuses {

Write Preview
Loading…
Cancel
Save