From 23d0f9083e2d8b735b1b0578c348f73c0e4ae3dc Mon Sep 17 00:00:00 2001
From: a1012112796 <1012112796@qq.com>
Date: Thu, 21 Nov 2024 09:23:50 +0800
Subject: [PATCH] make search box in issue sidebar dropdown list always show
 when scrolling (#32576)

as title, replace #31597 after #32460

---------

Signed-off-by: a1012112796 <1012112796@qq.com>
---
 .../repo/issue/sidebar/assignee_list.tmpl     | 14 ++++----
 templates/repo/issue/sidebar/label_list.tmpl  | 36 ++++++++++---------
 .../repo/issue/sidebar/milestone_list.tmpl    | 34 +++++++++---------
 .../repo/issue/sidebar/project_list.tmpl      | 34 +++++++++---------
 .../repo/issue/sidebar/reviewer_list.tmpl     | 36 ++++++++++---------
 web_src/css/repo.css                          |  6 ++++
 6 files changed, 88 insertions(+), 72 deletions(-)

diff --git a/templates/repo/issue/sidebar/assignee_list.tmpl b/templates/repo/issue/sidebar/assignee_list.tmpl
index bee6123e52c..d8ccd73387d 100644
--- a/templates/repo/issue/sidebar/assignee_list.tmpl
+++ b/templates/repo/issue/sidebar/assignee_list.tmpl
@@ -16,12 +16,14 @@
 				<input type="text" placeholder="{{ctx.Locale.Tr "repo.issues.filter_assignees"}}">
 			</div>
 			<div class="item clear-selection">{{ctx.Locale.Tr "repo.issues.new.clear_assignees"}}</div>
-			{{range $data.CandidateAssignees}}
-				<a class="item muted" href="#" data-value="{{.ID}}">
-					<span class="item-check-mark">{{svg "octicon-check"}}</span>
-					{{ctx.AvatarUtils.Avatar . 20}} {{template "repo/search_name" .}}
-				</a>
-			{{end}}
+			<div class="scrolling menu">
+				{{range $data.CandidateAssignees}}
+					<a class="item muted" href="#" data-value="{{.ID}}">
+						<span class="item-check-mark">{{svg "octicon-check"}}</span>
+						{{ctx.AvatarUtils.Avatar . 20}} {{template "repo/search_name" .}}
+					</a>
+				{{end}}
+			</div>
 		</div>
 	</div>
 	<div class="ui list tw-flex tw-flex-row tw-gap-2">
diff --git a/templates/repo/issue/sidebar/label_list.tmpl b/templates/repo/issue/sidebar/label_list.tmpl
index ed80047661b..526eb1ec044 100644
--- a/templates/repo/issue/sidebar/label_list.tmpl
+++ b/templates/repo/issue/sidebar/label_list.tmpl
@@ -17,25 +17,27 @@
 					<input type="text" placeholder="{{ctx.Locale.Tr "repo.issues.filter_labels"}}">
 				</div>
 				<a class="item clear-selection" href="#">{{ctx.Locale.Tr "repo.issues.new.clear_labels"}}</a>
-				{{$previousExclusiveScope := "_no_scope"}}
-				{{range $data.RepoLabels}}
-					{{$exclusiveScope := .ExclusiveScope}}
-					{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
-						<div class="divider"></div>
+				<div class="scrolling menu">
+					{{$previousExclusiveScope := "_no_scope"}}
+					{{range $data.RepoLabels}}
+						{{$exclusiveScope := .ExclusiveScope}}
+						{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
+							<div class="divider"></div>
+						{{end}}
+						{{$previousExclusiveScope = $exclusiveScope}}
+						{{template "repo/issue/sidebar/label_list_item" dict "Label" .}}
 					{{end}}
-					{{$previousExclusiveScope = $exclusiveScope}}
-					{{template "repo/issue/sidebar/label_list_item" dict "Label" .}}
-				{{end}}
-				<div class="divider"></div>
-				{{$previousExclusiveScope = "_no_scope"}}
-				{{range $data.OrgLabels}}
-					{{$exclusiveScope := .ExclusiveScope}}
-					{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
-						<div class="divider"></div>
+					<div class="divider"></div>
+					{{$previousExclusiveScope = "_no_scope"}}
+					{{range $data.OrgLabels}}
+						{{$exclusiveScope := .ExclusiveScope}}
+						{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
+							<div class="divider"></div>
+						{{end}}
+						{{$previousExclusiveScope = $exclusiveScope}}
+						{{template "repo/issue/sidebar/label_list_item" dict "Label" .}}
 					{{end}}
-					{{$previousExclusiveScope = $exclusiveScope}}
-					{{template "repo/issue/sidebar/label_list_item" dict "Label" .}}
-				{{end}}
+				</div>
 			{{end}}
 		</div>
 	</div>
diff --git a/templates/repo/issue/sidebar/milestone_list.tmpl b/templates/repo/issue/sidebar/milestone_list.tmpl
index 4f2b4cb06fb..2d16c6e1b41 100644
--- a/templates/repo/issue/sidebar/milestone_list.tmpl
+++ b/templates/repo/issue/sidebar/milestone_list.tmpl
@@ -20,25 +20,27 @@
 				</div>
 				<div class="divider"></div>
 				<div class="item clear-selection">{{ctx.Locale.Tr "repo.issues.new.clear_milestone"}}</div>
-				{{if $data.OpenMilestones}}
-					<div class="divider"></div>
-					<div class="header">{{ctx.Locale.Tr "repo.issues.new.open_milestone"}}</div>
-					{{range $data.OpenMilestones}}
-						<a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}">
-							{{svg "octicon-milestone" 18}} {{.Name}}
-						</a>
+				<div class="scrolling menu">
+					{{if $data.OpenMilestones}}
+						<div class="divider"></div>
+						<div class="header">{{ctx.Locale.Tr "repo.issues.new.open_milestone"}}</div>
+						{{range $data.OpenMilestones}}
+							<a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}">
+								{{svg "octicon-milestone" 18}} {{.Name}}
+							</a>
+						{{end}}
 					{{end}}
-				{{end}}
-				{{if $data.ClosedMilestones}}
-					<div class="divider"></div>
-					<div class="header">{{ctx.Locale.Tr "repo.issues.new.closed_milestone"}}</div>
-					{{range $data.ClosedMilestones}}
-						<a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}">
-							{{svg "octicon-milestone" 18}} {{.Name}}
-						</a>
+					{{if $data.ClosedMilestones}}
+						<div class="divider"></div>
+						<div class="header">{{ctx.Locale.Tr "repo.issues.new.closed_milestone"}}</div>
+						{{range $data.ClosedMilestones}}
+							<a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}">
+								{{svg "octicon-milestone" 18}} {{.Name}}
+							</a>
+						{{end}}
 					{{end}}
 				{{end}}
-			{{end}}
+			</div>
 		</div>
 	</div>
 
diff --git a/templates/repo/issue/sidebar/project_list.tmpl b/templates/repo/issue/sidebar/project_list.tmpl
index ab1243caddc..6ca6156d2cc 100644
--- a/templates/repo/issue/sidebar/project_list.tmpl
+++ b/templates/repo/issue/sidebar/project_list.tmpl
@@ -18,24 +18,26 @@
 			</div>
 			{{end}}
 			<div class="item clear-selection">{{ctx.Locale.Tr "repo.issues.new.clear_projects"}}</div>
-			{{if $data.OpenProjects}}
-				<div class="divider"></div>
-				<div class="header">{{ctx.Locale.Tr "repo.issues.new.open_projects"}}</div>
-				{{range $data.OpenProjects}}
-					<a class="item muted" data-value="{{.ID}}" href="{{.Link ctx}}">
-						{{svg .IconName 18}} {{.Title}}
-					</a>
+			<div class="scrolling menu">
+				{{if $data.OpenProjects}}
+					<div class="divider"></div>
+					<div class="header">{{ctx.Locale.Tr "repo.issues.new.open_projects"}}</div>
+					{{range $data.OpenProjects}}
+						<a class="item muted" data-value="{{.ID}}" href="{{.Link ctx}}">
+							{{svg .IconName 18}} {{.Title}}
+						</a>
+					{{end}}
 				{{end}}
-			{{end}}
-			{{if $data.ClosedProjects}}
-				<div class="divider"></div>
-				<div class="header">{{ctx.Locale.Tr "repo.issues.new.closed_projects"}}</div>
-				{{range $data.ClosedProjects}}
-					<a class="item muted" data-value="{{.ID}}" href="{{.Link ctx}}">
-						{{svg .IconName 18}} {{.Title}}
-					</a>
+				{{if $data.ClosedProjects}}
+					<div class="divider"></div>
+					<div class="header">{{ctx.Locale.Tr "repo.issues.new.closed_projects"}}</div>
+					{{range $data.ClosedProjects}}
+						<a class="item muted" data-value="{{.ID}}" href="{{.Link ctx}}">
+							{{svg .IconName 18}} {{.Title}}
+						</a>
+					{{end}}
 				{{end}}
-			{{end}}
+			</div>
 		</div>
 	</div>
 	<div class="ui list">
diff --git a/templates/repo/issue/sidebar/reviewer_list.tmpl b/templates/repo/issue/sidebar/reviewer_list.tmpl
index e990fc5afc8..16eea23d69c 100644
--- a/templates/repo/issue/sidebar/reviewer_list.tmpl
+++ b/templates/repo/issue/sidebar/reviewer_list.tmpl
@@ -17,27 +17,29 @@
 					<input type="text" placeholder="{{ctx.Locale.Tr "repo.issues.filter_reviewers"}}">
 				</div>
 			{{end}}
-			{{range $data.Reviewers}}
-				{{if .User}}
-					<a class="item muted {{if .Requested}}checked{{end}}" href="{{.User.HomeLink}}" data-value="{{.ItemID}}" data-can-change="{{.CanChange}}"
-						{{if not .CanChange}}data-tooltip-content="{{ctx.Locale.Tr "repo.issues.remove_request_review_block"}}"{{end}}>
-						<span class="item-check-mark">{{svg "octicon-check"}}</span>
-						{{ctx.AvatarUtils.Avatar .User 20}} {{template "repo/search_name" .User}}
-					</a>
-				{{end}}
-			{{end}}
-			{{if $data.TeamReviewers}}
-				{{if $data.Reviewers}}<div class="divider"></div>{{end}}
-				{{range $data.TeamReviewers}}
-					{{if .Team}}
-						<a class="item muted {{if .Requested}}checked{{end}}" href="#" data-value="{{.ItemID}}" data-can-change="{{.CanChange}}"
-							{{if not .CanChange}} data-tooltip-content="{{ctx.Locale.Tr "repo.issues.remove_request_review_block"}}"{{end}}>
+			<div class="scrolling menu">
+				{{range $data.Reviewers}}
+					{{if .User}}
+						<a class="item muted {{if .Requested}}checked{{end}}" href="{{.User.HomeLink}}" data-value="{{.ItemID}}" data-can-change="{{.CanChange}}"
+							{{if not .CanChange}}data-tooltip-content="{{ctx.Locale.Tr "repo.issues.remove_request_review_block"}}"{{end}}>
 							<span class="item-check-mark">{{svg "octicon-check"}}</span>
-							{{svg "octicon-people" 20}} {{$repoOwnerName}}/{{.Team.Name}}
+							{{ctx.AvatarUtils.Avatar .User 20}} {{template "repo/search_name" .User}}
 						</a>
 					{{end}}
 				{{end}}
-			{{end}}
+				{{if $data.TeamReviewers}}
+					{{if $data.Reviewers}}<div class="divider"></div>{{end}}
+					{{range $data.TeamReviewers}}
+						{{if .Team}}
+							<a class="item muted {{if .Requested}}checked{{end}}" href="#" data-value="{{.ItemID}}" data-can-change="{{.CanChange}}"
+								{{if not .CanChange}} data-tooltip-content="{{ctx.Locale.Tr "repo.issues.remove_request_review_block"}}"{{end}}>
+								<span class="item-check-mark">{{svg "octicon-check"}}</span>
+								{{svg "octicon-people" 20}} {{$repoOwnerName}}/{{.Team.Name}}
+							</a>
+						{{end}}
+					{{end}}
+				{{end}}
+			</div>
 		</div>
 	</div>
 
diff --git a/web_src/css/repo.css b/web_src/css/repo.css
index 01ddab97e59..7307b978702 100644
--- a/web_src/css/repo.css
+++ b/web_src/css/repo.css
@@ -66,6 +66,12 @@
   overflow-x: auto;
 }
 
+.issue-content-right .dropdown > .menu .item-secondary-info small {
+  display: block;
+  text-overflow: ellipsis;
+  overflow: hidden;
+}
+
 @media (max-width: 767.98px) {
   .issue-content-left,
   .issue-content-right {