From 36dce0e457d99ae22530f606ce296ef4946b257b Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 30 May 2021 17:38:44 +0100 Subject: [PATCH] Close the dataRC reader sooner (#16023) Fix #15932 Signed-off-by: Andrew Thornton --- routers/repo/editor.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/routers/repo/editor.go b/routers/repo/editor.go index 2cc5c1e7f2f..2a2c56952d0 100644 --- a/routers/repo/editor.go +++ b/routers/repo/editor.go @@ -106,6 +106,7 @@ func editFile(ctx *context.Context, isNewFile bool) { ctx.NotFound("blob.Data", err) return } + defer dataRc.Close() ctx.Data["FileSize"] = blob.Size() @@ -122,6 +123,10 @@ func editFile(ctx *context.Context, isNewFile bool) { } d, _ := ioutil.ReadAll(dataRc) + if err := dataRc.Close(); err != nil { + log.Error("Error whilst closing blob data: %v", err) + } + buf = append(buf, d...) if content, err := charset.ToUTF8WithErr(buf); err != nil { log.Error("ToUTF8WithErr: %v", err)