From 911993429f3bec0ff4440c012b2a8f295673f961 Mon Sep 17 00:00:00 2001 From: Yarden Shoham Date: Fri, 29 Mar 2024 20:08:54 +0300 Subject: [PATCH] Remove jQuery class from the code range selection (#30173) - Switched from jQuery class functions to plain JavaScript `classList` - Tested the code range selection functionality and it works as before Signed-off-by: Yarden Shoham --- web_src/js/features/repo-code.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web_src/js/features/repo-code.js b/web_src/js/features/repo-code.js index cb5afa83180..63da5f20392 100644 --- a/web_src/js/features/repo-code.js +++ b/web_src/js/features/repo-code.js @@ -25,7 +25,9 @@ function getLineEls() { } function selectRange($linesEls, $selectionEndEl, $selectionStartEls) { - $linesEls.closest('tr').removeClass('active'); + for (const el of $linesEls) { + el.closest('tr').classList.remove('active'); + } // add hashchange to permalink const refInNewIssue = document.querySelector('a.ref-in-new-issue'); @@ -72,7 +74,7 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) { classes.push(`[rel=L${i}]`); } $linesEls.filter(classes.join(',')).each(function () { - $(this).closest('tr').addClass('active'); + this.closest('tr').classList.add('active'); }); changeHash(`#L${a}-L${b}`); @@ -82,7 +84,7 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) { return; } } - $selectionEndEl.closest('tr').addClass('active'); + $selectionEndEl[0].closest('tr').classList.add('active'); changeHash(`#${$selectionEndEl[0].getAttribute('rel')}`); updateIssueHref($selectionEndEl[0].getAttribute('rel'));