From 99082eebd76019fc608e44c4464da6398f51dccd Mon Sep 17 00:00:00 2001 From: Adrian POIGET Date: Mon, 4 May 2020 11:50:29 +0200 Subject: [PATCH] Fix; declare DOMAIN variable for docker setup (#10780) In the /install form, the value for SSH Server Domain is taken form the DOMAIN variable and overwrites SSH_DOMAIN environment variable set the first time if nothing done Co-authored-by: Adrian POIGET --- docker/root/etc/s6/gitea/setup | 1 + docker/root/etc/templates/app.ini | 1 + docs/content/doc/installation/with-docker.en-us.md | 5 +++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docker/root/etc/s6/gitea/setup b/docker/root/etc/s6/gitea/setup index f87ce9115e5..892fa7fd2bd 100755 --- a/docker/root/etc/s6/gitea/setup +++ b/docker/root/etc/s6/gitea/setup @@ -26,6 +26,7 @@ if [ ! -f ${GITEA_CUSTOM}/conf/app.ini ]; then # Substitude the environment variables in the template APP_NAME=${APP_NAME:-"Gitea: Git with a cup of tea"} \ RUN_MODE=${RUN_MODE:-"dev"} \ + DOMAIN=${DOMAIN:-"localhost"} \ SSH_DOMAIN=${SSH_DOMAIN:-"localhost"} \ HTTP_PORT=${HTTP_PORT:-"3000"} \ ROOT_URL=${ROOT_URL:-""} \ diff --git a/docker/root/etc/templates/app.ini b/docker/root/etc/templates/app.ini index e05c24a09ba..9b23c1270d4 100644 --- a/docker/root/etc/templates/app.ini +++ b/docker/root/etc/templates/app.ini @@ -12,6 +12,7 @@ TEMP_PATH = /data/gitea/uploads [server] APP_DATA_PATH = /data/gitea +DOMAIN = $DOMAIN SSH_DOMAIN = $SSH_DOMAIN HTTP_PORT = $HTTP_PORT ROOT_URL = $ROOT_URL diff --git a/docs/content/doc/installation/with-docker.en-us.md b/docs/content/doc/installation/with-docker.en-us.md index 01914a9a2e1..c65e7bc2290 100644 --- a/docs/content/doc/installation/with-docker.en-us.md +++ b/docs/content/doc/installation/with-docker.en-us.md @@ -1,5 +1,5 @@ --- -date: "2016-12-01T16:00:00+02:00" +date: "2020-03-19T19:27:00+02:00" title: "Installation with Docker" slug: "install-with-docker" weight: 10 @@ -253,7 +253,8 @@ You can configure some of Gitea's settings via environment variables: * `APP_NAME`: **"Gitea: Git with a cup of tea"**: Application name, used in the page title. * `RUN_MODE`: **dev**: For performance and other purposes, change this to `prod` when deployed to a production environment. -* `SSH_DOMAIN`: **localhost**: Domain name of this server, used for the displayed clone URL in Gitea's UI. +* `DOMAIN`: **localhost**: Domain name of this server, used for the displayed http clone URL in Gitea's UI. +* `SSH_DOMAIN`: **localhost**: Domain name of this server, used for the displayed ssh clone URL in Gitea's UI. If the install page is enabled, SSH Domain Server takes DOMAIN value in the form (which overwrite this setting on save). * `SSH_PORT`: **22**: SSH port displayed in clone URL. * `SSH_LISTEN_PORT`: **%(SSH\_PORT)s**: Port for the built-in SSH server. * `DISABLE_SSH`: **false**: Disable SSH feature when it's not available.