From b101fa83a6d75922d079e2b7e0437a123a90bb62 Mon Sep 17 00:00:00 2001 From: zeripath Date: Tue, 6 Apr 2021 16:40:56 +0100 Subject: [PATCH] Fix bug in Wrap (#15302) Whilst doing other work I have noticed that there is an issue with Wrap when passing an http.Handler - the next should be the next handler in line not empty. Signed-off-by: Andrew Thornton --- modules/web/route.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/web/route.go b/modules/web/route.go index 59e22c5be15..6f9e76bdf38 100644 --- a/modules/web/route.go +++ b/modules/web/route.go @@ -68,10 +68,11 @@ func Wrap(handlers ...interface{}) http.HandlerFunc { } case func(http.Handler) http.Handler: var next = http.HandlerFunc(func(http.ResponseWriter, *http.Request) {}) - t(next).ServeHTTP(resp, req) - if r, ok := resp.(context.ResponseWriter); ok && r.Status() > 0 { - return + if len(handlers) > i+1 { + next = Wrap(handlers[i+1:]...) } + t(next).ServeHTTP(resp, req) + return default: panic(fmt.Sprintf("Unsupported handler type: %#v", t)) }