gitea

Commit Graph

Author	SHA1	Message	Date
Lunny Xiao	ebf0c96940	Move database operations of merging a pull request to post receive hook and add a transaction (#30805 ) Merging PR may fail because of various problems. The pull request may have a dirty state because there is no transaction when merging a pull request. ref https://github.com/go-gitea/gitea/pull/25741#issuecomment-2074126393 This PR moves all database update operations to post-receive handler for merging a pull request and having a database transaction. That means if database operations fail, then the git merging will fail, the git client will get a fail result. There are already many tests for pull request merging, so we don't need to add a new one. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	10 months ago

Author

SHA1

Message

Date

Lunny Xiao

ebf0c96940

Move database operations of merging a pull request to post receive hook and add a transaction (#30805 )

Merging PR may fail because of various problems. The pull request may
have a dirty state because there is no transaction when merging a pull
request. ref
https://github.com/go-gitea/gitea/pull/25741#issuecomment-2074126393

This PR moves all database update operations to post-receive handler for
merging a pull request and having a database transaction. That means if
database operations fail, then the git merging will fail, the git client
will get a fail result.

There are already many tests for pull request merging, so we don't need
to add a new one.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

10 months ago

1 Commits (0299bb97f038685aee794a992fa4a9f5cf83652e)