4 Commits (0c70b4c211a06e94f2a0a906ed205efcc2932d25)

Author	SHA1	Message	Date
silverwind	19b017f398	Use explicit jQuery import, remove unused eslint globals (#18435) ... - Don't rely on globals (window.$) for jQuery import - Remove eslint globals no longer in use	3 years ago
wxiaoguang	11b4827791	Make the height of the editor in Review Box smaller (4 lines as GitHub) (#18319) ... And shrink the height of Dropzone.	3 years ago
silverwind	3dbdf36d95	Fix CSS specificity issue with easymde's css (#18201) ... * Fix CSS specificity issue with easymde's css PR #18069 introduced a regression in certain overwritten editor styles because the dynamic loading of easymde.min.css causes its's style to apply after our supposed override styles. Solve this by bundling the styles into index.css. We should later aim to completely replace easymde.min.css completely with our own styles so there are no more conflicts. * Update web_src/js/features/comp/EasyMDE.js Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	3 years ago
wxiaoguang	a38ba634a4	Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (#18069) ... This PR makes frontend load EasyMDE/CodeMirror dynamically, and removes `RequireEasyMDE`.	3 years ago
wxiaoguang	48aab263d1	Fix EasyMDE validation (#18161)	3 years ago
Gusted	496acbe9e5	Require codereview to have content (#18156) ... - Report a validityError when the codeReview have no comment. - Resolves #18151 - Refactor	3 years ago
wxiaoguang	0a9fcf63a4	Clean legacy SimpleMDE code (#17926) ... Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore. This PR removes all legacy SimpleMDE code, and makes some related changes: * `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline). * introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE. * rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object. With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.	3 years ago
wxiaoguang	1a7473ff45	Split `index.js` to separate files (#17315) ... * split `index.js` to separate files * tune clipboard * fix promise * fix document * remove intermediate empty file * fix async event listener * use `export function` instead of `export {}`, add more comments Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	3 years ago