1179 Commits (0c8b828f5d5ac7eb8e251edfb1f2536ce1c30336)

Author	SHA1	Message	Date
crazeteam	ecbc9cee2b	Remove repetitive words (#30091) ... remove repetitive words Signed-off-by: crazeteam <lilujing@outlook.com>	8 months ago
silverwind	68ec9b4859	Migrate margin and padding helpers to tailwind (#30043) ... This will conclude the refactor of 1:1 class replacements to tailwind, except `gt-hidden`. Commands ran: ```bash perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g' {web_src/js,templates,routers,services}/**/* ```	8 months ago
wxiaoguang	4734d43e14	Support repo code search without setting up an indexer (#29998) ... By using git's ability, end users (especially small instance users) do not need to enable the indexer, they could also benefit from the code searching feature. Fix #29996   --------- Co-authored-by: silverwind <me@silverwind.io>	8 months ago
silverwind	db01bf6cc8	Various code view improvements (#30014) ... 1. Restore missing styles for message close icon 2. Move `code-line-button` so that it does not go off-screen on small viewports 3. Make `code-line-button` look and behave like other buttons 4. Make `code-line-button` work in blame 5. Make the active selection span the whole line, not just the code part 6. Tweak colors, make dark theme code bg darker, make line numbers same color in diff and file view. 7. Move code background to parent, fixing border radius and other problems 8. Enable code wrap in blame 9. Improve blame responsiveness 10. Remove `--color-code-sidebar-bg` in blame, now it uses same background as code 11. Rename `--color-active-line` to `--color-highlight-bg` 12. Add `--color-highlight-bg` 13. Fix button group borders on hover and border-right on last button. <img width="1343" alt="Screenshot 2024-03-23 at 22 34 13" src="https://github.com/go-gitea/gitea/assets/115237/fcbb919f-5dc3-43f0-97f6-870d6f412554"> <img width="1334" alt="Screenshot 2024-03-23 at 22 34 26" src="https://github.com/go-gitea/gitea/assets/115237/ca44c3b7-4328-4645-ba49-b0dc6a5ac06d"> <img width="1338" alt="Screenshot 2024-03-23 at 22 34 57" src="https://github.com/go-gitea/gitea/assets/115237/00eb0b5a-1ec7-4669-a94a-4602b9d1c1ac"> <img width="1337" alt="Screenshot 2024-03-23 at 22 34 42" src="https://github.com/go-gitea/gitea/assets/115237/752edc4a-064f-413c-9dff-c086187fcd85"> Fixes: https://github.com/go-gitea/gitea/issues/18074	8 months ago
wxiaoguang	1cdc6c3a4e	Escape paths for find file correctly (#30026) ... Fix #30020	8 months ago
Lunny Xiao	f8ab9dafb7	Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995)	8 months ago
wxiaoguang	226231ea27	Fix some pending problems (#29985) ... These changes are quite independent and trivial, so I don't want to open too many PRs. * https://github.com/go-gitea/gitea/pull/29882#discussion_r1529607091 * the `f.Close` should be called properly * the error message could be more meaningful (https://github.com/go-gitea/gitea/pull/29882#pullrequestreview-1942557935) * https://github.com/go-gitea/gitea/pull/29859#pullrequestreview-1942324716 * the new translation strings don't take arguments * https://github.com/go-gitea/gitea/pull/28710#discussion_r1443778807 * stale for long time * #28140 * a form was forgotten to be changed to work with backend code	8 months ago
Zettat123	2f060c5834	Fix bugs in rerunning jobs (#29955) ... Fix #28761 Fix #27884 Fix #28093 ## Changes ### Rerun all jobs When rerun all jobs, status of the jobs with `needs` will be set to `blocked` instead of `waiting`. Therefore, these jobs will not run until the required jobs are completed. ### Rerun a single job When a single job is rerun, its dependents should also be rerun, just like GitHub does (https://github.com/go-gitea/gitea/issues/28761#issuecomment-2008620820). In this case, only the specified job will be set to `waiting`, its dependents will be set to `blocked` to wait the job. ### Show warning if every job has `needs` If every job in a workflow has `needs`, all jobs will be blocked and no job can be run. So I add a warning message. <img src="https://github.com/go-gitea/gitea/assets/15528715/88f43511-2360-465d-be96-ee92b57ff67b" width="480px" />	8 months ago
wxiaoguang	ca4107dc96	Refactor external URL detection (#29973) ... Follow #29960, `IsExternalURL` is not needed anymore. Add some tests for `RedirectToCurrentSite`	8 months ago
wxiaoguang	cdb4d1a8db	Refactor StringsToInt64s (#29967) ... And close #27176	8 months ago
Lunny Xiao	62f8174aa2	Performance improvements for pull request list page (#29900) ... This PR will avoid load pullrequest.Issue twice in pull request list page. It will reduce x times database queries for those WIP pull requests. Partially fix #29585 --------- Co-authored-by: Giteabot <teabot@gitea.io>	8 months ago
wxiaoguang	01500957c2	Refactor URL detection (#29960) ... "Redirect" functions should only redirect if the target is for current Gitea site.	8 months ago
Zettat123	656d8e2267	Fix milestoneID filter bug in issue list (#29897) ... Fix #29717	8 months ago
wxiaoguang	828701ff2d	Fix template error when comment review doesn't exist (#29888) ... Fix #29885	8 months ago
coldWater	0e183d81fc	Fix missing error check of bufio.Scanner (#29882) ... maybe more	8 months ago
wxiaoguang	b251e608c0	Only do counting when count_only=true for repo dashboard (#29884) ... Ref: #29878	8 months ago
buckybytes	16e360099d	Editor error message misleading due to re-used key. (#29859) ... The error message: `editor.file_changed_while_editing = The file contents have changed since you started editing. <a target="_blank" rel="noopener noreferrer" href="%s">Click here</a> to see them or <strong>Commit Changes again</strong> to overwrite them.` Is re-used in inappropriate contexts. The link in the key goes to a 404 when the key is used in a situation where the file contents have not changed. Added two new keys to differentiate commit id mismatch and push out of date conditions.	8 months ago
Nanguan Lin	5ca65d3390	Fix missing code in the user profile (#29865) ... fix #29820 deleted by https://github.com/go-gitea/gitea/pull/29248/files#diff-2b0b591787f16325539485e648a09ab6d3177f47dc129cfe84a35ffe141dfd19L39-L62, which causing malfunction of follow/unfollow and missing description in the user profile page.	8 months ago
wxiaoguang	a889381664	Remove AddParamIfExist(AddParam) (#29841) ... Follow #29834 Remove AddParamIfExist, use "AddParamString" instead, it should clearly know what is being added into the parameters.	8 months ago
6543	1262ff6734	Refactor code_indexer to use an SearchOptions struct for PerformSearch (#29724) ... similar to how it's already done for the issue_indexer --- *Sponsored by Kithara Software GmbH*	8 months ago
wxiaoguang	e0ea3811c4	Refactor AddParam to AddParamIfExist (#29834) ... When read the code: `pager.AddParam(ctx, "search", "search")`, the question always comes: What is it doing? Where is the value from? Why "search" / "search" ? Now it is clear: `pager.AddParamIfExist("search", ctx.Data["search"])`	8 months ago
Denys Konovalov	e0b002a4a8	Unify search boxes (#29530) ... Unify all but a few search boxes to use uniform style, uniform translations and shared templates where possible. Remove a few duplicated search templates, e. g. code search. <details><summary>Example after screenshots:</summary>     </details> Also includes #29700 Co-authored-by: 6543 <6543@obermui.de> --------- Co-authored-by: 6543 <m.huber@kithara.com> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	8 months ago
yp05327	2da13675c0	Fix incorrect menu/link on webhook edit page (#29709) ... Fix #29699 --------- Co-authored-by: silverwind <me@silverwind.io>	8 months ago
Lunny Xiao	66edc888ee	Move fork router functions to a standalone file (#29756) ... To reduce the pull.go file's size.	8 months ago
6543	7fd0a5b276	Refactor to use optional.Option for issue index search option (#29739) ... Signed-off-by: 6543 <6543@obermui.de>	8 months ago
Lunny Xiao	67e9f0d498	Fix user router possbile panic (#29751) ... regression from #28023	8 months ago
6543	9a93b1816e	Refactor label.IsArchived() (#29750) ... just some missed nits	8 months ago
Lunny Xiao	171d3d9a3c	Use Get but not Post to get actions artifacts (#29734)	8 months ago
Lunny Xiao	d8bd6f34f0	Do some performance optimize for issues list and view issue/pull (#29515) ... This PR do some performance optimzations. - [x] Add `index` for the column `comment_id` of `Attachment` table to accelerate query from the database. - [x] Remove unnecessary database queries when viewing issues. Before some conditions which id = 0 will be sent to the database - [x] Remove duplicated load posters - [x] Batch loading attachements, isread of comments on viewing issue --------- Co-authored-by: Zettat123 <zettat123@gmail.com>	8 months ago
Lunny Xiao	aed3b53abd	Some performance optimization on dashboard and issues page (#29010) ... This PR do some loading speed optimization for feeds user interface pages. - Load action users batchly but not one by one. - Load action repositories batchly but not one by one. - Load action's Repo Owners batchly but not one by one. - Load action's possible issues batchly but not one by one. - Load action's possible comments batchly but not one by one.	8 months ago
Zettat123	4129e0e79b	Add a warning for disallowed email domains (#29658) ... Resolve #29660 Follow #29522 and #29609 Add a warning for disallowed email domains when admins manually add/edit users. Thanks @yp05327 for the [comment](https://github.com/go-gitea/gitea/pull/29605#issuecomment-1980105119) 	8 months ago
Lunny Xiao	3c6fc25a77	Use repo object format name instead of detecting from git repository (#29702) ... It's unnecessary to detect the repository object format from git repository. Just use the repository's object format name.	8 months ago
6543	7fdc048153	Patch in exact search for meilisearch (#29671) ... meilisearch does not have an search option to contorl fuzzynes per query right now: - https://github.com/meilisearch/meilisearch/issues/1192 - https://github.com/orgs/meilisearch/discussions/377 - https://github.com/meilisearch/meilisearch/discussions/1096 so we have to create a workaround by post-filter the search result in gitea until this is addressed. For future works I added an option in backend only atm, to enable fuzzynes for issue indexer too. And also refactored the code so the fuzzy option is equal in logic to code indexer --- *Sponsored by Kithara Software GmbH*	8 months ago
Lunny Xiao	25b842df26	Move get/set default branch from git package to gitrepo package to hide repopath (#29126)	8 months ago
Lunny Xiao	ce8a98f878	Fix 500 when deleting account with incorrect password or unsupported login type (#29579) ... Fix #26210 --------- Co-authored-by: Jason Song <i@wolfogre.com>	8 months ago
silverwind	9730d3a9af	Update various logos and unify their filenames (#29637) ... 1. Checked all logos, updated 3 of them to newer versions. 2. Remove `open-with-` infix on the editor logos to be consistent with other files. <img width="626" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/3b2d9486-6e0a-45c6-b0e4-d38dc4c0b118">	8 months ago
Lunny Xiao	e308d25f1b	Cache repository default branch commit status to reduce query on commit status table (#29444) ... After repository commit status has been introduced on dashaboard, the most top SQL comes from `GetLatestCommitStatusForPairs`. This PR adds a cache for the repository's default branch's latest combined commit status. When a new commit status updated, the cache will be marked as invalid. <img width="998" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/76759de7-3a83-4d54-8571-278f5422aed3">	8 months ago
Jason Song	a4bcfb8ef1	Detect broken git hooks (#29494) ... Detect broken git hooks by checking if the commit id of branches in DB is the same with the git repo. It can help #29338 #28277 and maybe more issues. Users could complain about actions, webhooks, and activities not working, but they were not aware that it is caused by broken git hooks unless they could see a warning. <img width="1348" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/2b92a46d-7f1d-4115-bef4-9f970bd695da"> It should be merged after #29493. Otherwise, users could see a ephemeral warning after committing and opening the repo home page immediately. And it also waits for #29495, since the doc link (the anchor part) will be updated. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	8 months ago
wxiaoguang	5cddab4f74	Make wiki default branch name changable (#29603) ... Fix #29000 Fix #28685 Fix #18568 Related: #27497 And by the way fix #24036, add a Cancel button there (one line)	8 months ago
wxiaoguang	61619c84d0	Fix 500 error when adding PR comment (#29622)	8 months ago
Zettat123	136dd99e86	Skip email domain check when admins edit user emails (#29609) ... Follow #29522 Administrators should be able to set a user's email address even if the email address is not in `EMAIL_DOMAIN_ALLOWLIST`	9 months ago
Zettat123	4fd9c56ed0	Skip email domain check when admin users adds user manually (#29522) ... Fix #27457 Administrators should be able to manually create any user even if the user's email address is not in `EMAIL_DOMAIN_ALLOWLIST`.	9 months ago
wxiaoguang	df1268ca08	Make "/user/login" page redirect if the current user has signed in (#29583) ... Fix #29582 and maybe more. Maybe fix #29116	9 months ago
Lunny Xiao	e91733468e	Add missing database transaction for new issue (#29490) ... When creating an issue, inserting issue, assign users and set project should be in the same transaction.	9 months ago
Lunny Xiao	e2277d07ca	Move some asymkey functions to service layer (#28894) ... After the moving, all models will not depend on `util.Rename` so that I can do next step refactoring.	9 months ago
KN4CK3R	c337ff0ec7	Add user blocking (#29028) ... Fixes #17453 This PR adds the abbility to block a user from a personal account or organization to restrict how the blocked user can interact with the blocker. The docs explain what's the consequence of blocking a user. Screenshots:    --------- Co-authored-by: Lauris BH <lauris@nix.lv>	9 months ago
Lunny Xiao	8e12ba34ba	Allow options to disable user ssh keys configuration from the interface on app.ini (#29447) ... Follow #29275 Extract from #20549 Fix #24716 --------- Co-authored-by: delvh <dev.lh@web.de>	9 months ago
Denys Konovalov	fe6792dff3	Enable/disable owner and repo projects independently (#28805) ... Part of #23318 Add menu in repo settings to allow for repo admin to decide not just if projects are enabled or disabled per repo, but also which kind of projects (repo-level/owner-level) are enabled. If repo projects disabled, don't show the projects tab.  --------- Co-authored-by: delvh <dev.lh@web.de>	9 months ago
wxiaoguang	8553b4600e	Add an trailing slash to dashboard links (#29555) ... Fix #29533, and add some tests for "base/paginate.tmpl"	9 months ago
Tim-Niclas Oelschläger	e3524c63d6	Filter Repositories by type (#29231) ... Filter Repositories by type (resolves #1170, #1318) before:  after: 	9 months ago