gitea

Commit Graph

Author	SHA1	Message	Date
zeripath	3fd060eb37	Include OriginalAuthor in Reaction constraint (#13505 ) When migrating repositories with reactions with deleted users, the original author id may be -1. This means that it is possible to end up attempting to create multiple reactions with the same [ Type, IssueID, CommentID, UserID, OriginalAuthorID ] thus breaking the constraints. On SQLite this appears to cause a deadlock but on other dbs this will cause the migration to fail. This PR extends the constraint to include the original author username in the constraint. Fix #13271 Signed-off-by: Andrew Thornton <art27@cantab.net>	4 years ago

Author

SHA1

Message

Date

zeripath

3fd060eb37

Include OriginalAuthor in Reaction constraint (#13505 )

When migrating repositories with reactions with deleted users, the original
author id may be -1. This means that it is possible to end up attempting
to create multiple reactions with the same [ Type, IssueID, CommentID, UserID,
OriginalAuthorID ] thus breaking the constraints.

On SQLite this appears to cause a deadlock but on other dbs this will
cause the migration to fail.

This PR extends the constraint to include the original author username
in the constraint.

Fix #13271

Signed-off-by: Andrew Thornton <art27@cantab.net>

4 years ago

1 Commits (1a2256bf4443baabe0b2009ec752fae7276f3db2)