6092bbac4d
🐛 Fixe a keystring misuse and refactor duplicates keystrings ( #32668 ) ( #32792 )
...
Backport #32668
- Fixes a translation keystring misuse where the string 'open
milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones'
keystrings on the sidebar of an issue, reusing the ones on the issues
filter and action bars.
- Closes #32667
Co-authored-by: Simon Pistache <105607989+SimonPistache@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2 months ago
eee16e433c
Fix fork page branch selection ( #32711 ) ( #32725 )
...
Backport #32711 by @lunny
Fix #32709
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 months ago
a332805f6e
Fix word overflow in file search page ( #32695 ) ( #32699 )
...
Backport #32695 by yp05327
Co-authored-by: yp05327 <576951401@qq.com>
2 months ago
cf2d332443
Refactor find forks and fix possible bugs that weak permissions check ( #32528 ) ( #32547 )
...
Backport #32528
- Move models/GetForks to services/FindForks
- Add doer as a parameter of FindForks to check permissions
- Slight performance optimization for get forks API with batch loading
of repository units
- Add tests for forking repository to organizations
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months ago
2e3a191097
Fix javascript error when an anonymous user visiting migration page ( #32144 ) ( #32179 )
...
backport #32144
This PR fixes javascript errors when an anonymous user visits the
migration page.
It also makes task view checking more restrictive.
The router moved from `/user/task/{id}/status` to
`/username/reponame/-/migrate/status` because it's a migrate status.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
4 months ago
0f834f052b
Allow set branch protection in an empty repository ( #32095 ) ( #32119 )
...
Backport #32095 by @lunny
Resolve #32093
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
5 months ago
d5d5fb1925
Fix Bug in Issue/pulls list ( #32081 ) ( #32115 )
5 months ago
1f8cbbab3d
Fix rename branch permission bug ( #32066 ) ( #32108 )
...
Backport #32066 by @lunny
The previous implementation requires admin permission to rename branches
which should be write permission.
Fix #31993
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
5 months ago
b6ede69a1b
Fixes for unreachable project issues when transfer repository from organization ( #31770 ) ( #31828 )
...
Backport #31770 by @emrebdr
When transferring repositories that have issues linked to a project
board to another organization, the issues remain associated with the
original project board. This causes the columns in the project board to
become bugged, making it difficult to move other issues in or out of the
affected columns. As a solution, I removed the issue relations since the
other organization does not have this project table.
Fix for #31538
Co-authored-by: Edip Emre Bodur <emrebdr29@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
6 months ago
a39fe53252
Show lock owner instead of repo owner on LFS setting page ( #31788 ) ( #31817 )
...
Backport #31788 by @wolfogre
Fix #31784 .
Before:
<img width="1648" alt="image"
src="https://github.com/user-attachments/assets/03f32545-4a85-42ed-bafc-2b193a5d8023 ">
After:
<img width="1653" alt="image"
src="https://github.com/user-attachments/assets/e5bcaf93-49cb-421f-aac1-5122bc488b02 ">
Co-authored-by: Jason Song <i@wolfogre.com>
6 months ago
8591c918f6
Fix the display of project type for deleted projects ( #31732 ) ( #31734 )
...
Backport #31732 by @yp05327
Fix : #31727
After:
Co-authored-by: yp05327 <576951401@qq.com>
6 months ago
3cecfa3df4
use correct l10n string ( #31487 ) ( #31490 )
...
Backport #31487 by CyberFlameGO
Co-authored-by: CyberFlame <cyberflameu@gmail.com>
8 months ago
a3529d662f
Fix the link for .git-blame-ignore-revs bypass ( #31432 ) ( #31442 )
...
Backport #31432 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
8 months ago
a4f977e00b
Fix the wrong line number in the diff view page when expanded twice. ( #31431 ) ( #31440 )
...
Backport #31431 by @charles7668
close #31149
The problem is caused by the `data-query=` string affecting the parsing
of the `last_left` parameter. When the page is first rendered,
`data-query=` does not exist. However, after clicking expand, the
returned HTML contains this string, causing the line numbers to start
from 1 upon expanding a second time.
before fix
after fix
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
8 months ago
4b6ef9265b
Fix navbar `+` menu flashing on page load ( #31281 ) ( #31342 )
...
Backport #31281 by silverwind
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
8 months ago
c07416b3d0
Fix Activity Page Contributors dropdown ( #31264 ) ( #31269 )
...
Backport #31264 by wxiaoguang
Fix #31261
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
8 months ago
331c32f9b6
Fix overflow on push notification ( #31179 ) ( #31238 )
...
Backport #31179 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/30063
<img width="1301" alt="Screenshot 2024-05-30 at 14 43 24"
src="https://github.com/go-gitea/gitea/assets/115237/00443af0-088d-49a5-be9e-8c9adcc2c01d ">
Co-authored-by: silverwind <me@silverwind.io>
8 months ago
0328f31fdc
Fix overflow in issue card ( #31203 ) ( #31225 )
...
Backport #31203 by @silverwind
Before:
<img width="373" alt="Screenshot 2024-06-01 at 01 31 26"
src="https://github.com/go-gitea/gitea/assets/115237/82a210f2-c82e-4b7e-ac43-e70e46fa1186 ">
After:
<img width="376" alt="Screenshot 2024-06-01 at 01 31 32"
src="https://github.com/go-gitea/gitea/assets/115237/82d1b9f7-4fad-47bd-948a-04e1e7e006e6 ">
Co-authored-by: silverwind <me@silverwind.io>
8 months ago
33fa93a952
Fix agit checkout command line hint & fix ShowMergeInstructions checking ( #31219 ) ( #31222 )
...
Backport #31219 by @lunny
Fix #31135
Before
<img width="527" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/60c07b55-3db2-4a9a-98f1-0eb72d149df2 ">
After
<img width="664" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/0670ff5d-9e0b-47ac-aba4-9db9131de3b3 ">
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
8 months ago
a672f066f7
Use vertical layout for multiple code expander buttons ( #31122 ) ( #31152 )
...
Backport #31122 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31068
- Now it only does a single call to `GetExpandDirection` per line
instead of multiples.
- Exposed `data-expand-direction` to frontend so it can correctly size
the buttons (it's a pain to do in tables).
<img width="142" alt="Screenshot 2024-05-27 at 20 44 56"
src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941 ">
<img width="142" alt="Screenshot 2024-05-27 at 20 44 51"
src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892 ">
<img width="132" alt="Screenshot 2024-05-27 at 20 44 46"
src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 33"
src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8 ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 26"
src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199 ">
<img width="78" alt="Screenshot 2024-05-27 at 20 44 20"
src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28 ">
Would backport as trivial enhancement.
Co-authored-by: silverwind <me@silverwind.io>
8 months ago
b615a59db8
Improve mobile review ui ( #31091 ) ( #31136 )
...
Backport #31091 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31071
Not perfect but much better than before.
Before: Overflows, sticky not working, filename unreadable:
<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f ">
After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c ">
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
b903e2b753
Prevent tab shifting, remove extra margin on fluid pages ( #31090 ) ( #31099 )
...
Backport #31090 by @silverwind
1. Extend concept of https://github.com/go-gitea/gitea/pull/29831 to all
tabular menus, there were only three left that weren't already
`<overflow-menu>`.
<img width="634" alt="Screenshot 2024-05-27 at 00 42 16"
src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd ">
<img width="965" alt="Screenshot 2024-05-27 at 00 29 32"
src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff ">
2. Remove extra padding on `fluid padded` container like for example PR
diff view. The page margin is already correctly sized via
`.ui.container`, so this was just extraneous padding that looked ugly.
Before:
<img width="1351" alt="Screenshot 2024-05-27 at 00 45 11"
src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472 ">
After:
<img width="1344" alt="Screenshot 2024-05-27 at 00 45 22"
src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b ">
3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title,
fixing overflow.
Before:
<img width="1333" alt="Screenshot 2024-05-27 at 00 50 14"
src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb ">
After:
<img width="1316" alt="Screenshot 2024-05-27 at 00 50 26"
src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8 ">
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
7d56ee3c0f
Support setting the `default` attribute of the issue template dropdown field ( #31045 ) ( #31059 )
...
Backport #31045 by @Zettat123
Fix #31044
According to [GitHub issue template
documentation](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-for-dropdown ),
the `default` attribute can be used to specify the preselected option
for a dropdown field.
Co-authored-by: Zettat123 <zettat123@gmail.com>
9 months ago
564fef1e20
Fix wrong display of recently pushed notification ( #25812 ) ( #31043 )
...
Backport #25812
~~ps: removed some new codes in `tests/integration/pull_merge_test.go`~~
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
27a4c67992
Don't include link of deleted branch when listing branches ( #31028 ) ( #31032 )
...
Backport #31028 by @kemzeb
From
https://github.com/go-gitea/gitea/issues/31018#issuecomment-2119622680 .
This commit removes the link to a deleted branch name because it returns
a 404 while it is in this deleted state. GitHub also throws a 404 when
navigating to a branch link that was just deleted, but this deleted
branch is removed from the branch list after a page refresh. Since with
Gitea this deleted branch would be kept around for quite some time
(well, until the "cleanup deleted branches" cron job begins), it makes
sense to not have this as a link that users can navigate to.
Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com>
9 months ago
8663a351d1
Fix incorrect "blob excerpt" link when comparing files ( #31013 ) ( #31026 )
...
Backport #31013 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
ab33b7849f
Fix "force private" logic ( #31012 ) ( #31021 )
...
Backport #31012 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
bd3787c774
Fix JS error when editing a merged PR's title ( #30990 ) ( #31001 )
...
Backport #30990 by @wxiaoguang
Regression of Fix issue/PR title edit (#30858 )
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
835411b978
template: `label` fix correct input id ( #30987 ) ( #30997 )
...
Just a small commit to fix a wrong label for id.
Thanks and cheers!
Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
Co-authored-by: Frank Villaro-Dixon <frank@vi-di.fr>
9 months ago
3cdf9ed202
Put web editor into a segment ( #30966 ) ( #30993 )
...
Backport #30966 by silverwind
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
c1337e7316
Restyle release list, fix branch dropdown ( #30837 ) ( #30968 )
...
Backport #30837 by @silverwind
Fixes https://github.com/go-gitea/gitea/issues/30821 and restyles the
release list.
Desktop:
<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd ">
Mobile:
<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d ">
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
ebe8e63dfd
Fix file path width in repo non-homepage view ( #30951 ) ( #30952 )
...
Backport #30951 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/30940
<img width="1310" alt="Screenshot 2024-05-11 at 20 48 41"
src="https://github.com/go-gitea/gitea/assets/115237/f163dfd4-1299-421f-a99e-cd0c793e0e3d ">
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
94c5a30c8b
Fix some UI regressions for commit list ( #30920 ) ( #30937 )
...
Backport #30920 by wxiaoguang
Close #30919
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
5f1af1f37d
Fix incorrect issue form ( #30881 ) ( #30904 )
...
Backport #30881 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
b22d7fd8cd
Fix some UI problems (dropdown/container) ( #30849 ) ( #30871 )
...
Backport #30849 by wxiaoguang
Follow #30345
Follow #30547
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
60fa2a5960
Fix issue/PR title edit ( #30858 ) ( #30865 )
...
Backport #30858 by wxiaoguang
1. "enter" doesn't work (I think it is the last enter support for #14843 )
2. if a branch name contains something like `&`, then the branch selector doesn't update
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
41f8ef8af5
Improve repo button row layout ( #30668 ) ( #30839 )
...
Backport #30668 by @silverwind
Since there is now a second `<input>` in the repo buttons, we can make a
better-looking layout with no empty space, except on mobile.
Also I fixed one bug with focus border on clone panel.
## Large
<img width="1163" alt="Screenshot 2024-04-23 at 22 25 22"
src="https://github.com/go-gitea/gitea/assets/115237/8135a572-aa67-4672-ad49-b76b06890b52 ">
## Medium
<img width="870" alt="Screenshot 2024-04-23 at 22 25 34"
src="https://github.com/go-gitea/gitea/assets/115237/9e93f61c-3315-4a78-8328-8cefad5b50fa ">
## Mobile
<img width="416" alt="Screenshot 2024-04-23 at 22 25 52"
src="https://github.com/go-gitea/gitea/assets/115237/859e341f-807a-48e6-8bcf-31715963216c ">
Co-authored-by: silverwind <me@silverwind.io>
9 months ago
ee17289eeb
Fix issue card layout ( #30800 ) ( #30820 )
...
Backport #30800 by wxiaoguang
Fix #30788
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
d793f256c8
Fix branch selector UI ( #30803 ) ( #30819 )
...
Backport #30803 by wxiaoguang
Fix #30802
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
6ee3a8a039
Right align the "Settings" menu item in overflow-menu ( #30764 ) ( #30777 )
...
Backport #30764 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
6edee2eca4
Rename CodeIndexerEnabled to IsRepoIndexerEnabled ( #30762 ) ( #30767 )
...
Backport #30762 by @wxiaoguang
Fix #30761
Most places use `IsRepoIndexerEnabled` but not `CodeIndexerEnabled`, so
it should always use `IsRepoIndexerEnabled` for consistency.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
6c86034e0f
Fix all rounded borders, change affected tab menus to pills ( #30707 ) ( #30769 )
...
Backport #30707 by @silverwind
Fixes https://github.com/go-gitea/gitea/issues/30673 , all 23 issues.
Notes:
- Tab bar menus had to change to pills because of unsolvable issue with
the border-radius as tab bar renders a overlapping border onto the box
below. And I think pills look better.
- Added padding to code editor empty preview message
- Hide monaco's built-in blue focus border, we don't need it and it
never showed before either.
- Label add menu is simplified, removing the nested segment.
<img width="1322" alt="Screenshot 2024-04-25 at 22 26 19"
src="https://github.com/go-gitea/gitea/assets/115237/7e394e0c-b7ad-417d-8e9f-12f1dea93ed1 ">
<img width="1326" alt="Screenshot 2024-04-25 at 22 28 00"
src="https://github.com/go-gitea/gitea/assets/115237/66c8499f-aa9f-4d95-8cca-ef13dfa82c65 ">
<img width="997" alt="Screenshot 2024-04-25 at 22 36 53"
src="https://github.com/go-gitea/gitea/assets/115237/07896102-c71d-4246-8173-c2bc2e1d3cae ">
<img width="832" alt="Screenshot 2024-04-25 at 22 56 09"
src="https://github.com/go-gitea/gitea/assets/115237/d83afc96-08ca-4adc-baf4-3d02804be57c ">
<img width="361" alt="Screenshot 2024-04-25 at 22 57 12"
src="https://github.com/go-gitea/gitea/assets/115237/c7371a68-00b5-47d8-84d0-ddc5268b2b2c ">
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
8de2992ffb
Make Ctrl+Enter work for issue/comment edit ( #30720 )
...
Fix #30710
10 months ago
b93c87b6fe
Issue card improvements ( #30687 )
...
Fixes https://github.com/go-gitea/gitea/issues/30682 and does a few
improvements:
- Use gap instead of margin/padding
- Don't render empty image div
- Remove `right floated` class that did nothing
<img width="406" alt="Screenshot 2024-04-24 at 20 21 20"
src="https://github.com/go-gitea/gitea/assets/115237/2fa88707-c2c4-40df-aee7-a684c3097ed0 ">
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
10 months ago
dd301cae1c
Prevent allow/reject reviews on merged/closed PRs ( #30686 )
...
Resolves #30675 .
10 months ago
b2abac5e5f
Improve diff stats bar ( #30669 )
...
Minor tweaks:
- Remove unnecessary `item` class which was causing unwanted padding to
be added.
- Add some padding and prevent wrapping so it looks better on mobile.
- Increase width by 4px.
<img width="116" alt="Screenshot 2024-04-24 at 00 15 07"
src="https://github.com/go-gitea/gitea/assets/115237/1f1cf54c-8053-4297-b309-71d9c2ceb9ee ">
<img width="441" alt="Screenshot 2024-04-24 at 00 14 57"
src="https://github.com/go-gitea/gitea/assets/115237/2f3a33dc-edad-4b97-b64c-6812aae513cb ">
10 months ago
c93eefb42b
Diff color enhancements, add line number background ( #30670 )
...
1. Bring back the background on line numbers. This feature was lost a
long time ago.
<img width="457" alt="Screenshot 2024-04-24 at 01 36 09"
src="https://github.com/go-gitea/gitea/assets/115237/76a7f5a9-c22a-4c72-9f0a-ebf16a66513e ">
<img width="473" alt="Screenshot 2024-04-24 at 01 22 47"
src="https://github.com/go-gitea/gitea/assets/115237/eef06cf2-f1b9-40e3-947d-dd5852ec12a3 ">
<img width="457" alt="Screenshot 2024-04-24 at 02 13 18"
src="https://github.com/go-gitea/gitea/assets/115237/59e317d4-76a7-468c-8a19-10d88c675cc3 ">
<img width="459" alt="Screenshot 2024-04-24 at 01 23 21"
src="https://github.com/go-gitea/gitea/assets/115237/f1a46f8d-8846-4d78-a9d7-8b7dc18ac6e4 ">
2. Expanded lines background is now full-line, including line numbers:
<img width="1303" alt="Screenshot 2024-04-24 at 01 37 12"
src="https://github.com/go-gitea/gitea/assets/115237/271eefe2-0869-424e-93fb-ccd8adc87806 ">
3. Sort affected colors alphabetically in the CSS
Fixes #14603
10 months ago
993736d838
Fix code search input for different views ( #30678 )
...
Now only show the "code search" on the repo home page, because it only
does global search.
So do not show it when viewing file or directory to avoid misleading
users (it doesn't search in a directory)
10 months ago
2a3906d755
Improve job commit description ( #30579 )
...
Fix https://github.com/go-gitea/gitea/issues/30567
When job is a schedule:
When it is a normal one:
also add a 'space' behind `:`
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
10 months ago
a63f14b908
Fix view of readme file in the home code page. ( #30564 )
...
Gitea attempts to display image file, pdf file, etc. named readme in the
home code page (but it cannot).
I think only the markdown and plain-text file should be displayed, which
is also the behavior of GitHub.
Co-authored-by: jxshin <zhujiaxinabc@gmail.com>
10 months ago
Lunny Xiao
Giteabot
yp05327
wxiaoguang
silverwind
Kemal Zebari
Jiaxin Zhu