gitea

Commit Graph

Author	SHA1	Message	Date
Yarden Shoham	f47e00d9d3	Remove jQuery `.attr` from the Fomantic modal cancel buttons (#30113 ) - Switched from jQuery `attr` to plain javascript `setAttribute` - Tested the modals and they work as before --------- Co-authored-by: silverwind <me@silverwind.io>	11 months ago
wxiaoguang	f860fe31d9	Move some JS code from `fomantic.js` to standalone files (#27994 ) To improve maintainability, this PR: 1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic` (the code there are all for aria of fomantic) 2. Move api/transition related code to `web_src/js/modules/fomantic/api.js` and `web_src/js/modules/fomantic/transition.js` No logic is changed.	1 year ago
wxiaoguang	45bc180a15	Make "cancel" buttons have proper type in modal forms (#25618 ) Replace #25446, fix #25438 All "cancel" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". This is a complete fix for all modal dialogs. The major change is "modules/aria/modal.js", "devtest" related code is for demo/test purpose.	2 years ago

Author

SHA1

Message

Date

Yarden Shoham

f47e00d9d3

Remove jQuery `.attr` from the Fomantic modal cancel buttons (#30113 )

- Switched from jQuery `attr` to plain javascript `setAttribute`
- Tested the modals and they work as before

---------

Co-authored-by: silverwind <me@silverwind.io>

11 months ago

wxiaoguang

f860fe31d9

Move some JS code from `fomantic.js` to standalone files (#27994 )

To improve maintainability, this PR: 

1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic`
(the code there are all for aria of fomantic)
2. Move api/transition related code to
`web_src/js/modules/fomantic/api.js` and
`web_src/js/modules/fomantic/transition.js`

No logic is changed.

1 year ago

wxiaoguang

45bc180a15

Make "cancel" buttons have proper type in modal forms (#25618 )

Replace #25446, fix #25438

All "cancel" buttons which do not have "type" should not submit the
form, should not be triggered by "Enter".

This is a complete fix for all modal dialogs.

The major change is "modules/aria/modal.js", "devtest" related code is
for demo/test purpose.

2 years ago

2 Commits (3cecfa3df462e41745db5f5f4ffb7ffd23f745b1)