gitea

Commit Graph

Author	SHA1	Message	Date
yp05327	bd66fa586a	Rename `repo.GetOwner` to `repo.LoadOwner` (#22967 ) Fixes https://github.com/go-gitea/gitea/issues/22963 --------- Co-authored-by: Yarden Shoham <hrsi88@gmail.com>	2 years ago
Lunny Xiao	bd820aa9c5	Add context cache as a request level cache (#22294 ) To avoid duplicated load of the same data in an HTTP request, we can set a context cache to do that. i.e. Some pages may load a user from a database with the same id in different areas on the same page. But the code is hidden in two different deep logic. How should we share the user? As a result of this PR, now if both entry functions accept `context.Context` as the first parameter and we just need to refactor `GetUserByID` to reuse the user from the context cache. Then it will not be loaded twice on an HTTP request. But of course, sometimes we would like to reload an object from the database, that's why `RemoveContextData` is also exposed. The core context cache is here. It defines a new context ```go type cacheContext struct { ctx context.Context data map[any]map[any]any lock sync.RWMutex } var cacheContextKey = struct{}{} func WithCacheContext(ctx context.Context) context.Context { return context.WithValue(ctx, cacheContextKey, &cacheContext{ ctx: ctx, data: make(map[any]map[any]any), }) } ``` Then you can use the below 4 methods to read/write/del the data within the same context. ```go func GetContextData(ctx context.Context, tp, key any) any func SetContextData(ctx context.Context, tp, key, value any) func RemoveContextData(ctx context.Context, tp, key any) func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error) ``` Then let's take a look at how `system.GetString` implement it. ```go func GetSetting(ctx context.Context, key string) (string, error) { return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) { return cache.GetString(genSettingCacheKey(key), func() (string, error) { res, err := GetSettingNoCache(ctx, key) if err != nil { return "", err } return res.SettingValue, nil }) }) } ``` First, it will check if context data include the setting object with the key. If not, it will query from the global cache which may be memory or a Redis cache. If not, it will get the object from the database. In the end, if the object gets from the global cache or database, it will be set into the context cache. An object stored in the context cache will only be destroyed after the context disappeared.	2 years ago
Brecht Van Lommel	49919c636e	Pull Requests: setting to allow edits by maintainers by default, tweak UI (#22862 ) Add setting to allow edits by maintainers by default, to avoid having to often ask contributors to enable this. This also reorganizes the pull request settings UI to improve clarity. It was unclear which checkbox options were there to control available merge styles and which merge styles they correspond to. Now there is a "Merge Styles" label followed by the merge style options with the same name as in other menus. The remaining checkboxes were moved to the bottom, ordered rougly by typical order of operations. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2 years ago
KN4CK3R	a35749893b	Move `convert` package to services (#22264 ) Addition to #22256 The `convert` package relies heavily on different models which is [disallowed by our definition of modules](https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#design-guideline). This helps to prevent possible import cycles. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2 years ago
Lunny Xiao	68704532c2	Rename almost all Ctx functions (#22071 )	2 years ago
Lunny Xiao	0a7d3ff786	refactor some functions to support ctx as first parameter (#21878 ) Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Lauris BH <lauris@nix.lv>	2 years ago
flynnnnnnnnnn	e81ccc406b	Implement FSFE REUSE for golang files (#21840 ) Change all license headers to comply with REUSE specification. Fix #16132 Co-authored-by: flynnnnnnnnnn <flynnnnnnnnnn@github> Co-authored-by: John Olheiser <john.olheiser@gmail.com>	2 years ago
Andrew Imeson	d94f15c2fd	Make external issue tracker regexp configurable via API (#21338 ) Fixes #21336 Signed-off-by: Andrew Imeson <andrew@andrewimeson.com>	2 years ago
Lunny Xiao	1d8543e7db	Move some files into models' sub packages (#20262 ) * Move some files into models' sub packages * Move functions * merge main branch * Fix check * fix check * Fix some tests * Fix lint * Fix lint * Revert lint changes * Fix error comments * Fix lint Co-authored-by: 6543 <6543@obermui.de>	2 years ago
Bian Jiaping	e49ef56dde	Add allow_rebase_update, default_delete_branch_after_merge to repository api response (#20079 ) `PATCH /repos/{owner}/{repo}` API allows users to update `allow_rebase_update`, `default_delete_branch_after_merge`, but `GET /repos/{owner}/{repo}` API does not return these two options, and API users has no other ways to find the state of these two options. This PR add `allow_rebase_update`, `default_delete_branch_after_merge` to repository query api response.	2 years ago
Lunny Xiao	fd7d83ace6	Move almost all functions' parameter db.Engine to context.Context (#19748 ) * Move almost all functions' parameter db.Engine to context.Context * remove some unnecessary wrap functions	3 years ago
6543	b135313c47	[Refactor] convert team(s) to apiTeam(s) (#13745 ) * Refactor: teams to api convert * make org load optional * more info in tests	3 years ago
Lauris BH	6392f4691a	API: Return primary language and repository language stats API URL (#18396 )	3 years ago
6543	54e9ee37a7	format with gofumpt (#18184 ) * gofumpt -w -l . * gofumpt -w -l -extra . * Add linter * manual fix * change make fmt	3 years ago
Peter Gardfjäll	89a3214352	Add MirrorUpdated field to Repository API type (#18267 ) Add the last update time to the repository api type. Close #18266	3 years ago
qwerty287	7cc44491fa	Add API to manage repo tranfers (#17963 )	3 years ago
Lunny Xiao	719bddcd76	Move repository model into models/repo (#17933 ) * Some refactors related repository model * Move more methods out of repository * Move repository into models/repo * Fix test * Fix test * some improvements * Remove unnecessary function	3 years ago
Lunny Xiao	1fee11d69a	Move accessmode into models/perm (#17828 )	3 years ago
Lunny Xiao	99b2858e62	Move unit into models/unit/ (#17576 ) * Move unit into models/unit/ * Rename unit.UnitType as unit.Type	3 years ago
6543	75205b5669	Fix some API bugs (#16184 ) * Repository object only count releases as releases (fix #16144) * EditOrg respect RepoAdminChangeTeamAccess option (fix #16013)	3 years ago
6543	290cf75f93	[refactor] Unify the export of user data via API (#15144 ) * [refactor] unify how user data is exported via API * test time via unix timestamp	4 years ago
parnic	f4d27498bd	Add DefaultMergeStyle option to repository (#14789 ) Fixes #12293	4 years ago
Paul Barton	7576e37a65	Add MirrorInterval to the API (#14163 ) * Added MirrorInterval to the API * Remove MirrorInterval from CreateRepository * Removed Duplicate UpdateMirror Function * Updated Error Logging * Update Log Message for is not Mirror Co-authored-by: 6543 <6543@obermui.de> * Delete Debug Statement that snuck in Co-authored-by: zeripath <art27@cantab.net> * Add Check for If Interval is too small * Output to API Call * Add Error Object when time is Less than Min Interval * Frequency Error Message Co-authored-by: zeripath <art27@cantab.net> * Allow Zero Mirror Interval Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: zeripath <art27@cantab.net>	4 years ago
Eric Belhomme	6ddf881245	issue #12450 : return original URL in `original_url` JSON field (#13885 ) Co-authored-by: Gitea <gitea@fake.local>	4 years ago
6543	7ac8a770e1	Move Repo APIFormat to convert package (#13787 ) * Move Repo APIFormat to convert package * tweek	4 years ago

4 Commits (447fa6715ca56ea0a7d2d411d82bced4a6ffec31)