silverwind
d061f6b70a
Change typescript `module` to `nodenext` ( #32757 )
...
Typescript 5.7 changed semantics around JSON imports and `nodenext` is
now [treated
differently](https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-beta/#validated-json-imports-in---module-nodenext )
than `node16` for JSON imports and it requires the import attribute, so
change the value to that and add the attribute to eliminate this
typescript error.
[`moduleResolution`](https://www.typescriptlang.org/tsconfig/#moduleResolution )
is treated as an alias when `module` is `nodenext`, so we don't need to
specify it.
Also see https://github.com/microsoft/TypeScript/issues/60589 . It
appears the next Typescript release will fix this for `node16`, but I
guess it'll still be good to switch to `nodenext`.
2 months ago
silverwind
675c288811
Fix some typescript issues ( #32586 )
...
Fixes around 30 or so typescript errors. No runtime changes.
3 months ago
wxiaoguang
a4a121c684
Fix suggestions for issues ( #32380 )
4 months ago
Anbraten
b7fb20e73e
Suggestions for issues ( #32327 )
...
closes #16872
4 months ago
silverwind
7207d93f01
Fix a number of Typescript issues ( #31877 )
...
Typescript error count is reduced from 633 to 540 with this. No runtime
changes except in test code.
6 months ago
silverwind
5791a73e75
Convert frontend code to typescript ( #31559 )
...
None of the frontend js/ts files was touched besides these two commands
(edit: no longer true, I touched one file in
61105d0618
because of a deprecation that was not showing before the rename).
`tsc` currently reports 778 errors, so I have disabled it in CI as
planned.
Everything appears to work fine.
8 months ago
wxiaoguang
74930b1ccd
Avoiding accessing undefined mentionValues ( #26461 )
...
The `window.config.mentionValues` might be undefined:
```
{{if or .Participants .Assignees .MentionableTeams}}
mentionValues: ...
{{end}}
```
2 years ago
silverwind
ef6f5f0124
rename tributeValues to mentionValues ( #25375 )
...
Very simple change, just rename this variable so it does not feature the
name of the module.
2 years ago
silverwind
4aacc3ac78
Add two eslint plugins ( #24776 )
...
Add these two plugins and autofix issues:
-
[eslint-plugin-no-use-extend-native](https://github.com/dustinspecker/eslint-plugin-no-use-extend-native )
-
[eslint-plugin-array-func](https://github.com/freaktechnik/eslint-plugin-array-func )
2 years ago
Yarden Shoham
3cc87370c3
Improve emoji and mention matching ( #24255 )
...
Prioritize matches that start with the given text, then matches that
contain the given text.
I wanted to add a heart emoji on a pull request comment so I started
writing `:`, `h`, `e`, `a`, `r` (at this point I still couldn't find the
heart), `t`... The heart was not on the list, that's weird - it feels
like I made a typo or a mistake. This fixes that.
This also feels more like GitHub's emoji auto-complete.
# Before

# After

---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2 years ago