gitea

Commit Graph

Author	SHA1	Message	Date
silverwind	c7f4ca2653	Enable Typescript `noImplicitAny` (#33322 ) Enable `noImplicitAny` and fix all issues. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 week ago
silverwind	4b21a6c792	Enable Typescript `noImplicitThis` (#33250 ) - Enable https://www.typescriptlang.org/tsconfig/#noImplicitThis - Wrap Vue Template-Syntax SFCs in [`defineComponent`](https://vuejs.org/api/general#definecomponent) which makes type inference and linter work better - Move `createApp` calls outside the SFCs into separate files - Use [`PropType`](https://vuejs.org/api/utility-types#proptype-t) where appropriate - Some top-level component properties changed order as dictated by the linter - Fix all tsc and lint issues that popped up during these refactors	2 weeks ago
silverwind	1518f4ed12	Fix typescript errors in Vue files, fix regression in "Recent Commits" chart (#32649 ) - Fix all typescript errors in `.vue` files - Fix regression from https://github.com/go-gitea/gitea/pull/32329 where "Recent Commits" chart would not render. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2 months ago
silverwind	8107823026	Fix a number of typescript issues (#32308 ) - Prefer [window.location.assign](https://developer.mozilla.org/en-US/docs/Web/API/Location/assign) over assigning to [window.location](https://developer.mozilla.org/en-US/docs/Web/API/Window/location) which typescript does not like. This works in all browsers including PaleMoon. - Fix all typescript issues in `web_src/js/webcomponents`, no behaviour changes. - ~~Workaround bug in `@typescript-eslint/no-unnecessary-type-assertion` rule.~~ - Omit vendored file from type checks. - `tsc` error count is reduce by 53 with these changes.	3 months ago
wxiaoguang	169031b7cf	Fix "Filter by commit" Dropdown (#31695 ) Regression of #31281 Fix #31673	6 months ago
silverwind	5791a73e75	Convert frontend code to typescript (#31559 ) None of the frontend js/ts files was touched besides these two commands (edit: no longer true, I touched one file in `61105d0618` because of a deprecation that was not showing before the rename). `tsc` currently reports 778 errors, so I have disabled it in CI as planned. Everything appears to work fine.	7 months ago
silverwind	17baf1af10	Update JS dependencies, remove `eslint-plugin-jquery` (#31402 ) - Result of `make update-js` - Added 1 new eslint rule - Autofixed 1 new eslint issue - Remove `eslint-plugin-jquery` as `eslint-plugin-no-jquery` does all it does and is actually the maintained fork of it. - Tested all affected `dependencies` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	8 months ago
silverwind	21ba5ca03b	Fix navbar `+` menu flashing on page load (#31281 ) Fixes https://github.com/go-gitea/gitea/pull/31273#issuecomment-2153771331. Same method as used in https://github.com/go-gitea/gitea/pull/30215. All left-opening dropdowns need to use it method. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	8 months ago
silverwind	507fbf4c3c	Use `querySelector` over alternative DOM methods (#31280 ) As per https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164, prefer `querySelector` by enabling [`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md) and autofixing all except 10 issues. According to [this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/), querySelector may be faster as well, so it's a win-win. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	8 months ago
silverwind	226a82a939	Migrate font-family to tailwind (#30118 ) Enable us to use tailwind's [`font-family`](https://tailwindcss.com/docs/font-family) classes as well as remove `gt-mono` in favor of `tw-font-mono`. I also merged the "compensation" to one selector, previously this was two different values 0.9em and 0.95em. I did not declare a `serif` font because I don't think there will ever be a use case for those. Command ran: ```sh perl -p -i -e 's#gt-mono#tw-font-mono#g' web_src/js/*/ templates/*/	10 months ago
silverwind	8fe26fb314	Refactor all `.length === 0` patterns in JS (#30045 ) This pattern comes of often during review, so let's fix it once and for all. Did not test, but changes are trivial enough imho.	10 months ago
silverwind	68ec9b4859	Migrate margin and padding helpers to tailwind (#30043 ) This will conclude the refactor of 1:1 class replacements to tailwind, except `gt-hidden`. Commands ran: ```bash perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-0#tw-$1$2-0#g' {web_src/js,templates,routers,services}/*/ perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/*/ perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-2#tw-$1$2-1#g' {web_src/js,templates,routers,services}/*/ perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-3#tw-$1$2-2#g' {web_src/js,templates,routers,services}/*/ perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-4#tw-$1$2-4#g' {web_src/js,templates,routers,services}/*/ perl -p -i -e 's#gt-(p\|m)([lrtbxy])?-5#tw-$1$2-8#g' {web_src/js,templates,routers,services}/*/ ```	10 months ago
silverwind	90a4f9a49e	Migrate `gap` helpers to tailwind (#30034 ) Commands ran: ```sh perl -p -i -e 's#gt-gap-0#tw-gap-0#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-1#tw-gap-0.5#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-2#tw-gap-1#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-3#tw-gap-2#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-4#tw-gap-4#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-5#tw-gap-8#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-0#tw-gap-x-0#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-1#tw-gap-x-0.5#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-2#tw-gap-x-1#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-3#tw-gap-x-2#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-4#tw-gap-x-4#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-x-5#tw-gap-x-8#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-0#tw-gap-y-0#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-1#tw-gap-y-0.5#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-2#tw-gap-y-1#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-3#tw-gap-y-2#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-4#tw-gap-y-4#g' web_src/js/*/ templates/*/ perl -p -i -e 's#gt-gap-y-5#tw-gap-y-8#g' web_src/js/*/ templates/*/	10 months ago
silverwind	3d751b6ec1	Enforce trailing comma in JS on multiline (#30002 ) To keep blame info accurate and to avoid [changes like this](https://github.com/go-gitea/gitea/pull/29977/files#diff-c3422631a14edbe1e508c4b22f0c718db318be08a6e889427802f9b6165d88d6R359), it's good to always have a trailing comma, so let's enforce it in JS. This rule is completely automatically fixable with `make lint-js-fix` and that's what I did here.	11 months ago
silverwind	f88ad5424f	Replace 10 more gt- classes with tw- (#29945 ) Likely the biggest change of the tailwind refactors. Only thing of note is that `tw-flex-1` resolves to `flex: 1 1 0%` while our `gt-f1` was `flex: 1 1 0`, I don't think it will make any difference. Commands I've ran: ```sh perl -p -i -e 's#gt-vm#tw-align-middle#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-fw#tw-flex-wrap#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-f1#tw-flex-1#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-fc#tw-flex-col#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-sb#tw-justify-between#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-je#tw-justify-end#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-jc#tw-justify-center#g' web_src/js/*/ templates/*/ models/*/ perl -p -i -e 's#gt-ac#tw-content-center#g' web_src/js/*/ templates/*/ models/*/ tests/*/ perl -p -i -e 's#gt-df#tw-flex#g' web_src/js/*/ templates/*/ models/*/ tests/*/ perl -p -i -e 's#gt-dib#tw-inline-block#g' web_src/js/*/ templates/*/ models/*/ tests/*/ Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	11 months ago
silverwind	34290a00c4	Migrate border and margin classes to Tailwind (#29828 ) Used all existing css vars, other migrations are 1:1. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	11 months ago
Yarden Shoham	3f1e4896b6	Remove the `time-since` class (#29826 ) It serves no purpose. --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io>	11 months ago
Yarden Shoham	cdc33b29a0	Add global setting how timestamps should be rendered (#28657 ) - Resolves https://github.com/go-gitea/gitea/issues/22493 - Related to https://github.com/go-gitea/gitea/issues/4520 Some admins prefer all timestamps to display the full date instead of relative time. They can do that now by setting ```ini [ui] PREFERRED_TIMESTAMP_TENSE = absolute ``` This setting is set to `mixed` by default, allowing dates to render as "5 hours ago". Here are some screenshots of the UI with this setting set to `absolute`: ![image](https://github.com/go-gitea/gitea/assets/20454870/f496457f-6afa-44be-a1e7-249ee5fe0706) ![image](https://github.com/go-gitea/gitea/assets/20454870/c03b14f5-063d-4e13-9780-76ab002d76a9) ![image](https://github.com/go-gitea/gitea/assets/20454870/f4b34e28-1546-4374-9199-c43348844edd) --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: delvh <dev.lh@web.de>	1 year ago
delvh	1f501dae9e	Fix JS NPE when viewing specific range of PR commits (#27912 ) This should be the easiest fix. While other solutions might be possible that exterminate the root cause, they will not be as trivial.	1 year ago
silverwind	ae8e8f055e	Use fetch helpers instead of fetch (#27026 ) WIP because: - [x] Some calls set a `content-type` but send no body, can likely remove the header - [x] Need to check whether `charset=utf-8` has any significance on the webauthn calls, I assume not as it is the default for json content. - [x] Maybe `no-restricted-globals` is better for eslint, but will require a lot of duplication in the yaml or moving eslint config to a `.js` extension. - [x] Maybe export `request` as `fetch`, shadowing the global.	1 year ago
silverwind	9a3de436f4	Reorder blocks in vue SFCs (#26874 ) The [recommended order](https://vuejs.org/guide/scaling-up/sfc.html) for SFC blocks is script -> template -> style, which we were violating because template and script were swapped. I do find script first also easier to read because the imports are on top, letting me immideatly see a component's dependencies. This is a pure cut-paste refactor with some removal of some empty lines. --------- Co-authored-by: Lauris BH <lauris@nix.lv>	1 year ago
wxiaoguang	4fdb09de58	Fix incorrect "tabindex" attributes (#26733 ) Fix #26731 Almost all "tabindex" in code are incorrect. 1. All "input/button" by default are focusable, so no need to use "tabindex=0" 2. All "div/span" by default are not focusable, so no need to use "tabindex=-1" 3. All "dropdown" are focusable by framework, so no need to use "tabindex" 4. Some tabindex values are incorrect (eg: `new_form.tmpl`), so remove them Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	56b6b2b88e	Fix tooltip of commit select button (#26472 ) Previously, the tooltip for this button was only shown after opening and closing it once because it was only set after the server response, now it shows before opening it.	1 year ago
sebastian-sauer	55532061c8	Add commits dropdown in PR files view and allow commit by commit review (#25528 ) This PR adds a new dropdown to select a commit or a commit range (shift-click like github) of a Pull Request. After selection of a commit only the changes of this commit will be shown. When selecting a range of commits the diff of this range is shown. This allows to review a PR commit by commit or by viewing only commit ranges. The "Show changes since your last review" mechanism github uses is implemented, too. When reviewing a single commit or a commit range the "Viewed" functionality is disabled. ## Screenshots ### The commit dropdown ![image](https://github.com/go-gitea/gitea/assets/51889757/0db3ae62-1272-436c-be64-4730c5d611e3) ### Selecting a commit range ![image](https://github.com/go-gitea/gitea/assets/51889757/ad81eedb-8437-42b0-8073-2d940c25fe8f) ### Show changes of a single commit only ![image](https://github.com/go-gitea/gitea/assets/51889757/6b1a113b-73ef-4ecc-adf6-bc2340bb8f97) ### Show changes of a commit range ![image](https://github.com/go-gitea/gitea/assets/51889757/6401b358-cd66-4c09-8baa-6cf6177f23a7) Fixes https://github.com/go-gitea/gitea/issues/20989 Fixes https://github.com/go-gitea/gitea/issues/19263 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2 years ago

24 Commits (594b8350b174e5832c1f91c55028ac76246bbef7)