4 Commits (6afbef5a8b5bdc628d1a7c5e714dd9f5e9b911c8)

Author	SHA1	Message	Date
zeripath	06f968d662	Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051) ... Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2 years ago
John Olheiser	c59afa752d	Allow mocking timeutil (#17354) ... Signed-off-by: jolheiser <john.olheiser@gmail.com>	3 years ago
Cirno the Strongest	bbe13b60cd	Fix timezone on issue deadline (#11697) ... * Fix timezone on issue deadline * FormatDate Co-authored-by: zeripath <art27@cantab.net>	5 years ago
Lunny Xiao	85202d4784	Display ui time with customize time location (#7792) ... * display ui time with customize time location * fix lint * rename UILocation to DefaultUILocation * move time related functions to modules/timeutil * fix tests * fix tests * fix build * fix swagger	5 years ago
Lunny Xiao	769ab1e424	fix gpg expired bug when time is zero (#3584)	7 years ago
Lunny Xiao	f94c1b3943	Improvements for supporting UI Location (#3146) ... * improvements for supporting UI Location * improved the comment	7 years ago
Lunny Xiao	f2e20c81b6	Refactor struct's time to remove unnecessary memory usage (#3142) ... * refactor struct's time to remove unnecessary memory usage * use AsTimePtr simple code * fix tests * fix time compare * fix template on gpg * use AddDuration instead of Add	7 years ago