gitea

Commit Graph

Author	SHA1	Message	Date
Jimmy Praet	3604b7d8ad	Load outdated comments when (un)resolving conversation on PR timeline (#29203 ) (#29221 ) Backport #29203 Relates to #28654, #29039 and #29050. The "show outdated comments" flag should only apply to the file diff view. On the PR timeline, outdated comments are always shown. So they should also be loaded when (un)resolving a conversation on the timeline page.	1 year ago
Giteabot	c9b2aaed0e	Improve user experience for outdated comments (#29050 ) (#29086 ) Backport #29050 by wxiaoguang Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago

Author

SHA1

Message

Date

Jimmy Praet

3604b7d8ad

Load outdated comments when (un)resolving conversation on PR timeline (#29203 ) (#29221 )

Backport #29203

Relates to #28654, #29039 and #29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown. So they should
also be loaded when (un)resolving a conversation on the timeline page.

1 year ago

Giteabot

c9b2aaed0e

Improve user experience for outdated comments (#29050 ) (#29086 )

Backport #29050 by wxiaoguang

Try to improve #28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

1 year ago

2 Commits (8c31456a879797e7247d2cbf65b53fd16939c91d)