gitea

Commit Graph

Author	SHA1	Message	Date
silverwind	1a0a205466	Clean up pyproject.toml and package.json, fix poetry options (#25327 ) - Reduce `pyproject.toml` and `package.json` to the minimal required format, removing unneeded properties. `build-system` is not needed as per [this](https://github.com/python-poetry/poetry/issues/8110#issuecomment-1595846841). - Fix `poetry.toml` options they were wrong previously. - Add dependencies of poetry files to templates `files-changed`. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
silverwind	e24f651c86	Add template linting via djlint (#25212 ) So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well).	2 years ago

Author

SHA1

Message

Date

silverwind

1a0a205466

Clean up pyproject.toml and package.json, fix poetry options (#25327 )

- Reduce `pyproject.toml` and `package.json` to the minimal required
format, removing unneeded properties. `build-system` is not needed as
per
[this](https://github.com/python-poetry/poetry/issues/8110#issuecomment-1595846841).
- Fix `poetry.toml` options they were wrong previously.
- Add dependencies of poetry files to templates `files-changed`.

---------

Co-authored-by: Giteabot <teabot@gitea.io>

2 years ago

silverwind

e24f651c86

Add template linting via djlint (#25212 )

So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).

2 years ago

2 Commits (996037fb6a61b1a7f9a0a837fd87bbeab9cad154)