5 Commits (9d9ad1b59fe062e4e87248a7333dc6414260815c)

Author	SHA1	Message	Date
KN4CK3R	1fbdf96c34	Fix CSV render error (#17406) (#17431) ... Backport #17406. Closes #17378 Both errors from #17378 were caused by #15175. Problem 1 (error with added file): `ToUTF8WithFallbackReader` creates a `MultiReader` from a `byte[2048]` and the remaining reader. `CreateReaderAndGuessDelimiter` tries to read 10000 bytes from this reader but only gets 2048 because that's the first reader in the `MultiReader`. Then the `if size < 1e4` thinks the input is at EOF and just returns that. Problem 2 (error with changed file): The blob reader gets defer closed. That was fine because the old version reads the whole file into memory. Now with the streaming version the close needs to defer after the method. Co-authored-by: zeripath <art27@cantab.net>	3 years ago
KN4CK3R	5159055278	Read expected buffer size (#17409) (#17430) ... Backport of #17409 * Read expected buffer size. * Changed name.	3 years ago
Richard Mahn	befb6bea22	Prevent NPE in CSV diff rendering when column removed (#17018) (#17377) ... Backport of #17018 Fixes #16837 if a column is deleted.	3 years ago
Lunny Xiao	9d99f6ab19	Refactor renders (#15175) ... * Refactor renders * Some performance optimization * Fix comment * Transform reader * Fix csv test * Fix test * Fix tests * Improve optimaziation * Fix test * Fix test * Detect file encoding with reader * Improve optimaziation * reduce memory usage * improve code * fix build * Fix test * Fix for go1.15 * Fix render * Fix comment * Fix lint * Fix test * Don't use NormalEOF when unnecessary * revert change on util.go * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> * rename function * Take NormalEOF back Co-authored-by: zeripath <art27@cantab.net>	4 years ago
KN4CK3R	0c6137617f	Add Tabular Diff for CSV files (#14661) ... Implements request #14320 The rendering of CSV files does match the diff style. * Moved CSV logic into base package. * Added method to create a tabular diff. * Added CSV compare context. * Added CSV diff template. * Use new table style in CSV markup. * Added file size limit for CSV rendering. * Display CSV parser errors in diff. * Lazy read single file. * Lazy read rows for full diff. * Added unit tests for various CSV changes.	4 years ago