gitea

Commit Graph

Author	SHA1	Message	Date
CaiCandong	815d267c80	Fix verifyCommits error when push a new branch (#26664 ) > ### Description > If a new branch is pushed, and the repository has a rule that would require signed commits for the new branch, the commit is rejected with a 500 error regardless of whether it's signed. > > When pushing a new branch, the "old" commit is the empty ID (0000000000000000000000000000000000000000). verifyCommits has no provision for this and passes an invalid commit range to git rev-list. Prior to 1.19 this wasn't an issue because only pre-existing individual branches could be protected. > > I was able to reproduce with [try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test), which is set up with a blanket rule to require commits on all branches. Fix #25565 Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting an valid solution! --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	1 year ago
Lauris BH	8c3a2e817b	Add missing fixture to clean gpg_key table (#2494 ) * Add missing fixture to clean gpg_key table * Fix possible too fast request execution in timetracker start/stop test	7 years ago
Ethan Koenig	251fb935ff	Don't recreate database in integration tests (#1697 )	8 years ago

Author

SHA1

Message

Date

CaiCandong

815d267c80

Fix verifyCommits error when push a new branch (#26664 )

> ### Description
> If a new branch is pushed, and the repository has a rule that would
require signed commits for the new branch, the commit is rejected with a
500 error regardless of whether it's signed.
> 
> When pushing a new branch, the "old" commit is the empty ID
(0000000000000000000000000000000000000000). verifyCommits has no
provision for this and passes an invalid commit range to git rev-list.
Prior to 1.19 this wasn't an issue because only pre-existing individual
branches could be protected.
> 
> I was able to reproduce with
[try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test),
which is set up with a blanket rule to require commits on all branches.


Fix #25565
Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting
an valid solution!

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

1 year ago

Lauris BH

8c3a2e817b

Add missing fixture to clean gpg_key table (#2494 )

* Add missing fixture to clean gpg_key table

* Fix possible too fast request execution in timetracker start/stop test

7 years ago

Ethan Koenig

251fb935ff

Don't recreate database in integration tests (#1697 )

8 years ago

2 Commits (a1e0d8bd8bf3ad747673496c4059ec8ed42c9128)