775 Commits (a1ee172fb0dea64d5dcb37aaa717da1d5b709d31)

Author	SHA1	Message	Date
Giteabot	a1ee172fb0	Improve dropdown's behavior when there is a search input in menu (#27526) (#27534) ... Backport #27526 by @wxiaoguang Follow #27225 The change in #27225 is not ideal, this should be the complete fix: support the layout which Fomantic doesn't support. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Giteabot	fb5ae2ab94	Restore warning commit status (#27504) (#27529) ... Backport #27504 by @silverwind Partial revert of https://github.com/go-gitea/gitea/pull/25839. This commit status is used by a number of external integrations, so I think we should not remove it (See https://github.com/go-gitea/gitea/pull/25839#issuecomment-1729002077). This is a rare case where an existing migration needed to be alterted to avoid data loss. Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: delvh <dev.lh@web.de>	1 year ago
silverwind	8419897fba	Update JS and PY dependencies (#27501) (#27518) ... Backport https://github.com/go-gitea/gitea/pull/27501 to 1.21 - Update all JS and PY dependencies - Enable eslint `prefer-object-has-own` and autofix issue - Fix styling on citation buttons - Tested citation, mermaid, monaco, swagger, katex Citation button issue was that these buttons were not filled: <img width="136" alt="Screenshot 2023-10-07 at 14 05 08" src="https://github.com/go-gitea/gitea/assets/115237/435f0c91-28ac-46b3-bae4-dad768b29c05"> Co-authored-by: techknowlogick <techknowlogick@gitea.com> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	0fb7294027	Fix mermaid flowchart margin issue (#27503) (#27516) ... Backport https://github.com/go-gitea/gitea/pull/27503 to 1.21 Fixes: https://github.com/go-gitea/gitea/issues/27435 Related: https://github.com/mermaid-js/mermaid/issues/4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">	1 year ago
Giteabot	aaf35ee49c	Refactor system setting (#27000) (#27452) ... Backport #27000 by @wxiaoguang This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system.  Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Giteabot	28d970e4a6	Hide archived labels when filtering by labels on the issue list (#27115) (#27381) ... Backport #27115 by @puni9869 Followup https://github.com/go-gitea/gitea/pull/26820 ## Archived labels UI for issue filter and issue filter actions for issues/pull request pages. Changed: * Enhanced the Issue filter and Issue filter actions UI page to seamlessly incorporate a list of archived labels. * Pagination functionality is same as before. If archived label checkbox is checked then we are adding a query string`archived=true` in the url to save the state of page. * Issue filter actions menu is separated into different template. * Adding the archived flag in issue url labels. * Pull Request page is also work the same. Outsourced: * Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request. Screenshots ### Issue page <img width="1360" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432"> ### Issue page with label filter on archived label checkbox when not checked --> No archived label is there in list <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9"> ### Issue page with label filter on archived label checkbox when checked --> Show archived label in the list. <img width="710" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf"> ### Issue page with label filter on issue action menu on archived label checkbox when checked --> Show archived label in the list. <img width="409" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178"> ### Applied the archived=true in Issue labels when archived checkbox is checked. <img width="984" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0"> --- Part of https://github.com/go-gitea/gitea/issues/25237 Signed-off-by: puni9869 <punitinani1@hotmail.com> Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com> Co-authored-by: delvh <dev.lh@web.de>	1 year ago
Giteabot	e719bf8ead	Fix review UI (#27322) (#27331) ... Backport #27322 by @wxiaoguang Close #26730 1. The `diff-detail-box` was abused, it shouldn't be used for "DiffFileList/DiffFileTree". 2. Fix the sticky position for various screens.    Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Giteabot	71d1bfea7f	Improve issue history dialog and make poster can delete their own history (#27323) (#27327) ... Backport #27323 by @wxiaoguang Fix #27313 (see the comment) And some UI improvements: ### Before   ### After    Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Giteabot	d74fba8175	Use vitest globals (#27102) (#27311) ... Backport #27102 by @silverwind Enable [globals](https://vitest.dev/config/#globals) in vitest, reducing the noise in test files. Co-authored-by: silverwind <me@silverwind.io>	1 year ago
Giteabot	fee8522052	Fix some animation bugs (#27287) (#27294) ... Backport #27287 Fix #27286 Replace #27279 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Giteabot	34c440996d	Add missed return to actions view fetch (#27289) (#27293) ... Backport #27289 by @silverwind Should fix: https://github.com/go-gitea/gitea/issues/27213 @denyskon can you test this? I can not reproduce this error locally. Co-authored-by: silverwind <me@silverwind.io>	1 year ago
Giteabot	a1029cb2ca	Fix EOL handling in web editor (#27141) (#27234) ... Backport #27141 by @silverwind Fixes https://github.com/go-gitea/gitea/issues/27136. This does the following for Monaco's EOL setting: 1. Use editorconfig setting if present 2. Use the file's dominant line ending as detected by monaco, which uses LF for empty file Co-authored-by: silverwind <me@silverwind.io>	1 year ago
Giteabot	f4f6885c1f	Fix Fomantic UI dropdown icon bug when there is a search input in menu (#27225) (#27228) ... Backport #27225 by @wxiaoguang Fix #27224 And add the case to the devtest page. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
silverwind	ae8e8f055e	Use fetch helpers instead of fetch (#27026) ... WIP because: - [x] Some calls set a `content-type` but send no body, can likely remove the header - [x] Need to check whether `charset=utf-8` has any significance on the webauthn calls, I assume not as it is the default for json content. - [x] Maybe `no-restricted-globals` is better for eslint, but will require a lot of duplication in the yaml or moving eslint config to a `.js` extension. - [x] Maybe export `request` as `fetch`, shadowing the global.	1 year ago
silverwind	8099238618	Change green buttons to primary color (#27099) ... I think it's better if the primary actions have primary color instead of green which fits better into the overall single-color UI design. This PR currently replaces every green button with primary: <img width="141" alt="Screenshot 2023-09-16 at 14 07 59" src="https://github.com/go-gitea/gitea/assets/115237/843c1e50-4fb2-4ec6-84ba-0efb9472dcbe"> <img width="161" alt="Screenshot 2023-09-16 at 14 07 51" src="https://github.com/go-gitea/gitea/assets/115237/9442195a-a3b2-4a42-b262-8377d6f5c0d1"> Modal actions now use uncolored/primary instead of previous green/red colors. I also removed the box-shadow on all basic buttons: <img width="259" alt="Screenshot 2023-09-16 at 14 16 39" src="https://github.com/go-gitea/gitea/assets/115237/5beea529-127a-44b0-8d4c-afa7b034a490"> <img width="261" alt="Screenshot 2023-09-16 at 14 17 42" src="https://github.com/go-gitea/gitea/assets/115237/4757f7b2-4d46-49bc-a797-38bb28437b88"> The change currently includes the "Merge PR" button, for which we might want to make an exception to match the icon color there: <img width="442" alt="Screenshot 2023-09-16 at 14 33 53" src="https://github.com/go-gitea/gitea/assets/115237/993ac1a5-c94d-4895-b76c-0d872181a70b">	1 year ago
yp05327	076eca8158	Fix incorrect default branch label while switching between branches (#27053) ... Fix #27008	1 year ago
Nanguan Lin	da50be7360	Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) ... Currently 'userxx' and 'orgxx' are both used as username in test files when the user type is org, which is confusing. This PR replaces all 'userxx' with 'orgxx' when the user type is org(`user.type==1`). Some non-trivial changes 1. Rename `user3` dir to `org3` in `tests/git-repositories-meta` 2. Change `end` in `issue reference` because 'org3' is one char shorter than 'user3'  3. Change the search result number of `user/repo2` because `user3/repo21` can't be searched now  4. Change the first org name getting from API because the result is ordered by alphabet asc and now `org 17` is before `org25`   Other modifications are just find all and replace all. Unit tests with SQLite are all passed. --------- Co-authored-by: caicandong <1290147055@qq.com>	1 year ago
wxiaoguang	739e47cd80	Improve repo/user/org search (#27030) ... * Fix a regression from #26809 (the `data-org` is missing) * Remove unnecessary style Screenshots:   	1 year ago
silverwind	6d96f0b0d1	Add fetch wrappers, ignore network errors in actions view (#26985) ... 1. Introduce lightweight `fetch` wrapper functions that automatically sets csfr token, content-type and use it in `RepoActionView.vue`. 2. Fix a specific issue on `RepoActionView.vue` where a fetch network error is shortly visible during page reload sometimes. It can be reproduced by F5-in in quick succession on the actions view page and was also producing a red error box on the page. Once approved, we can replace all current `fetch` uses in UI with this in another PR. --------- Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
wxiaoguang	dd6e8ab57b	Improve "language stats" UI (#26968) ... Before: * The layout is quite complex * The UI flickers when switch the stats (https://try.gitea.io/) After: * Simplify the code * The UI doesn't flicker	1 year ago
wxiaoguang	80d14b8f4a	Check newly added node type before "attachDirAuto" (#26972)	1 year ago
wxiaoguang	1221221595	Add "dir=auto" for input/textarea elements by default (#26735) ... Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	97aa749578	Vendor `jquery.are-you-sure` with strict mode fixes (#26901) ... Extract from https://github.com/go-gitea/gitea/pull/25940 and because https://github.com/go-gitea/gitea/pull/26743 does seem to need more work. This will be required if we are to run our JS in [strict mode](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode). Previously, the two variables `$fields` and `$dirtyForms` polluted `window`: <img width="1145" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/e0270a0e-b881-4ed7-9cc4-e9ab25c0a2bc">	1 year ago
silverwind	9a3de436f4	Reorder blocks in vue SFCs (#26874) ... The [recommended order](https://vuejs.org/guide/scaling-up/sfc.html) for SFC blocks is script -> template -> style, which we were violating because template and script were swapped. I do find script first also easier to read because the imports are on top, letting me immideatly see a component's dependencies. This is a pure cut-paste refactor with some removal of some empty lines. --------- Co-authored-by: Lauris BH <lauris@nix.lv>	1 year ago
wxiaoguang	d5703d4a1b	Remove "TODO" tasks from CSS file (#26835) ... 1. Use `gt-invisible` instead of `invisible`. 2. Use `gt-word-break` instead of `dont-break-out` (there is a slight different "hyphens", but I think it won't affect too much since it is only used for the "full name"). 3. Remove `.small.button:has(svg)` , now our buttons could layout SVG correctly, and actually I didn't see this CSS class is used in code.	1 year ago
silverwind	c35b16a9a4	Remove joinPaths function (#26833) ... Extract from https://github.com/go-gitea/gitea/pull/25940. `assetUrlPrefix` is guaranteed to not contain trailing slashes, making this function unneeded.	1 year ago
wxiaoguang	19a1e1b20e	Remove polluted `.ui.right` (#26825) ... Each change is tested manually line by line. There are too many changes so I can't share dozens of screenshots. In short: 1. `ui right` could be still used in `ui top attached header`, because there is a special case. 2. A lot of `ui right` are just no-op, so they can be removed safely. 3. Some of the `ui right` should be replaced by `gt-float-right` (to avoid breaking, leave them to the future). 4. A few of the `ui right` could be rewritten by flex.	1 year ago
wxiaoguang	1bb9b1c4d9	Remove polluted ".ui.left" style (#26809)	1 year ago
silverwind	508de3a58d	Fix Uint8Array comparisons and update vitest (#26805) ... Compare those `Uint8Array` via conversion to Array which are properly comparable, so that we don't have to worry about whether `TextEncoder` and `UInt8Array` from the environment are compatible or not. --------- Co-authored-by: delvh <dev.lh@web.de>	1 year ago
yp05327	008f5d8cf1	Add default label in branch select list (#26697)	1 year ago
wxiaoguang	67daa7bcb0	Remove some transition related code (#26755) ... Remove transition related code because the transition module has been removed by #26469	1 year ago
wxiaoguang	4fdb09de58	Fix incorrect "tabindex" attributes (#26733) ... Fix #26731 Almost all "tabindex" in code are incorrect. 1. All "input/button" by default are focusable, so no need to use "tabindex=0" 2. All "div/span" by default are not focusable, so no need to use "tabindex=-1" 3. All "dropdown" are focusable by framework, so no need to use "tabindex" 4. Some tabindex values are incorrect (eg: `new_form.tmpl`), so remove them Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
wxiaoguang	576644d815	Simplify helper CSS classes and avoid abuse (#26728) ... Removed CSS helper classes (some of them are not useful while some of them are abused often) * `gt-db`: in most cases it could be replaced by `gt-df` and the flex layout should be encouraged. Other cases: either it does need the `gt-df` (eg: by using `div` directly) or it is an abuse (eg: the warning message in a form) * `gt-di`: it doesn't seem useful, or it could be replaced by `gt-dib` in most cases. * `gt-dif`: not useful, it could be replaced by `flex-text-inline` or `gt-df` * `gt-js`: never used * All `<i class="icon gt-df gt-ac gt-jc">` could be written as `<i class="icon">` ## Some UI samples ### Admin Notice  ### Admin Stacktrace  ### Org Home  ### Org Team Repo  ### Release List  ### User Setting Application Token Scope  Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	8b5c081d76	Remove fomantic loader module (#26670) ... Replace Fomantic `loader` CSS module with our existing `is-loading` spinner. Only three places in the UI used this module, which are pictured here: imagediff: <img width="1237" alt="Screenshot 2023-08-22 at 22 18 01" src="https://github.com/go-gitea/gitea/assets/115237/b0d82531-f05e-43c6-9e5b-1bfc268c056d"> webauthn: <img width="894" alt="Screenshot 2023-08-22 at 22 05 05" src="https://github.com/go-gitea/gitea/assets/115237/7b583425-d944-474a-a57a-22a65bbd8b29"> heatmap (I removed the previous loading text, it was unreadable because it was tiny and on fast machines only visible for a fraction of a second): <img width="764" alt="Screenshot 2023-08-22 at 22 18 44" src="https://github.com/go-gitea/gitea/assets/115237/1c7472d6-3e17-4224-a992-d8c0b380cc73"> Also, heatmap container does not resize any more after loading now and previous duplicate id `user-heatmap` is gone. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
silverwind	21b8ec29aa	Add `eslint-plugin-vue-scoped-css` (#26720) ... Adds [eslint-plugin-vue-scoped-css](https://github.com/future-architect/eslint-plugin-vue-scoped-css) and fixes discovered issues which are: - 1 unused selector - 3 selectors with `.full.height` parent in a `<style scoped>` block so the rule could not find the parent. Move these into the unscoped block instead. They worked before and after.	1 year ago
silverwind	636b6eaf2a	Focus editor on "Write" tab click (#26714) ... Focus the editor when clicking the "Write" tab. Works for both Textarea and EasyMDE. Does for some reason not work without the `requestAnimationFrame`.	1 year ago
wxiaoguang	8ac83043f5	Use "small-loading-icon" insead of "btn-octicon is-loading" (#26710) ... The "btn-octicon is-loading" was introduced by #21842 , it is only used by the "Copy Content" button, but the "btn-octicon" selector would affect too many uncertain elements. Now there is a general "small-loading-icon" class, so the "btn-octicon is-loading" could be removed.	1 year ago
wxiaoguang	09faf43ef8	Improve Image Diff UI (#26696) ... 1. Use `is-loading` instead of `ui loader` 2. Introduce class name `image-diff-tabs`, instead of searching `gt-hidden`, which is fragile 3. Align the UI elements, see the screenshots.	1 year ago
wxiaoguang	f67f57a4c2	Handle "comment form combo editor init" more gracefully (#26688) ... Now Gitea exposes unhandled promise rejection messages as error message on the UI. The "comment form" was quite unclear before, so it should be handled more gracefully to avoid such error.	1 year ago
wxiaoguang	af33a1187b	Fix doubled box-shadow in branch dropdown menu (#26678)	1 year ago
wxiaoguang	a428591f6b	Refactor toast module (#26677) ... 1. Do not use "async" 2. Call `hideToast` instead of `removeElement` for manual closing	1 year ago
yp05327	c052f76266	Fix organization list in dashboard (#26650) ... Fix ui problem comes from #26326 Before:  After: 	1 year ago
yp05327	a4a567f29f	Check disabled workflow when rerun jobs (#26535) ... In GitHub, we can not rerun jobs if the workflow is disabled. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
wxiaoguang	42cbe6005a	Improve the branch selector tab UI (#26631)	1 year ago
yp05327	f6e7798405	Add link to job details and tooltip to commit status in repo list in dashboard (#26326) ... Tooltip:  Link to the target job: 	1 year ago
wxiaoguang	ead52dd96c	Use "input" event instead of "keyup" event for migration form (#26602) ... Otherwise, "pasted" content won't update the UI.	1 year ago
silverwind	5feef6d5c0	Update JS dependencies (#26586) ... - Update all JS dependencies - Adapt `ansi_up` import for ESM - Tested Mermaid and Ansi rendering	1 year ago
wxiaoguang	48c4a7e75c	Rewrite the DiffFileTreeItem and fix misalignment (#26565) ... Fix some layout / user-interaction problems and close #25650 , the code has been simplified (+46 −108) <details>  </details> --------- Co-authored-by: delvh <dev.lh@web.de>	1 year ago
silverwind	30e5278d1b	Allow text selection in actions step header (#26588)	1 year ago
wxiaoguang	e5b3f53d36	Add minimum polyfill to support "relative-time-element" in PaleMoon (#26575) ... Close #26525	1 year ago