gitea

Commit Graph

Author	SHA1	Message	Date
wxiaoguang	d32af84a10	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950 ) Close #22847 This PR: * introduce Gitea's own `showElem` and related functions * remove jQuery show/hide * remove .hide class * remove inline style=display:none From now on: do not use: * "[hidden]" attribute: it's too weak, can not be applied to an element with "display: flex" * ".hidden" class: it has been polluted by Fomantic UI in many cases * inline style="display: none": it's difficult to tweak * jQuery's show/hide/toggle: it can not show/hide elements with "display: xxx !important" only use: * this ".gt-hidden" class * showElem/hideElem/toggleElem functions in "utils/dom.js" cc: @silverwind , this is the all-in-one PR	2 years ago
silverwind	19b017f398	Use explicit jQuery import, remove unused eslint globals (#18435 ) - Don't rely on globals (window.$) for jQuery import - Remove eslint globals no longer in use	3 years ago
wxiaoguang	1a7473ff45	Split `index.js` to separate files (#17315 ) * split `index.js` to separate files * tune clipboard * fix promise * fix document * remove intermediate empty file * fix async event listener * use `export function` instead of `export {}`, add more comments Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	3 years ago

Author

SHA1

Message

Date

wxiaoguang

d32af84a10

Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950 )

Close #22847

This PR:

* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none 

From now on:

do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"

only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"

cc: @silverwind , this is the all-in-one PR

2 years ago

silverwind

19b017f398

Use explicit jQuery import, remove unused eslint globals (#18435 )

- Don't rely on globals (window.$) for jQuery import
- Remove eslint globals no longer in use

3 years ago

wxiaoguang

1a7473ff45

Split `index.js` to separate files (#17315 )

* split `index.js` to separate files

* tune clipboard

* fix promise

* fix document

* remove intermediate empty file

* fix async event listener

* use `export function` instead of `export {}`, add more comments

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>

3 years ago

3 Commits (a2a9b0f977461e3132bb78a276f47e3c0b42a8c4)