gitea

Commit Graph

Author	SHA1	Message	Date
Giteabot	2399b4d483	Avoid unnecessary 500 panic when a commit doesn't exist (#28719 ) (#28721 ) Backport #28719 by wxiaoguang In #26851, it assumed that `Commit` always exists when `PageIsDiff==true`. But for a 404 page, the `Commit` doesn't exist, so the following code would cause panic because nil value can't be passed as string parameter to `IsMultilineCommitMessage(string)` (or the StringUtils.Cut in later PRs) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
wxiaoguang	c802c46a9b	Refactor `og:description` to limit the max length (#26876 ) 1. The `og:description` should be "a one to two sentence description of your object" * It shouldn't output all the user inputted content -- it would be pretty huge. * Maybe it only needs at most 300 bytes. 2. Do not render commit message as HTML	1 year ago
Linus Groh	5743d7cb5b	Improve opengraph previews (#26851 ) Add more useful Open Graph metadata for commit and file URLs: - Set `og:title` to the page title, which is a concise summary in both cases (`<commit message> · <commit hash>` and `<filename> at <branch>`, respectively) - Set `og:description` to the commit message body, if available - Set `og:url` to the relevant URLs instead of the repo URL Also move the relevant meta tags into a separate template as they now take up the majority of the base head template.	2 years ago

Author

SHA1

Message

Date

Giteabot

2399b4d483

Avoid unnecessary 500 panic when a commit doesn't exist (#28719 ) (#28721 )

Backport #28719 by wxiaoguang

In #26851, it assumed that `Commit` always exists when
`PageIsDiff==true`.

But for a 404 page, the `Commit` doesn't exist, so the following code
would cause panic because nil value can't be passed as string parameter
to `IsMultilineCommitMessage(string)` (or the StringUtils.Cut in later
PRs)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

1 year ago

wxiaoguang

c802c46a9b

Refactor `og:description` to limit the max length (#26876 )

1. The `og:description` should be "a one to two sentence description of
your object"
* It shouldn't output all the user inputted content -- it would be
pretty huge.
    * Maybe it only needs at most 300 bytes.
2. Do not render commit message as HTML

1 year ago

Linus Groh

5743d7cb5b

Improve opengraph previews (#26851 )

Add more useful Open Graph metadata for commit and file URLs:

- Set `og:title` to the page title, which is a concise summary in both
cases (`<commit message> · <commit hash>` and `<filename> at <branch>`,
respectively)
- Set `og:description` to the commit message body, if available
- Set `og:url` to the relevant URLs instead of the repo URL

Also move the relevant meta tags into a separate template as they now
take up the majority of the base head template.

2 years ago

3 Commits (b9dd5dd471858c52cd7b202995ab64f6fe28a519)