gitea

Commit Graph

Author	SHA1	Message	Date
Nanguan Lin	dc04044716	Replace assert.Fail with assert.FailNow (#27578 ) assert.Fail() will continue to execute the code while assert.FailNow() not. I thought those uses of assert.Fail() should exit immediately. PS: perhaps it's a good idea to use [require](https://pkg.go.dev/github.com/stretchr/testify/require) somewhere because the assert package's default behavior does not exit when an error occurs, which makes it difficult to find the root error reason.	1 year ago
wxiaoguang	f01bed2443	Avoid double-unescaping of form value (#26853 ) 1. The old `prepareQueryArg` did double-unescaping of form value. 2. By the way, remove the unnecessary `ctx.Flash = ...` in `MockContext`. Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859 ) Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	1 year ago

Author

SHA1

Message

Date

Nanguan Lin

dc04044716

Replace assert.Fail with assert.FailNow (#27578 )

assert.Fail() will continue to execute the code while assert.FailNow()
not. I thought those uses of assert.Fail() should exit immediately.
PS: perhaps it's a good idea to use
[require](https://pkg.go.dev/github.com/stretchr/testify/require)
somewhere because the assert package's default behavior does not exit
when an error occurs, which makes it difficult to find the root error
reason.

1 year ago

wxiaoguang

f01bed2443

Avoid double-unescaping of form value (#26853 )

1. The old `prepareQueryArg` did double-unescaping of form value.
2. By the way, remove the unnecessary `ctx.Flash = ...` in
`MockContext`.

Co-authored-by: Giteabot <teabot@gitea.io>

1 year ago

wxiaoguang

e8aae43f56

Move web/api context related testing function into a separate package (#26859 )

Just like `models/unittest`, the testing helper functions should be in a
separate package: `contexttest`

And complete the TODO:

> // TODO: move this function to other packages, because it depends on
"models" package

1 year ago

3 Commits (d68a613ba8fd860863a3465b5b5945b191b87b25)