gitea

Commit Graph

Author	SHA1	Message	Date
zeripath	6e7d28cf3a	Prevent double decoding of % in url params (#17997 ) There was an unfortunate regression in #14293 which has led to the double decoding of url parameter elements if they contain a '%'. This is due to an issue with the way chi decodes its RoutePath. In detail the problem lies in mux.go where the routeHTTP path uses the URL.RawPath or even the URL.Path instead of the escaped path to do routing. This PR simply forcibly sets the routePath to that of the EscapedPath. Fix #17938 Signed-off-by: Andrew Thornton <art27@cantab.net>	3 years ago

Author

SHA1

Message

Date

zeripath

6e7d28cf3a

Prevent double decoding of % in url params (#17997 )

There was an unfortunate regression in #14293 which has led to the double decoding
of url parameter elements if they contain a '%'. This is due to an issue
with the way chi decodes its RoutePath. In detail the problem lies in
mux.go where the routeHTTP path uses the URL.RawPath or even the
URL.Path instead of the escaped path to do routing.

This PR simply forcibly sets the routePath to that of the EscapedPath.

Fix #17938

Signed-off-by: Andrew Thornton <art27@cantab.net>

3 years ago

1 Commits (dc0253b0637bbf367ad330612900e780c6b2b0e6)