a3f403f438
Add option to disable ambiguous unicode characters detection ( #28454 ) ( #28499 )
...
Backport #28454 (the only conflict is caused by some comments)
* Close #24483
* Close #28123
* Close #23682
* Close #23149
11 months ago
f144521aea
Deprecate query string auth tokens ( #28390 ) ( #28430 )
...
Backport #28390 by @jackHay22
## Changes
- Add deprecation warning to `Token` and `AccessToken` authentication
methods in swagger.
- Add deprecation warning header to API response. Example:
```
HTTP/1.1 200 OK
...
Warning: token and access_token API authentication is deprecated
...
```
- Add setting `DISABLE_QUERY_AUTH_TOKEN` to reject query string auth
tokens entirely. Default is `false`
## Next steps
- `DISABLE_QUERY_AUTH_TOKEN` should be true in a subsequent release and
the methods should be removed in swagger
- `DISABLE_QUERY_AUTH_TOKEN` should be removed and the implementation of
the auth methods in question should be removed
## Open questions
- Should there be further changes to the swagger documentation?
Deprecation is not yet supported for security definitions (coming in
[OpenAPI Spec version
3.2.0](https://github.com/OAI/OpenAPI-Specification/issues/2506 ))
- Should the API router logger sanitize urls that use `token` or
`access_token`? (This is obviously an insufficient solution on its own)
Co-authored-by: Jack Hay <jack@allspice.io>
Co-authored-by: delvh <dev.lh@web.de>
12 months ago
b56a9f6ded
Fix margin in server signed signature verification view ( #28379 ) ( #28381 )
...
Backport #28379 by @lafriks
Before:
After:
Co-authored-by: Lauris BH <lauris@nix.lv>
12 months ago
b7e3adc66c
Fix the runs will not be displayed bug when the main branch have no workflows but other branches have ( #28359 ) ( #28365 )
...
Backport #28359 by @lunny
The left menu will only display the default branch's workflows but the
right side will display the runs triggered by all branches' workflows.
So we cannot hide right side if default branch has no workflows.
Fix #28332
Replace #28333
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
12 months ago
08445d5d86
Refactor template empty checks ( #28351 ) ( #28354 )
...
Backport #28351 by @KN4CK3R
Fix #28347
As there is no info how to reproduce it, I can't test it.
Fix may be `section_split.tmpl @ 126/130`.
Other changes are "empty check" refactorings.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
12 months ago
bf537adf8a
Keep profile tab when clicking on Language ( #28320 ) ( #28331 )
...
Backport #28320 by @JakobDev
Fixes https://codeberg.org/Codeberg/Community/issues/1355
Co-authored-by: JakobDev <jakobdev@gmx.de>
12 months ago
6d22ca15ab
Use full width for project boards ( #28225 ) ( #28245 )
...
Backport #28225 by @denyskon
Inspired by #28182
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
1 year ago
28b8e0b43e
Use full width for PR comparison ( #28182 ) ( #28186 )
...
Backport #28182 by @lng2020
Follow-up #22844
close #28142
Before
After
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
1 year ago
f9763f1366
Fix missing buttons ( #28179 ) ( #28181 )
...
Backport #28179 by @lng2020
fix #28173
regression #25948
That PR is supposed to only change the style but somehow delete a code
snippet. See the
diff(https://github.com/go-gitea/gitea/pull/25948/files#diff-7c36d66fe058f4ff9f2beaac73cf710dca45b350d0dd98daf806828a4745fe62L125-L129 )
for details.
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
a2314ca9c5
Revert "Fix EOL handling in web editor" ( #28101 ) ( #28172 )
...
Backport #28101 by @lng2020
Reverts go-gitea/gitea#27141
close #28097
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
1 year ago
994ba35f11
Fix swagger title ( #28164 ) ( #28167 )
...
Backport #28164 by @yp05327
Don't know why there's a `.` behind. 🤔
Co-authored-by: yp05327 <576951401@qq.com>
1 year ago
9bfee5014b
Add guide page to actions when there's no workflows ( #28145 ) ( #28153 )
...
Backport #28145 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com>
1 year ago
7128929a0d
Do not display search box when there's no packages yet ( #28146 ) ( #28159 )
...
Backport #28146 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com>
1 year ago
c997e90738
Fix empty action run title ( #28113 ) ( #28148 )
...
Backport #28113 by @lunny
Fix #27901
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 year ago
d72e20627d
Add word break to the repo list in admin settings page ( #28034 ) ( #28035 )
...
Backport #28034 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com>
1 year ago
46ac04ce9d
Add word-break to repo description in home page ( #27924 ) ( #27957 )
...
Backport #27924 by @yp05327
In #25315 , @denyskon fixed UI on mobile view.
But for the repo description, on desktop view there's no word-break.
So maybe we can just add `gt-word-break` to fix it on both mobile view
and desktop view.
Before:
desktop view:
mobile view:
After:
desktop view:
mobile view(almost same?)
Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
7aafe5e0b4
Fix rendering assignee changed comments without assignee ( #27927 ) ( #27952 )
...
Backport #27927 by @invliD
When an assignee changed event comment is rendered, most of it is
guarded behind the assignee ID not being 0. However, if it is 0, that
results in quite broken rendering for that comment and the next one.
This can happen, for example, when repository data imported from outside
of Gitea is incomplete.
This PR makes sure comments with an assignee ID of 0 are not rendered at
all.
---
Screenshot before:
<img width="272" alt="Bildschirmfoto 2023-11-05 um 20 12 18"
src="https://github.com/go-gitea/gitea/assets/42910/7d629d76-fee4-4fe5-9e3a-bf524050cead ">
The comments in this screenshot are:
1. A regular text comment
2. A user being unassigned
3. A user being assigned
4. The title of the PR being changed
Comments 2 and 3 are rendered without any text, which indents the next
comment and does not leave enough vertical space.
Co-authored-by: Sebastian Brückner <code@nik.dev>
1 year ago
9e15955c68
Add word break to release title ( #27942 ) ( #27947 )
...
Backport #27942 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com>
1 year ago
2f56ab7999
Show correct commit sha when viewing single commit diff ( #27916 ) ( #27921 )
...
Backport #27916 by @sebastian-sauer
Show the correct sha when viewing a single commit.
Co-authored-by: sebastian-sauer <sauer.sebastian@gmail.com>
1 year ago
cf7374c079
Remove set tabindex on view issue ( #27892 ) ( #27896 )
...
Backport #27892 by @earl-warren
- Remove the set tabindex and instead let the browser figure out the
correct tab order.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1626
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
6ac2ade97d
Clean up template locale usage ( #27856 ) ( #27857 )
...
Backport #27856
The only conflict is `ThemeName` in `500.tmpl`, it has been resolved
manually by keeping using old
`{{.SignedUser.Theme}}{{else}}{{DefaultTheme}}`
1 year ago
18a782f73d
Fix package webhook ( #27839 ) ( #27855 )
...
Backport #27839 by @lunny
Fix #23742
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
1 year ago
ac22116211
Always use whole user name as link ( #27815 ) ( #27838 )
...
Backport #27815 by @denyskon
Starting from #25790 this shared template only linked the username of
the user if both display name and username were shown. I experienced
myself always trying to click on the display name - I think it is
annoying for others too.
After:
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
1 year ago
487c573c28
Add dedicated class for empty placeholders ( #27788 ) ( #27792 )
...
Backport #27788 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/27784
<img width="1033" alt="Screenshot 2023-10-25 at 19 07 15"
src="https://github.com/go-gitea/gitea/assets/115237/1a363851-1a86-48cb-99ec-0a573371bb6e ">
<img width="1051" alt="Screenshot 2023-10-25 at 19 07 41"
src="https://github.com/go-gitea/gitea/assets/115237/add4b606-2264-430a-af35-249ef005817f ">
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
1 year ago
95db95ef91
Fix incorrect "tab" parameter for repo search sub-template ( #27755 ) ( #27764 )
...
Backport #27755 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
48e3aec862
Enable followCursor for language stats bar ( #27713 ) ( #27739 )
...
Backport #27713 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/27600
Also tested together with https://github.com/go-gitea/gitea/pull/27704 ,
works well.
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
1848858a1e
Feed UI Improvements ( #27356 ) ( #27717 )
...
Backport #27356 by @silverwind
Various improvements related to feeds:
- Fix markdown rendering
- Increase font size from 13px to default 14px via `flex-item`
- Add style to hashes
- Move the timestamp to title line. I realize it's not optimal for
translation, we may need to change all these translations
Before:
<img width="768" alt="Screenshot 2023-09-29 at 22 52 58"
src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c ">
After:
<img width="781" alt="Screenshot 2023-09-29 at 22 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8 ">
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
8885108c42
Improve feed icons and feed merge text color ( #27498 ) ( #27716 )
...
Backport #27498 by @silverwind
1. Improve various feed icons
2. Fix merge message color
<img width="763" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3f5bcb23-6d90-4c63-85f2-46bd7e1c96d6 ">
<img width="769" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/466c37b4-e2f4-42bb-922d-b86596cdc6d0 ">
Fixes: https://github.com/go-gitea/gitea/issues/27495
Continues: https://github.com/go-gitea/gitea/pull/27356
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
6cef7a767b
cleanup repo details icons/labels ( #27644 ) ( #27654 )
...
Backport #27644 by @denyskon
Fix #27596
Change confusing behavior when showing information about a repo via labels and icons.
Implement changes proposed by @lng2020 in
https://github.com/go-gitea/gitea/pull/27627#pullrequestreview-1678787673 .
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
1 year ago
6befca1695
Fix required checkboxes in issue forms ( #27592 ) ( #27692 )
...
Backport #27592 by @JakobDev
If you set a checkbox as required in a issue form at the moment, the
checkbox is checked and read only, what does not make much sense. With
this PR, the Checkbox actually needs to be checked. The label supports
now also Markdown. This matches GitHub's behaviour.
And yes, I know the CSS is a ugly workaround. It looks like the given
CSS code is part Fomantic and I don't know how to change that. The
Maintainers are free to change that.
Co-authored-by: JakobDev <jakobdev@gmx.de>
1 year ago
bf76216de1
Hide archived labels by default from the suggestions when assigning labels for an issue ( #27451 ) ( #27661 )
...
Backport #27451 by @puni9869
Followup of #27115
Finally closes #25237
## Screenshots
### Issue Sidebar
<img width="513" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/9f7fda2f-5a03-4684-8619-fd3498a95b41 ">
### PR sidebar
<img width="367" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/53db9b64-faec-4a67-91d6-76945596a469 ">
### PR sidebar with archived labels shown
<img width="352" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/9dc5050f-4e69-4f76-bb83-582480a2281e ">
Signed-off-by: puni9869 <punitinani1@hotmail.com>
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
21c3513d49
Improve dropdown button alignment and fix hover bug ( #27632 ) ( #27637 )
...
Backport #27632 by @wxiaoguang
1. fix #27631 , and add samples to devtest page
2. fix incorrect color for "ui dropdown button" when hover
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
fa6941cf8c
Backport manually for a tmpl issue in v1.21 ( #27612 )
...
backport #27514
close #27607
1 year ago
21f1e223d8
Keep filter when showing unfiltered results on explore page ( #27192 ) ( #27589 )
...
Backport #27192 by @JakobDev
Fixes https://codeberg.org/Codeberg/Community/issues/1302
Co-authored-by: JakobDev <jakobdev@gmx.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
63a321b83a
Don't show Link to TOTP if not set up ( #27585 ) ( #27588 )
...
Backport #27585 by @JakobDev
Fixes https://codeberg.org/forgejo/forgejo/issues/1592
When login in with WebAuth, the page has a link to use TOTP instead.
This link is always displayed, no matter if the User has set up TOTP or
not, which do of cause not work for those who have not.
Co-authored-by: JakobDev <jakobdev@gmx.de>
1 year ago
7ec7c733c7
Replace ajax with fetch, improve image diff ( #27267 ) ( #27583 )
...
Backport #27267 by @silverwind
1. Dropzone attachment removal, pretty simple replacement
2. Image diff: The previous code fetched every image twice, once via
`img[src]` and once via `$.ajax`. Now it's only fetched once and a
second time only when necessary. The image diff code was partially
rewritten.
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
f19feb0f47
Revert "Fix pr template ( #27436 )" ( #27567 )
...
Reverts backport go-gitea/gitea#27440
Fix #27564
1 year ago
71f091ef97
Remove max-width and add hide text overflow ( #27359 ) ( #27550 )
...
Backport #27359 by @kdumontnu
Closes https://github.com/go-gitea/gitea/issues/27358
Co-authored-by: Kyle D <kdumontnu@gmail.com>
1 year ago
4c9f7d0710
api: GetPullRequestCommits: return file list ( #27483 ) ( #27539 )
...
Backport #27483 by @msantos
Fixes https://github.com/go-gitea/gitea/issues/27481
---
Patch tested:
```json
[
{
"url": "7664dcb4417664dcb441
1 year ago
fb5ae2ab94
Restore warning commit status ( #27504 ) ( #27529 )
...
Backport #27504 by @silverwind
Partial revert of https://github.com/go-gitea/gitea/pull/25839 . This
commit status is used by a number of external integrations, so I think
we should not remove it (See
https://github.com/go-gitea/gitea/pull/25839#issuecomment-1729002077 ).
This is a rare case where an existing migration needed to be alterted to
avoid data loss.
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: delvh <dev.lh@web.de>
1 year ago
8419897fba
Update JS and PY dependencies ( #27501 ) ( #27518 )
...
Backport https://github.com/go-gitea/gitea/pull/27501 to 1.21
- Update all JS and PY dependencies
- Enable eslint `prefer-object-has-own` and autofix issue
- Fix styling on citation buttons
- Tested citation, mermaid, monaco, swagger, katex
Citation button issue was that these buttons were not filled:
<img width="136" alt="Screenshot 2023-10-07 at 14 05 08"
src="https://github.com/go-gitea/gitea/assets/115237/435f0c91-28ac-46b3-bae4-dad768b29c05 ">
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-authored-by: Giteabot <teabot@gitea.io>
1 year ago
9207331f4d
Revert #27426 ( #27474 )
...
Apparently, we didn't backport one of the refactoring PRs which caused
the fixup we backported to fail.
Fixes: https://github.com/go-gitea/gitea/issues/27473
1 year ago
aaf35ee49c
Refactor system setting ( #27000 ) ( #27452 )
...
Backport #27000 by @wxiaoguang
This PR reduces the complexity of the system setting system.
It only needs one line to introduce a new option, and the option can be
used anywhere out-of-box.
It is still high-performant (and more performant) because the config
values are cached in the config system.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
51001d9ffe
Fix pr template ( #27436 ) ( #27440 )
...
Backport #27436 by @lunny
Fix #27431
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 year ago
1ff6b7783c
Fix missing `ctx` in new_form.tmpl ( #27434 ) ( #27438 )
...
Backport #27434 by @CaiCandong
Fix #27432
Regression of #27265
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
1 year ago
99e2071eeb
Fix yet another `ctx` template bug ( #27417 ) ( #27426 )
...
Backport #27417 by @delvh
Fixes #27416
Co-authored-by: delvh <dev.lh@web.de>
1 year ago
1dd84ec3a1
Use flex-container for repo and org settings ( #27418 ) ( #27430 )
...
Backport #27418 by @silverwind
Same as https://github.com/go-gitea/gitea/pull/26046 but for repo and
org settings pages, reducing the margins between the boxes:
<img width="1247" alt="Screenshot 2023-10-03 at 23 25 19"
src="https://github.com/go-gitea/gitea/assets/115237/4e68ad5e-5fdc-4466-aefb-ec71bf411d45 ">
<img width="1255" alt="Screenshot 2023-10-03 at 23 27 12"
src="https://github.com/go-gitea/gitea/assets/115237/9068369b-a75d-401e-8b8d-3bd4bbe097dc ">
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
28d970e4a6
Hide archived labels when filtering by labels on the issue list ( #27115 ) ( #27381 )
...
Backport #27115 by @puni9869
Followup https://github.com/go-gitea/gitea/pull/26820
## Archived labels UI for issue filter and issue filter actions for
issues/pull request pages.
Changed:
* Enhanced the Issue filter and Issue filter actions UI page to
seamlessly incorporate a list of archived labels.
* Pagination functionality is same as before. If archived label checkbox
is checked then we are adding a query string`archived=true` in the url
to save the state of page.
* Issue filter actions menu is separated into different template.
* Adding the archived flag in issue url labels.
* Pull Request page is also work the same.
Outsourced:
* Defer the implementation of specialized handling for archived labels
to upcoming pull requests. This step will be undertaken subsequent to
the successful merge of this pull request.
Screenshots
### Issue page
<img width="1360" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432 ">
### Issue page with label filter on archived label checkbox when not
checked --> No archived label is there in list
<img width="1249" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9 ">
### Issue page with label filter on archived label checkbox when checked
--> Show archived label in the list.
<img width="710" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf ">
### Issue page with label filter on issue action menu on archived label
checkbox when checked --> Show archived label in the list.
<img width="409" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178 ">
### Applied the archived=true in Issue labels when archived checkbox is
checked.
<img width="984" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0 ">
---
Part of https://github.com/go-gitea/gitea/issues/25237
Signed-off-by: puni9869 <punitinani1@hotmail.com>
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
Co-authored-by: delvh <dev.lh@web.de>
1 year ago
eea79ce586
highlight user details link ( #26998 ) ( #27376 )
...
Backport #26998 by @denyskon
This PR adds a separated column in the users table for operations. The
username link now redirects back to user page.
Resolves
https://github.com/go-gitea/gitea/pull/26713#pullrequestreview-1603001285
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
e9340ce9bc
Fix missing ctx for GetRepoLink in dashboard ( #27372 ) ( #27375 )
...
Backport #27372 by @CaiCandong
As title
Fix #27369
Regression of #27265
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
1 year ago
wxiaoguang
Giteabot
Nanguan Lin
silverwind
delvh