gitea

Author SHA1 Message Date

Author	SHA1	Message	Date
Zettat123	0690cb076b	Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365 ) Fix #28121 I did some tests and found that the `missing signature key` error is caused by an incorrect `Content-Type` header. Gitea correctly sets the `Content-Type` header when serving files. `348d1d0f32/routers/api/packages/container/container.go (L712-L717)` However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may be set to an incorrect value by the storage service. To fix this issue, we can use query parameters to override response header values. https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img width="600px" src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555" /> In this PR, I introduced a new parameter to the `URL` method to support additional parameters. ``` URL(path, name string, reqParams url.Values) (*url.URL, error) ``` --- Most S3-like services support specifying the content type when storing objects. However, Gitea always use `application/octet-stream`. Therefore, I believe we also need to improve the `Save` method to support storing objects with the correct content type. `b7fb20e73e/modules/storage/minio.go (L214-L221)`	4 months ago
FuXiaoHei	cdc9e91750	add path prefix to ObjectStorage.Iterator (#23332 ) Support to iterator subdirectory in ObjectStorage for ObjectStorage.Iterator method. It's required for https://github.com/go-gitea/gitea/pull/22738 to make artifact files cleanable. --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2 years ago
Jason Song	67881ae99a	Skip initing disabled storages (#21985 ) If `Attachment` or `Packages` are disabled, we don't have to init the storages for them.	2 years ago

Zettat123

Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365 )

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)

4 months ago

FuXiaoHei

cdc9e91750

add path prefix to ObjectStorage.Iterator (#23332 )

Support to iterator subdirectory in ObjectStorage for
ObjectStorage.Iterator method.

It's required for https://github.com/go-gitea/gitea/pull/22738 to make
artifact files cleanable.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

2 years ago

Jason Song

67881ae99a

Skip initing disabled storages (#21985 )

If `Attachment` or `Packages` are disabled, we don't have to init the
storages for them.

2 years ago

3 Commits (e3e32605a144076572ac55fb5053655ee045a0f9)