gitea

Commit Graph

Author	SHA1	Message	Date
Eng Zer Jun	8b0aaa5f86	test: use `T.TempDir` to create temporary test directory (#21043 ) A testing cleanup. This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot. Reference: https://pkg.go.dev/testing#T.TempDir ```go func TestFoo(t *testing.T) { // before tmpDir, err := os.MkdirTemp("", "") require.NoError(t, err) defer os.RemoveAll(tmpDir) // now tmpDir := t.TempDir() } ``` Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	3 years ago
Lunny Xiao	d91d4db344	Move tests as seperate sub packages to reduce duplicated file names (#19951 )	3 years ago

Author

SHA1

Message

Date

Eng Zer Jun

8b0aaa5f86

test: use `T.TempDir` to create temporary test directory (#21043 )

A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

3 years ago

Lunny Xiao

d91d4db344

Move tests as seperate sub packages to reduce duplicated file names (#19951 )

3 years ago

2 Commits (f1e07d8c879aed32d079694d3623f9c6450ee8cd)