Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
wxiaoguang
1fcf96ad01
Improve PR Review Box UI (#22986)
This PR follows:
* #22950
### Before
The Review Box has many problems:
* It doesn't work for small screens.
* It has an anonying animation which makes the UI laggy.
* It uses "custom dropdown menu" which is very difficult to fine tune.
* `$().toggle('visible')` is not a correct call
* jQuery just accepts any invalid `duration` argument:
`$().toggle('anyting')`
* The button is not a button.
<details>
![image](https://user-images.githubusercontent.com/2114189/219948865-6da3f39c-6fde-4c86-9e42-da5020f3d0c3.png)
</details>
### After
These problems are fixed, and eliminate many `!important` games.
<details>
![image](https://user-images.githubusercontent.com/2114189/219952744-8862fe1a-7ef1-49e4-bf92-2d0c1f104ee4.png)
![image](https://user-images.githubusercontent.com/2114189/219952771-be169a76-45fd-47a8-8f9c-b447d064f4ca.png)
![image](https://user-images.githubusercontent.com/2114189/219952784-3f52e9b7-64ce-4ad1-9553-64c33fb83042.png)
</details>
And most dropdown icons still looks good:
<details>
![image](https://user-images.githubusercontent.com/2114189/219952942-52866a00-e0f9-4af7-8fb5-eb1a8cad1ff3.png)
![image](https://user-images.githubusercontent.com/2114189/219948909-b3bfb844-f84e-4b79-ab1f-382ec66dec31.png)
</details>
Co-authored-by: delvh <leon@kske.dev>
|
2 years ago |
.. |
blob_excerpt.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
box.tmpl
|
Improve PR Review Box UI (#22986)
|
2 years ago |
comment_form.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
comment_form_datahandler.tmpl
|
Make sure fmt catches all templates (#20979)
|
2 years ago |
comments.tmpl
|
Fix broken pull request files (#22962)
|
2 years ago |
compare.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
conversation.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
csv_diff.tmpl
|
Fix CSV diff for added/deleted files (#21189)
|
2 years ago |
escape_title.tmpl
|
Switch Unicode Escaping to a VSCode-like system (#19990)
|
2 years ago |
image_diff.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
new_comment.tmpl
|
Do not reload page after adding comments in Pull Request reviews (#13877)
|
4 years ago |
new_review.tmpl
|
Improve PR Review Box UI (#22986)
|
2 years ago |
options_dropdown.tmpl
|
Add filetree on left of diff view (#21012)
|
2 years ago |
section_code.tmpl
|
Switch Unicode Escaping to a VSCode-like system (#19990)
|
2 years ago |
section_split.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
section_unified.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
stats.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
whitespace_dropdown.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |