Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
wxiaoguang
d4f35bd681
Use a general approch to improve a11y for all checkboxes and dropdowns. ( #23542 )
...
This PR follows #22599 and #23450
The major improvements:
1. The `aria-*.js` are totally transparent now, no need to call
`attachDropdownAria` explicitly anymore.
* It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch
works.
* It makes all dynamically generated checkbox/dropdown work with a11y
without any change
* eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js`
2. Since it's totally transparent now, it could be easier to modify or
remove in the future.
3. It handles all selection labels as well (by onLabelCreate), so it
supports "multiple selection dropdown" now.
* It partially completes one of my TODOs: `TODO: multiple selection is
not supported yet.`
4. The code structure is clearer, code blocks are splitted into
different functions.
* The old `attachOneDropdownAria` was splitted into separate functions.
* It makes it easier to add more fine tunes in the future, and co-work
with contributors.
6. The code logic is similar as before, only two new parts:
1. the `ariaCheckboxFn` and `ariaDropdownFn` functions
2. the `onLabelCreate` and `updateSelectionLabel` functions
In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I
think the code is still understandable, otherwise the code would be much
more complex to read.
Thanks to fsologureng for the idea about "improving the 'delete icon'
with aria attributes".
If there is anything unclear or incorrect, feel free to ask and discuss,
or propose new PRs for it.
2 years ago
..
admin
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
comp
Scoped labels: set aria-disabled on muted Exclusive option for a11y ( #23306 )
2 years ago
captcha.js
Add new captcha: cloudflare turnstile ( #22369 )
2 years ago
citation.js
Fix switched citation format ( #23250 )
2 years ago
clipboard.js
Use link in UI which returned a relative url but not html_url which contains an absolute url ( #21986 )
2 years ago
codeeditor.js
Quick fixes monaco-editor error: "vs.editor.nullLanguage" ( #21734 )
2 years ago
colorpicker.js
JS refactors ( #22227 )
2 years ago
common-global.js
Use a general approch to improve a11y for all checkboxes and dropdowns. ( #23542 )
2 years ago
common-issue.js
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
common-organization.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
contextpopup.js
Change interactiveBorder to fix popup preview ( #23169 )
2 years ago
copycontent.js
JS refactors ( #22227 )
2 years ago
dropzone.js
JS refactors ( #22227 )
2 years ago
emoji.js
JS refactors ( #22227 )
2 years ago
eventsource.sharedworker.js
Fix the JS error "EventSource is not defined" caused by some non-standard browsers ( #20584 )
2 years ago
file-fold.js
JS refactors ( #22227 )
2 years ago
formatting.js
JS refactors ( #22227 )
2 years ago
heatmap.js
JS refactors ( #22227 )
2 years ago
imagediff.js
Fix various ImageDiff/SVG bugs ( #23312 )
2 years ago
install.js
Fix various bugs for "install" page ( #23194 )
2 years ago
notification.js
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
org-team.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
pull-view-file.js
Replace unstyled meter with progress ( #19968 )
2 years ago
repo-branch.js
Add apply-patch, basic revert and cherry-pick functionality ( #17902 )
3 years ago
repo-code.js
Fix links for the menus in the view file page ( #22795 )
2 years ago
repo-code.test.js
Ignore line anchor links with leading zeroes ( #21728 )
2 years ago
repo-commit.js
Fix hidden commit status on multiple checks ( #22889 )
2 years ago
repo-common.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-diff-filetree.js
JS refactors ( #22227 )
2 years ago
repo-diff.js
Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment ( #23245 )
2 years ago
repo-editor.js
Support paste treepath when creating a new file or updating the file name ( #23209 )
2 years ago
repo-findfile.js
Refactor branch/tag selector to Vue SFC ( #23421 )
2 years ago
repo-findfile.test.js
Refactor branch/tag selector to Vue SFC ( #23421 )
2 years ago
repo-graph.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-home.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-issue-content.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-issue-pr-form.js
JS refactors ( #22227 )
2 years ago
repo-issue.js
Fix JS error on compare page ( #23551 )
2 years ago
repo-legacy.js
Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem ( #23450 )
2 years ago
repo-migrate.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-migration.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-projects.js
Sync the class change of Edit Column Button to JS code ( #23400 )
2 years ago
repo-release.js
Hide target selector if tag exists when creating new release ( #23171 )
2 years ago
repo-settings.js
Remove customized (unmaintained) dropdown, improve aria a11y for dropdown ( #19861 )
2 years ago
repo-template.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-unicode-escape.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
repo-wiki.js
Enable spellcheck for EasyMDE, use contenteditable mode ( #19776 )
2 years ago
serviceworker.js
JS refactors ( #22227 )
2 years ago
sshkey-helper.js
Use explicit jQuery import, remove unused eslint globals ( #18435 )
3 years ago
stopwatch.js
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
tablesort.js
JS refactors ( #22227 )
2 years ago
tribute.js
JS refactors ( #22227 )
2 years ago
user-auth-webauthn.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
user-auth.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
user-settings.js
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago