Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

oliverpool 26653b196b Store webhook event in database (#29145) ... Refactor the webhook logic, to have the type-dependent processing happen only in one place. --- ## Current webhook flow 1. An event happens 2. It is pre-processed (depending on the webhook type) and its body is added to a task queue 3. When the task is processed, some more logic (depending on the webhook type as well) is applied to make an HTTP request This means that webhook-type dependant logic is needed in step 2 and 3. This is cumbersome and brittle to maintain. Updated webhook flow with this PR: 1. An event happens 2. It is stored as-is and added to a task queue 3. When the task is processed, the event is processed (depending on the webhook type) to make an HTTP request So the only webhook-type dependent logic happens in one place (step 3) which should be much more robust. ## Consequences of the refactor - the raw event must be stored in the hooktask (until now, the pre-processed body was stored) - to ensure that previous hooktasks are correctly sent, a `payload_version` is added (version 1: the body has already been pre-process / version 2: the body is the raw event) So future webhook additions will only have to deal with creating an http.Request based on the raw event (no need to adjust the code in multiple places, like currently). Moreover since this processing happens when fetching from the task queue, it ensures that the queuing of new events (upon a `git push` for instance) does not get slowed down by a slow webhook. As a concrete example, the PR #19307 for custom webhooks, should be substantially smaller: - no need to change `services/webhook/deliver.go` - minimal change in `services/webhook/webhook.go` (add the new webhook to the map) - no need to change all the individual webhook files (since with this refactor the `*webhook_model.Webhook` is provided as argument)		9 months ago
..
actions	Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (#29584)	9 months ago
agit	A small refactor for agit implementation (#29614)	9 months ago
asymkey	Move some asymkey functions to service layer (#28894)	9 months ago
attachment	Add support for API blob upload of release attachments (#29507)	9 months ago
auth	Move some asymkey functions to service layer (#28894)	9 months ago
automerge	Simplify how git repositories are opened (#28937)	10 months ago
context	Use strict protocol check when redirect (#29642)	9 months ago
contexttest	Make "/user/login" page redirect if the current user has signed in (#29583)	9 months ago
convert	Enable/disable owner and repo projects independently (#28805)	9 months ago
cron	Move some asymkey functions to service layer (#28894)	9 months ago
doctor	Move some asymkey functions to service layer (#28894)	9 months ago
externalaccount	Revert "Support SAML authentication (#25165)" (#29358)	9 months ago
feed	More `db.DefaultContext` refactor (#27265)	1 year ago
forms	Make wiki default branch name changable (#29603)	9 months ago
gitdiff	Fix incorrect diff expander for deletion of last lines in a file (#29501)	9 months ago
indexer	Fix missing issue search index update when changing status (#28325)	12 months ago
issue	Add missing database transaction for new issue (#29490)	9 months ago
lfs	Move context from modules to services (#29440)	9 months ago
mailer	Move context from modules to services (#29440)	9 months ago
markup	Move context from modules to services (#29440)	9 months ago
migrations	remove util.OptionalBool and related functions (#29513)	9 months ago
mirror	Simplify how git repositories are opened (#28937)	10 months ago
notify	Update status and code index after changing the default branch (#27018)	1 year ago
org	Delete repos of org when purge delete user (#27273)	1 year ago
packages	remove util.OptionalBool and related functions (#29513)	9 months ago
pull	Add user blocking (#29028)	9 months ago
release	Use the database object format name but not read from git repoisitory everytime and fix possible migration wrong objectformat when migrating a sha256 repository (#29294)	9 months ago
repository	Add download URL for executable files (#28260)	9 months ago
secrets	Refactor deletion (#28610)	11 months ago
task	Fix incorrect ctx usage in defer function (#27740)	1 year ago
uinotification	Penultimate round of `db.DefaultContext` refactor (#27414)	1 year ago
user	Skip email domain check when admins edit user emails (#29609)	9 months ago
webhook	Store webhook event in database (#29145)	9 months ago
wiki	Make wiki default branch name changable (#29603)	9 months ago