Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

sillyguodong 2f49b55c19 Fix cannot reopen after pushing commits to a closed PR (#23189) ... Close: #22784 1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of [issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which needs to be fixed. 2. After closing a PR and pushing commits, `headBranchSha` is not equal to `sha`(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.  3. Even if PR is already close, we should still insert comment record into DB when we push commits. So we should still call function `CreatePushPullComment()`. 067b0c2664/services/pull/pull.go (L260-L282) So, I add a switch(`includeClosed`) to the `GetUnmergedPullRequestsByHeadInfo` func to control whether the status of PR must be open. In this case, by setting `includeClosed` to `true`, we can query the closed PR.  4. In the loop of comments, I use the`latestCloseCommentID` variable to record the last occurrence of the close comment. In the go template, if the status of PR is closed, the comments whose type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID` won't be rendered.  e.g. 1). The initial status of the PR is opened.  2). Then I click the button of `Close`. PR is closed now.  3). I try to push a commit to this PR, even though its current status is closed.  But in comments list, this commit do not display.This is as expected ：）  4). Click the `Reopen` button, the commit which is pushed after closing PR display now.  --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2 years ago
..
actions	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
branch	add margin top to the top of branches (#23002)	2 years ago
cite	Copy citation file content, in APA and BibTex format, on repo home page (#19999)	2 years ago
diff	Refactor `ctx` in templates (#23105)	2 years ago
editor	Fix missed `.hide` class (#23208)	2 years ago
find	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
graph	Add context cache as a request level cache (#22294)	2 years ago
issue	Fix cannot reopen after pushing commits to a closed PR (#23189)	2 years ago
migrate	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
projects	Projects: rename Board to Column in interface and improve consistency (#22767)	2 years ago
pulls	Always go full width in PR view (#22844)	2 years ago
release	Add context cache as a request level cache (#22294)	2 years ago
settings	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
wiki	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
activity.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
blame.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
branch_dropdown.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
clone_buttons.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
clone_script.tmpl	Make clone URL use current page's host (#22808)	2 years ago
commit_page.tmpl	Use `gt-relative` class instead of the ambiguous `gt-pr` class (#23008)	2 years ago
commit_status.tmpl	Change commit status icons to SVG (#20736)	2 years ago
commit_statuses.tmpl	Fix hidden commit status on multiple checks (#22889)	2 years ago
commits.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
commits_list.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
commits_list_small.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
commits_table.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
create.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
create_helper.tmpl	Add templates to customize text when creating and migrating repositories	2 years ago
empty.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
file_info.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
forks.tmpl	Add context cache as a request level cache (#22294)	2 years ago
graph.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
header.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
home.tmpl	Improve PR Review Box UI (#22986)	2 years ago
icon.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
packages.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
search.tmpl	Remove Fomantic-UI's `.hidden` CSS class for menu elements (#22895)	2 years ago
shabox_badge.tmpl	Fix shabox regression (#22924)	2 years ago
sub_menu.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
unicode_escape_prompt.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
upload.tmpl	Refactor `i18n` to `locale` (#20153)	2 years ago
user_cards.tmpl	Add context cache as a request level cache (#22294)	2 years ago
view_file.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
view_list.tmpl	Add wrapper to author to avoid long name ui problem (#23030)	2 years ago
watchers.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago