Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Sergey Zolotarev 7b79be24ca Fix panic in storageHandler (#27446) ... storageHandler() is written as a middleware but is used as an endpoint handler, and thus `next` is actually `nil`, which causes a null pointer dereference when a request URL does not match the pattern (where it calls `next.ServerHTTP()`). Example CURL command to trigger the panic: ``` curl -I "http://yourhost/gitea//avatars/a" ``` Fixes #27409 --- Note: the diff looks big but it's actually a small change - all I did was to remove the outer closure (and one level of indentation) ~and removed the HTTP method and pattern checks as they seem redundant because go-chi already does those checks~. You might want to check "Hide whitespace" when reviewing it. Alternative solution (a bit simpler): append `, misc.DummyOK` to the route declarations that utilize `storageHandler()` - this makes it return an empty response when the URL is invalid. I've tested this one and it works too. Or maybe it would be better to return a 400 error in that case (?)		1 year ago
..
api	Don't let API add 2 exclusive labels from same scope (#27433)	1 year ago
common	Refactor system setting (#27000)	1 year ago
install	Refactor system setting (#27000)	1 year ago
private	make writing main test easier (#27270)	1 year ago
utils	Implement FSFE REUSE for golang files (#21840)	2 years ago
web	Fix panic in storageHandler (#27446)	1 year ago
init.go	Another round of `db.DefaultContext` refactor (#27103)	1 year ago