Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Yarden Shoham
5ddf67a9c2
Make issue meta dropdown support Enter, confirm before reloading ( #23014 ) ( #23102 )
...
Backport #23014
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742 , now the comment reaction and menu work with
keyboard.
* partially fix for #17705 , in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png )
</details>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
actions
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
branch
add margin top to the top of branches ( #23002 )
2 years ago
cite
Copy citation file content, in APA and BibTex format, on repo home page ( #19999 )
2 years ago
diff
Improve PR Review Box UI ( #22986 )
2 years ago
editor
Fix commit name in Apply Patch page ( #23086 ) ( #23099 )
2 years ago
find
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
graph
Add context cache as a request level cache ( #22294 )
2 years ago
issue
Make issue meta dropdown support Enter, confirm before reloading ( #23014 ) ( #23102 )
2 years ago
migrate
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
projects
Scoped labels ( #22585 )
2 years ago
pulls
Always go full width in PR view ( #22844 )
2 years ago
release
Add context cache as a request level cache ( #22294 )
2 years ago
settings
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
wiki
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
activity.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
blame.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
branch_dropdown.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
clone_buttons.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
clone_script.tmpl
Make clone URL use current page's host ( #22808 )
2 years ago
commit_page.tmpl
Use `gt-relative` class instead of the ambiguous `gt-pr` class ( #23008 )
2 years ago
commit_status.tmpl
Change commit status icons to SVG ( #20736 )
3 years ago
commit_statuses.tmpl
Fix hidden commit status on multiple checks ( #22889 )
2 years ago
commits.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
commits_list.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
commits_list_small.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
commits_table.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
create.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
create_helper.tmpl
Add templates to customize text when creating and migrating repositories
2 years ago
empty.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
file_info.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
forks.tmpl
Add context cache as a request level cache ( #22294 )
2 years ago
graph.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
header.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
home.tmpl
Improve PR Review Box UI ( #22986 )
2 years ago
icon.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
packages.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
search.tmpl
Remove Fomantic-UI's `.hidden` CSS class for menu elements ( #22895 )
2 years ago
shabox_badge.tmpl
Fix shabox regression ( #22924 )
2 years ago
sub_menu.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
unicode_escape_prompt.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
upload.tmpl
Refactor `i18n` to `locale` ( #20153 )
3 years ago
user_cards.tmpl
Add context cache as a request level cache ( #22294 )
2 years ago
view_file.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
view_list.tmpl
Add wrapper to author to avoid long name ui problem ( #23030 ) ( #23098 )
2 years ago
watchers.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago