Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
sillyguodong
5eea61dbc8
Fix missing commit status in PR which from forked repo (#23351)
close: #23347
### Reference and Inference
According to Github REST API
[doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference):
1. The `Drone CI` that can create some commit status by
[API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)
is enabled in `go-gitea/gitea`. So I tried to call the API to get a
commit status list of a PR which is commited to upstream
repo(`go-gitea/gitea`). As a result, the API returned a array of commit
status.
![image](https://user-images.githubusercontent.com/33891828/223913371-313d047a-5e2e-484c-b13e-dcd38748703e.png)
2. Then I tried to call the API to get commit status list of the
reference which of the `SHA` is the same as step 1 in the repo which is
forked from `go-gitea/gitea`. But I got a empty array.
![image](https://user-images.githubusercontent.com/33891828/223930827-17a64d3c-f466-4980-897c-77fe386c4d3b.png)
So, I believe it that:
1. The commit status is not shared between upstream repo and forked
repo.
2. The coomit status is bound to a repo that performs actions. (Gitea's
logic is the same)
### Cause
During debugging, I found it that commit status are not stored in the DB
as expected.
So, I located the following code:
8cadd51bf2/services/actions/commit_status.go (L18-L26)
When I create a PR, the type of `event` is `pull request`, not `push`.
So the code return function directly.
### Screenshot
![image](https://user-images.githubusercontent.com/33891828/223939339-dadf539c-1fdd-40c4-96e9-2e4fa733f531.png)
![image](https://user-images.githubusercontent.com/33891828/223939519-edb02bf0-2478-4ea5-9366-be85468f02db.png)
![image](https://user-images.githubusercontent.com/33891828/223939557-ec6f1375-5536-400e-8987-fb7d2fd452fa.png)
### Other
In this PR, I also fix the problem of missing icon which represents
running in PRs list.
![image](https://user-images.githubusercontent.com/33891828/223939898-2a0339e4-713f-4c7b-9d99-2250a43f3457.png)
![image](https://user-images.githubusercontent.com/33891828/223939979-037a975f-5ced-480c-bac7-0ee00ebfff4b.png)
|
2 years ago |
.. |
actions
|
Fix actions frontend bugs (pagination, long name alignment) and small simplify (#23370)
|
2 years ago |
branch
|
add margin top to the top of branches (#23002)
|
2 years ago |
cite
|
Copy citation file content, in APA and BibTex format, on repo home page (#19999)
|
2 years ago |
diff
|
Fix PR view misalignment caused by long name file (#23321)
|
2 years ago |
editor
|
Fix broken code editor diff preview (#23307)
|
2 years ago |
find
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
graph
|
Add context cache as a request level cache (#22294)
|
2 years ago |
issue
|
Deduplicate template code for label selection menu (#23431)
|
2 years ago |
migrate
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
projects
|
Show edit/close/delete button on organization wide repositories (#23388)
|
2 years ago |
pulls
|
Always go full width in PR view (#22844)
|
2 years ago |
release
|
Hide target selector if tag exists when creating new release (#23171)
|
2 years ago |
settings
|
Add user webhooks (#21563)
|
2 years ago |
wiki
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
activity.tmpl
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
blame.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
branch_dropdown.tmpl
|
Refactor branch/tag selector dropdown (first step) (#23394)
|
2 years ago |
clone_buttons.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
clone_script.tmpl
|
Make clone URL use current page's host (#22808)
|
2 years ago |
commit_page.tmpl
|
Refactor branch/tag selector dropdown (first step) (#23394)
|
2 years ago |
commit_status.tmpl
|
Fix missing commit status in PR which from forked repo (#23351)
|
2 years ago |
commit_statuses.tmpl
|
Fix hidden commit status on multiple checks (#22889)
|
2 years ago |
commits.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
commits_list.tmpl
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
commits_list_small.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
commits_table.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
create.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
create_helper.tmpl
|
Add templates to customize text when creating and migrating repositories
|
2 years ago |
empty.tmpl
|
Add main landmark to templates and adjust titles (#22670)
|
2 years ago |
file_info.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
forks.tmpl
|
Add context cache as a request level cache (#22294)
|
2 years ago |
graph.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
header.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
home.tmpl
|
Fix and move "Use this template" button (#23398)
|
2 years ago |
icon.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
packages.tmpl
|
Add main landmark to templates and adjust titles (#22670)
|
2 years ago |
search.tmpl
|
Remove Fomantic-UI's `.hidden` CSS class for menu elements (#22895)
|
2 years ago |
shabox_badge.tmpl
|
Fix shabox regression (#22924)
|
2 years ago |
sub_menu.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
unicode_escape_prompt.tmpl
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
upload.tmpl
|
Refactor `i18n` to `locale` (#20153)
|
2 years ago |
user_cards.tmpl
|
Add context cache as a request level cache (#22294)
|
2 years ago |
view_file.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
view_list.tmpl
|
Add wrapper to author to avoid long name ui problem (#23030)
|
2 years ago |
watchers.tmpl
|
Add main landmark to templates and adjust titles (#22670)
|
2 years ago |