Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

wxiaoguang 722dab5286 Make HTML template functions support context (#24056) ... # Background Golang template is not friendly for large projects, and Golang template team is quite slow, related: * `https://github.com/golang/go/issues/54450` Without upstream support, we can also have our solution to make HTML template functions support context. It helps a lot, the above Golang template issue `#54450` explains a lot: 1. It makes `{{Locale.Tr}}` could be used in any template, without passing unclear `(dict "root" . )` anymore. 2. More and more functions need `context`, like `avatar`, etc, we do not need to do `(dict "Context" $.Context)` anymore. 3. Many request-related functions could be shared by parent&children templates, like "user setting" / "system setting" See the test `TestScopedTemplateSetFuncMap`, one template set, two `Execute` calls with different `CtxFunc`. # The Solution Instead of waiting for upstream, this PR re-uses the escaped HTML template trees, use `AddParseTree` to add related templates/trees to a new template instance, then the new template instance can have its own FuncMap , the function calls in the template trees will always use the new template's FuncMap. `template.New` / `template.AddParseTree` / `adding-FuncMap` are all quite fast, so the performance is not affected. The details: 1. Make a new `html/template/Template` for `all` templates 2. Add template code to the `all` template 3. Freeze the `all` template, reset its exec func map, it shouldn't execute any template. 4. When a router wants to render a template by its `name` 1. Find the `name` in `all` 2. Find all its related sub templates 3. Escape all related templates (just like what the html template package does) 4. Add the escaped parse-trees of related templates into a new (scoped) `text/template/Template` 5. Add context-related func map into the new (scoped) text template 6. Execute the new (scoped) text template 7. To improve performance, the escaped templates are cached to `template sets` # FAQ ## There is a `unsafe` call, is this PR unsafe? This PR is safe. Golang has strict language definition, it's safe to do so: https://pkg.go.dev/unsafe#Pointer (1) Conversion of a *T1 to Pointer to *T2 ## What if Golang template supports such feature in the future? The public structs/interfaces/functions introduced by this PR is quite simple, the code of `HTMLRender` is not changed too much. It's very easy to switch to the official mechanism if there would be one. ## Does this PR change the template execution behavior? No, see the tests (welcome to design more tests if it's necessary) --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Giteabot <teabot@gitea.io>		2 years ago
..
actions	Support triggering workflows by wiki related events (#24119)	2 years ago
activitypub	…
analyze	…
assetfs	…
auth	…
avatar	…
base	…
cache	Update redis library to support redis v7 (#24114)	2 years ago
charset	Refactor locale number (#24134)	2 years ago
container	…
context	Make HTML template functions support context (#24056)	2 years ago
csv	Refactor locale number (#24134)	2 years ago
doctor	…
emoji	…
eventsource	…
generate	…
git	Make wiki title supports dashes and improve wiki name related features (#24143)	2 years ago
gitgraph	…
graceful	Remove most path-based golangci exclusions (#24214)	2 years ago
hcaptcha	…
highlight	…
hostmatcher	…
html	…
httpcache	…
httplib	…
indexer	Allow adding new files to an empty repo (#24164)	2 years ago
issue/template	…
json	…
label	…
lfs	…
log	Remove most path-based golangci exclusions (#24214)	2 years ago
markup	Improve Wiki TOC (#24137)	2 years ago
mcaptcha	…
metrics	…
migration	…
mirror	…
nosql	Update redis library to support redis v7 (#24114)	2 years ago
notification	…
options	…
packages	…
paginator	…
pprof	…
private	Fix incorrect internal response type (#24173)	2 years ago
process	…
proxy	…
proxyprotocol	…
public	…
queue	Update redis library to support redis v7 (#24114)	2 years ago
recaptcha	…
references	…
regexplru	…
repository	…
secret	…
session	Update redis library to support redis v7 (#24114)	2 years ago
setting	Fix incorrect CORS default values (#24206)	2 years ago
sitemap	…
ssh	…
storage	…
structs	Fix Org edit page bugs: renaming detection, maxlength (#24161)	2 years ago
svg	…
sync	…
system	…
templates	Make HTML template functions support context (#24056)	2 years ago
test	Make HTML template functions support context (#24056)	2 years ago
timeutil	Remove untranslatable `on_date` key (#24106)	2 years ago
translation	Refactor locale number (#24134)	2 years ago
turnstile	…
typesniffer	…
updatechecker	…
upload	…
uri	…
user	…
util	…
validation	…
web	…
webhook	…