Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Lunny Xiao bd820aa9c5 Add context cache as a request level cache (#22294) ... To avoid duplicated load of the same data in an HTTP request, we can set a context cache to do that. i.e. Some pages may load a user from a database with the same id in different areas on the same page. But the code is hidden in two different deep logic. How should we share the user? As a result of this PR, now if both entry functions accept `context.Context` as the first parameter and we just need to refactor `GetUserByID` to reuse the user from the context cache. Then it will not be loaded twice on an HTTP request. But of course, sometimes we would like to reload an object from the database, that's why `RemoveContextData` is also exposed. The core context cache is here. It defines a new context ```go type cacheContext struct { ctx context.Context data map[any]map[any]any lock sync.RWMutex } var cacheContextKey = struct{}{} func WithCacheContext(ctx context.Context) context.Context { return context.WithValue(ctx, cacheContextKey, &cacheContext{ ctx: ctx, data: make(map[any]map[any]any), }) } ``` Then you can use the below 4 methods to read/write/del the data within the same context. ```go func GetContextData(ctx context.Context, tp, key any) any func SetContextData(ctx context.Context, tp, key, value any) func RemoveContextData(ctx context.Context, tp, key any) func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error) ``` Then let's take a look at how `system.GetString` implement it. ```go func GetSetting(ctx context.Context, key string) (string, error) { return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) { return cache.GetString(genSettingCacheKey(key), func() (string, error) { res, err := GetSettingNoCache(ctx, key) if err != nil { return "", err } return res.SettingValue, nil }) }) } ``` First, it will check if context data include the setting object with the key. If not, it will query from the global cache which may be memory or a Redis cache. If not, it will get the object from the database. In the end, if the object gets from the global cache or database, it will be set into the context cache. An object stored in the context cache will only be destroyed after the context disappeared.		2 years ago
..
security	Add main landmark to templates and adjust titles (#22670)	2 years ago
account.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
appearance.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
applications.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
applications_oauth2.tmpl	Allow creation of OAuth2 applications for orgs (#18084)	2 years ago
applications_oauth2_edit.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
applications_oauth2_edit_form.tmpl	Record OAuth client type at registration (#21316)	2 years ago
applications_oauth2_list.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
grants_oauth2.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
keys.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
keys_gpg.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
keys_principal.tmpl	Localize all timestamps (#21440)	2 years ago
keys_ssh.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
navbar.tmpl	Add user secrets (#22191)	2 years ago
organization.tmpl	Add context cache as a request level cache (#22294)	2 years ago
packages.tmpl	Add Chef package registry (#22554)	2 years ago
packages_cleanup_rules_edit.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
packages_cleanup_rules_preview.tmpl	Add main landmark to templates and adjust titles (#22670)	2 years ago
profile.tmpl	Add context cache as a request level cache (#22294)	2 years ago
repos.tmpl	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
secrets.tmpl	Add user secrets (#22191)	2 years ago