Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Hester Gong
8120c0c20c
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (#23513)
Close #23466
Right now on pull request "files Changed" tab, if a file is viewed, when
the comments' links are visited, the comment will not be shown as the
file is folded after viewed. This PR is to improve the behavior, to make
the comment seen even the related file is folded, like on github.
And right now scroll position will be remembered and hence it won’t
scroll to hashed comment after refreshing, this PR also adjust the
scroll position remembering behavior: When there is hash comment in url,
do not remember the scroll position.
Before:
https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov
After:
https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov
Update - long comment's behavior after using `scrollTop ` (Comment div
scroll to the position which is 30px below the diff header, or 30px
below top on conversation tab):
https://user-images.githubusercontent.com/17645053/225614460-0602c1a6-229c-41f4-84d2-334e78251486.mov
|
2 years ago |
| .. |
|
components
|
Remove stars in dashboard repo list (#23530)
|
2 years ago |
|
features
|
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (#23513)
|
2 years ago |
|
markup
|
update to mermaid v10 (#23178)
|
2 years ago |
|
modules
|
Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450)
|
2 years ago |
|
standalone
|
…
|
|
|
test
|
…
|
|
|
utils
|
Refactor branch/tag selector to Vue SFC (#23421)
|
2 years ago |
|
webcomponents
|
Add document for `webcomponents` (#23261)
|
2 years ago |
|
bootstrap.js
|
…
|
|
|
index.js
|
Refactor dashboard repo list to Vue SFC (#23405)
|
2 years ago |
|
jquery.js
|
…
|
|
|
serviceworker.js
|
…
|
|
|
svg.js
|
Refactor branch/tag selector to Vue SFC (#23421)
|
2 years ago |
|
svg.test.js
|
…
|
|
|
utils.js
|
…
|
|
|
utils.test.js
|
…
|
|
