Git with a cup of tea, painless self-hosted git service
Mirror for internal git.with.parts use
https://git.with.parts
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Hester Gong
ca905b82df
Append `(comment)` when a link points at a comment rather than the whole issue (#23734)
Close #23671
For the feature mentioned above, this PR append ' (comment)' to the
rendered html if it is a hashcomment.
After the PR, type in the following
```
pull request from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2
pull request from this repo:
http://localhost:3000/aaa/testA/pulls/2
issue comment from this repo:
http://localhost:3000/aaa/testA/issues/1#issuecomment-18
http://localhost:3000/aaa/testA/pulls/2#issue-9
issue comment from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue
```
Gives:
<img width="687" alt="截屏2023-03-27 13 53 06"
src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png">
Other than the above feature, this PR also includes two other changes:
1 Right now, the render of links from file changed tab in pull request
might not be very proper, for example, if type in the following. (not
sure if this is an issue or design, if not an issue, I will revert the
changes). example on
[try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1)
```
https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725
https://try.gitea.io/HesterG/testrepo/pulls/1/files
```
it will render the following
<img width="899" alt="截屏2023-03-24 15 41 37"
src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png">
In this PR, skip processing the link into a ref issue if it is a link
from files changed tab in pull request
After:
type in following
```
hash comment on files changed tab:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24
files changed link:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files
```
Gives
<img width="708" alt="截屏2023-03-27 22 09 02"
src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png">
2 Right now, after editing the comment area, there will not be tippys
attached to `ref-issue`; and no tippy attached on preview as well.
example:
https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov
In this PR, in frontend, make sure tippy is added after editing the
comment, and to the comment on preview tab
After:
https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov
|
2 years ago |
| .. |
|
asciicast
|
Support asciicast files as new markup (#22448)
|
2 years ago |
|
common
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
console
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
|
csv
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
|
external
|
Log STDERR of external renderer when it fails (#22442)
|
2 years ago |
|
markdown
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
|
mdstripper
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
orgmode
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
|
camo.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
camo_test.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
html.go
|
Append `(comment)` when a link points at a comment rather than the whole issue (#23734)
|
2 years ago |
|
html_internal_test.go
|
Append `(comment)` when a link points at a comment rather than the whole issue (#23734)
|
2 years ago |
|
html_test.go
|
Add context when rendering labels or emojis (#23281)
|
2 years ago |
|
renderer.go
|
Editor preview support for external renderers (#23333)
|
2 years ago |
|
renderer_test.go
|
Move `IsReadmeFile*` from `modules/markup/` to `modules/util` (#22877)
|
2 years ago |
|
sanitizer.go
|
Allow `<video>` in MarkDown (#22892)
|
2 years ago |
|
sanitizer_test.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
