Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jack Hay 18de83b2a3 Redesign Scoped Access Tokens (#24767) ... ## Changes - Adds the following high level access scopes, each with `read` and `write` levels: - `activitypub` - `admin` (hidden if user is not a site admin) - `misc` - `notification` - `organization` - `package` - `issue` - `repository` - `user` - Adds new middleware function `tokenRequiresScopes()` in addition to `reqToken()` - `tokenRequiresScopes()` is used for each high-level api section - _if_ a scoped token is present, checks that the required scope is included based on the section and HTTP method - `reqToken()` is used for individual routes - checks that required authentication is present (but does not check scope levels as this will already have been handled by `tokenRequiresScopes()` - Adds migration to convert old scoped access tokens to the new set of scopes - Updates the user interface for scope selection ### User interface example <img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM" src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3"> <img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM" src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c"> ## tokenRequiresScopes Design Decision - `tokenRequiresScopes()` was added to more reliably cover api routes. For an incoming request, this function uses the given scope category (say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say `DELETE`) and verifies that any scoped tokens in use include `delete:organization`. - `reqToken()` is used to enforce auth for individual routes that require it. If a scoped token is not present for a request, `tokenRequiresScopes()` will not return an error ## TODO - [x] Alphabetize scope categories - [x] Change 'public repos only' to a radio button (private vs public). Also expand this to organizations - [X] Disable token creation if no scopes selected. Alternatively, show warning - [x] `reqToken()` is missing from many `POST/DELETE` routes in the api. `tokenRequiresScopes()` only checks that a given token has the correct scope, `reqToken()` must be used to check that a token (or some other auth) is present. - _This should be addressed in this PR_ - [x] The migration should be reviewed very carefully in order to minimize access changes to existing user tokens. - _This should be addressed in this PR_ - [x] Link to api to swagger documentation, clarify what read/write/delete levels correspond to - [x] Review cases where more than one scope is needed as this directly deviates from the api definition. - _This should be addressed in this PR_ - For example: ```go m.Group("/users/{username}/orgs", func() { m.Get("", reqToken(), org.ListUserOrgs) m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions) }, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser, auth_model.AccessTokenScopeCategoryOrganization), context_service.UserAssignmentAPI()) ``` ## Future improvements - [ ] Add required scopes to swagger documentation - [ ] Redesign `reqToken()` to be opt-out rather than opt-in - [ ] Subdivide scopes like `repository` - [ ] Once a token is created, if it has no scopes, we should display text instead of an empty bullet point - [ ] If the 'public repos only' option is selected, should read categories be selected by default Closes #24501 Closes #24799 Co-authored-by: Jonathan Tran <jon@allspice.io> Co-authored-by: Kyle D <kdumontnu@gmail.com> Co-authored-by: silverwind <me@silverwind.io>		1 year ago
..
actions	Add step start time to `ViewStepLog` (#24980)	1 year ago
setting	Add user level action runners (#24995)	1 year ago
activity.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
attachment.go	Fix users cannot visit issue attachment bug (#25019)	1 year ago
blame.go	Sort repo topic labels by name (#24123)	2 years ago
branch.go	Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634)	2 years ago
cherry_pick.go	Rename almost all Ctx functions (#22071)	2 years ago
commit.go	Pass 'not' to commit count (#24473)	2 years ago
compare.go	Don't list root repository on compare page if pulls not allowed (#24183)	2 years ago
download.go	Decouple the different contexts from each other (#24786)	2 years ago
editor.go	API endpoint for changing/creating/deleting multiple files (#24887)	1 year ago
editor_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
find.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
helper.go	Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890)	2 years ago
helper_test.go	Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890)	2 years ago
http.go	Redesign Scoped Access Tokens (#24767)	1 year ago
http_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
issue.go	Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634)	2 years ago
issue_content_history.go	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
issue_dependency.go	Add API to manage issue dependencies (#17935)	2 years ago
issue_label.go	Make label templates have consistent behavior and priority (#23749)	2 years ago
issue_label_test.go	Make label templates have consistent behavior and priority (#23749)	2 years ago
issue_lock.go	Fix improper HTMLURL usages in Go code (#22839)	2 years ago
issue_pin.go	Followup to pinned Issues (#24945)	1 year ago
issue_stopwatch.go	Speed up HasUserStopwatch & GetActiveStopwatch (#23051)	2 years ago
issue_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
issue_timetrack.go	Fix improper HTMLURL usages in Go code (#22839)	2 years ago
issue_watch.go	Rewrite logger system (#24726)	2 years ago
lfs.go	Introduce path Clean/Join helper functions (#23495)	2 years ago
main_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
middlewares.go	Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (#21257)	2 years ago
migrate.go	Make repo migration cancelable and fix various bugs (#24605)	2 years ago
milestone.go	Improve Gitea's web context, decouple "issue template" code into service package (#24590)	2 years ago
packages.go	Use dynamic package type list (#22263)	2 years ago
patch.go	Redirect to the commit page after applying patch (#23056)	2 years ago
projects.go	Merge `new project` templates into one (#24985)	1 year ago
projects_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
pull.go	Add IsErrRepoFilesAlreadyExist check when fork repo (#24678)	2 years ago
pull_review.go	Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245)	2 years ago
release.go	fix: release page for empty or non-existing target (#24470)	2 years ago
release_test.go	fix: release page for empty or non-existing target (#24470)	2 years ago
render.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
repo.go	Remove the parallelizing when loading repo for dashboard (#24705)	2 years ago
search.go	Fix improper HTMLURL usages in Go code (#22839)	2 years ago
setting.go	Hide 'Mirror Settings' when unneeded, improve hints (#24433)	1 year ago
setting_protected_branch.go	Support for status check pattern (#24633)	2 years ago
settings_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
tag.go	Add main landmark to templates and adjust titles (#22670)	2 years ago
topic.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
treelist.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
view.go	Improve Gitea's web context, decouple "issue template" code into service package (#24590)	2 years ago
view_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
webhook.go	New webhook trigger for receiving Pull Request review requests (#24481)	2 years ago
wiki.go	Decouple the different contexts from each other (#24786)	2 years ago
wiki_test.go	Make wiki title supports dashes and improve wiki name related features (#24143)	2 years ago