From 0ae3bbc3f5eda7ccabbd067fc8e361155004748c Mon Sep 17 00:00:00 2001 From: obscuren Date: Fri, 4 Jul 2014 15:53:16 +0200 Subject: [PATCH 01/15] deleted --- ethereal/assets/samplecoin | 1 - 1 file changed, 1 deletion(-) delete mode 160000 ethereal/assets/samplecoin diff --git a/ethereal/assets/samplecoin b/ethereal/assets/samplecoin deleted file mode 160000 index 944fbaa31d..0000000000 --- a/ethereal/assets/samplecoin +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 944fbaa31d51328b522c0cd55113716630b4cbcb From c0ae5c58a6b3d78540ec19b24bd31b6e14e24191 Mon Sep 17 00:00:00 2001 From: Maran Date: Tue, 15 Jul 2014 12:52:30 +0200 Subject: [PATCH 02/15] Rewrote mnemonic word loading to facilitate deployable builds. --- ethereal/flags.go | 31 ++----------------------------- utils/cmd.go | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/ethereal/flags.go b/ethereal/flags.go index d5ca9f336a..c7d330f806 100644 --- a/ethereal/flags.go +++ b/ethereal/flags.go @@ -1,15 +1,13 @@ package main import ( - "bitbucket.org/kardianos/osext" "flag" "fmt" "github.com/ethereum/eth-go/ethlog" + "github.com/ethereum/go-ethereum/utils" "os" "os/user" "path" - "path/filepath" - "runtime" ) var Identifier string @@ -36,31 +34,6 @@ var LogLevel int // flags specific to gui client var AssetPath string -func defaultAssetPath() string { - var assetPath string - // If the current working directory is the go-ethereum dir - // assume a debug build and use the source directory as - // asset directory. - pwd, _ := os.Getwd() - if pwd == path.Join(os.Getenv("GOPATH"), "src", "github.com", "ethereum", "go-ethereum", "ethereal") { - assetPath = path.Join(pwd, "assets") - } else { - switch runtime.GOOS { - case "darwin": - // Get Binary Directory - exedir, _ := osext.ExecutableFolder() - assetPath = filepath.Join(exedir, "../Resources") - case "linux": - assetPath = "/usr/share/ethereal" - case "windows": - assetPath = "./assets" - default: - assetPath = "." - } - } - return assetPath -} - func defaultDataDir() string { usr, _ := user.Current() return path.Join(usr.HomeDir, ".ethereal") @@ -93,7 +66,7 @@ func Init() { flag.StringVar(&DebugFile, "debug", "", "debug file (no debugging if not set)") flag.IntVar(&LogLevel, "loglevel", int(ethlog.InfoLevel), "loglevel: 0-5: silent,error,warn,info,debug,debug detail)") - flag.StringVar(&AssetPath, "asset_path", defaultAssetPath(), "absolute path to GUI assets directory") + flag.StringVar(&AssetPath, "asset_path", utils.DefaultAssetPath(), "absolute path to GUI assets directory") flag.Parse() } diff --git a/utils/cmd.go b/utils/cmd.go index 889726b049..fac164b476 100644 --- a/utils/cmd.go +++ b/utils/cmd.go @@ -1,6 +1,7 @@ package utils import ( + "bitbucket.org/kardianos/osext" "fmt" "github.com/ethereum/eth-go" "github.com/ethereum/eth-go/ethcrypto" @@ -16,6 +17,8 @@ import ( "os" "os/signal" "path" + "path/filepath" + "runtime" "time" ) @@ -164,7 +167,33 @@ func NewKeyManager(KeyStore string, Datadir string, db ethutil.Database) *ethcry return keyManager } +func DefaultAssetPath() string { + var assetPath string + // If the current working directory is the go-ethereum dir + // assume a debug build and use the source directory as + // asset directory. + pwd, _ := os.Getwd() + if pwd == path.Join(os.Getenv("GOPATH"), "src", "github.com", "ethereum", "go-ethereum", "ethereal") { + assetPath = path.Join(pwd, "assets") + } else { + switch runtime.GOOS { + case "darwin": + // Get Binary Directory + exedir, _ := osext.ExecutableFolder() + assetPath = filepath.Join(exedir, "../Resources") + case "linux": + assetPath = "/usr/share/ethereal" + case "windows": + assetPath = "./assets" + default: + assetPath = "." + } + } + return assetPath +} func KeyTasks(keyManager *ethcrypto.KeyManager, KeyRing string, GenAddr bool, SecretFile string, ExportDir string, NonInteractive bool) { + ethcrypto.InitWords(DefaultAssetPath()) // Init mnemonic word list + var err error switch { case GenAddr: From 223432fa1eedb9fa5c712056afb804322aa12b02 Mon Sep 17 00:00:00 2001 From: Maran Date: Tue, 15 Jul 2014 16:21:16 +0200 Subject: [PATCH 03/15] Work around crash issues when building OSX binary --- ethereal/flags.go | 31 +++++++++++++++++++++++++++++-- utils/cmd.go | 1 + 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/ethereal/flags.go b/ethereal/flags.go index c7d330f806..c9327c3d31 100644 --- a/ethereal/flags.go +++ b/ethereal/flags.go @@ -1,13 +1,15 @@ package main import ( + "bitbucket.org/kardianos/osext" "flag" "fmt" "github.com/ethereum/eth-go/ethlog" - "github.com/ethereum/go-ethereum/utils" "os" "os/user" "path" + "path/filepath" + "runtime" ) var Identifier string @@ -34,6 +36,31 @@ var LogLevel int // flags specific to gui client var AssetPath string +//TODO: If we re-use the one defined in cmd.go the binary osx image crashes. If somebody finds out why we can dry this up. +func defaultAssetPath() string { + var assetPath string + // If the current working directory is the go-ethereum dir + // assume a debug build and use the source directory as + // asset directory. + pwd, _ := os.Getwd() + if pwd == path.Join(os.Getenv("GOPATH"), "src", "github.com", "ethereum", "go-ethereum", "ethereal") { + assetPath = path.Join(pwd, "assets") + } else { + switch runtime.GOOS { + case "darwin": + // Get Binary Directory + exedir, _ := osext.ExecutableFolder() + assetPath = filepath.Join(exedir, "../Resources") + case "linux": + assetPath = "/usr/share/ethereal" + case "windows": + assetPath = "./assets" + default: + assetPath = "." + } + } + return assetPath +} func defaultDataDir() string { usr, _ := user.Current() return path.Join(usr.HomeDir, ".ethereal") @@ -66,7 +93,7 @@ func Init() { flag.StringVar(&DebugFile, "debug", "", "debug file (no debugging if not set)") flag.IntVar(&LogLevel, "loglevel", int(ethlog.InfoLevel), "loglevel: 0-5: silent,error,warn,info,debug,debug detail)") - flag.StringVar(&AssetPath, "asset_path", utils.DefaultAssetPath(), "absolute path to GUI assets directory") + flag.StringVar(&AssetPath, "asset_path", defaultAssetPath(), "absolute path to GUI assets directory") flag.Parse() } diff --git a/utils/cmd.go b/utils/cmd.go index fac164b476..1e15995820 100644 --- a/utils/cmd.go +++ b/utils/cmd.go @@ -191,6 +191,7 @@ func DefaultAssetPath() string { } return assetPath } + func KeyTasks(keyManager *ethcrypto.KeyManager, KeyRing string, GenAddr bool, SecretFile string, ExportDir string, NonInteractive bool) { ethcrypto.InitWords(DefaultAssetPath()) // Init mnemonic word list From 28948d061cfc14d7a5da307a12ebd504b78d2dbb Mon Sep 17 00:00:00 2001 From: obscuren Date: Tue, 15 Jul 2014 20:34:25 +0200 Subject: [PATCH 04/15] Moved the repl to a new package --- ethereum/cmd.go | 5 +- ethereum/flags.go | 2 + ethereum/main.go | 1 + ethereum/{ => repl}/javascript_runtime.go | 2 +- ethereum/{ => repl}/js_lib.go | 2 +- ethereum/repl/repl.go | 83 +++++++++++++++++++++++ ethereum/{ => repl}/repl_darwin.go | 2 +- ethereum/{ => repl}/repl_linux.go | 0 ethereum/{ => repl}/repl_windows.go | 2 +- ethereum/{repl.go => repl/types.go} | 82 ++++------------------ 10 files changed, 105 insertions(+), 76 deletions(-) rename ethereum/{ => repl}/javascript_runtime.go (99%) rename ethereum/{ => repl}/js_lib.go (98%) create mode 100644 ethereum/repl/repl.go rename ethereum/{ => repl}/repl_darwin.go (99%) rename ethereum/{ => repl}/repl_linux.go (100%) rename ethereum/{ => repl}/repl_windows.go (95%) rename ethereum/{repl.go => repl/types.go} (57%) diff --git a/ethereum/cmd.go b/ethereum/cmd.go index 08147824dc..ff2b8409cf 100644 --- a/ethereum/cmd.go +++ b/ethereum/cmd.go @@ -2,13 +2,14 @@ package main import ( "github.com/ethereum/eth-go" + "github.com/ethereum/go-ethereum/ethereum/repl" "github.com/ethereum/go-ethereum/utils" "io/ioutil" "os" ) func InitJsConsole(ethereum *eth.Ethereum) { - repl := NewJSRepl(ethereum) + repl := ethrepl.NewJSRepl(ethereum) go repl.Start() utils.RegisterInterrupt(func(os.Signal) { repl.Stop() @@ -24,7 +25,7 @@ func ExecJsFile(ethereum *eth.Ethereum, InputFile string) { if err != nil { logger.Fatalln(err) } - re := NewJSRE(ethereum) + re := ethrepl.NewJSRE(ethereum) utils.RegisterInterrupt(func(os.Signal) { re.Stop() }) diff --git a/ethereum/flags.go b/ethereum/flags.go index af0fd9a698..4f59ddf060 100644 --- a/ethereum/flags.go +++ b/ethereum/flags.go @@ -12,6 +12,7 @@ import ( var Identifier string var KeyRing string var DiffTool bool +var DiffType string var KeyStore string var StartRpc bool var RpcPort int @@ -68,6 +69,7 @@ func Init() { flag.StringVar(&DebugFile, "debug", "", "debug file (no debugging if not set)") flag.IntVar(&LogLevel, "loglevel", int(ethlog.InfoLevel), "loglevel: 0-5: silent,error,warn,info,debug,debug detail)") flag.BoolVar(&DiffTool, "difftool", false, "creates output for diff'ing. Sets LogLevel=0") + flag.StringVar(&DiffType, "diff", "all", "sets the level of diff output [vm, all]. Has no effect if difftool=false") flag.BoolVar(&StartMining, "mine", false, "start dagger mining") flag.BoolVar(&StartJsConsole, "js", false, "launches javascript console") diff --git a/ethereum/main.go b/ethereum/main.go index 39226c1d2b..fd4a89aa9f 100644 --- a/ethereum/main.go +++ b/ethereum/main.go @@ -29,6 +29,7 @@ func main() { utils.InitConfig(ConfigFile, Datadir, "ETH") ethutil.Config.Diff = DiffTool + ethutil.Config.DiffType = DiffType utils.InitDataDir(Datadir) diff --git a/ethereum/javascript_runtime.go b/ethereum/repl/javascript_runtime.go similarity index 99% rename from ethereum/javascript_runtime.go rename to ethereum/repl/javascript_runtime.go index 852a504879..cd87f98687 100644 --- a/ethereum/javascript_runtime.go +++ b/ethereum/repl/javascript_runtime.go @@ -1,4 +1,4 @@ -package main +package ethrepl import ( "fmt" diff --git a/ethereum/js_lib.go b/ethereum/repl/js_lib.go similarity index 98% rename from ethereum/js_lib.go rename to ethereum/repl/js_lib.go index 189dcc3a0b..c781c43d0c 100644 --- a/ethereum/js_lib.go +++ b/ethereum/repl/js_lib.go @@ -1,4 +1,4 @@ -package main +package ethrepl const jsLib = ` function pp(object) { diff --git a/ethereum/repl/repl.go b/ethereum/repl/repl.go new file mode 100644 index 0000000000..92d4ad86a3 --- /dev/null +++ b/ethereum/repl/repl.go @@ -0,0 +1,83 @@ +package ethrepl + +import ( + "bufio" + "fmt" + "github.com/ethereum/eth-go" + "github.com/ethereum/eth-go/ethlog" + "github.com/ethereum/eth-go/ethutil" + "io" + "os" + "path" +) + +var logger = ethlog.NewLogger("REPL") + +type Repl interface { + Start() + Stop() +} + +type JSRepl struct { + re *JSRE + + prompt string + + history *os.File + + running bool +} + +func NewJSRepl(ethereum *eth.Ethereum) *JSRepl { + hist, err := os.OpenFile(path.Join(ethutil.Config.ExecPath, "history"), os.O_RDWR|os.O_CREATE, os.ModePerm) + if err != nil { + panic(err) + } + + return &JSRepl{re: NewJSRE(ethereum), prompt: "> ", history: hist} +} + +func (self *JSRepl) Start() { + if !self.running { + self.running = true + logger.Infoln("init JS Console") + reader := bufio.NewReader(self.history) + for { + line, err := reader.ReadString('\n') + if err != nil && err == io.EOF { + break + } else if err != nil { + fmt.Println("error reading history", err) + break + } + + addHistory(line[:len(line)-1]) + } + self.read() + } +} + +func (self *JSRepl) Stop() { + if self.running { + self.running = false + self.re.Stop() + logger.Infoln("exit JS Console") + self.history.Close() + } +} + +func (self *JSRepl) parseInput(code string) { + defer func() { + if r := recover(); r != nil { + fmt.Println("[native] error", r) + } + }() + + value, err := self.re.Run(code) + if err != nil { + fmt.Println(err) + return + } + + self.PrintValue(value) +} diff --git a/ethereum/repl_darwin.go b/ethereum/repl/repl_darwin.go similarity index 99% rename from ethereum/repl_darwin.go rename to ethereum/repl/repl_darwin.go index 62b40059ac..3a91b0d442 100644 --- a/ethereum/repl_darwin.go +++ b/ethereum/repl/repl_darwin.go @@ -1,4 +1,4 @@ -package main +package ethrepl // #cgo darwin CFLAGS: -I/usr/local/opt/readline/include // #cgo darwin LDFLAGS: -L/usr/local/opt/readline/lib diff --git a/ethereum/repl_linux.go b/ethereum/repl/repl_linux.go similarity index 100% rename from ethereum/repl_linux.go rename to ethereum/repl/repl_linux.go diff --git a/ethereum/repl_windows.go b/ethereum/repl/repl_windows.go similarity index 95% rename from ethereum/repl_windows.go rename to ethereum/repl/repl_windows.go index 9d4787772f..4106c89bc3 100644 --- a/ethereum/repl_windows.go +++ b/ethereum/repl/repl_windows.go @@ -1,4 +1,4 @@ -package main +package ethrepl import ( "bufio" diff --git a/ethereum/repl.go b/ethereum/repl/types.go similarity index 57% rename from ethereum/repl.go rename to ethereum/repl/types.go index 34380a06f4..16a18e6e5d 100644 --- a/ethereum/repl.go +++ b/ethereum/repl/types.go @@ -1,84 +1,26 @@ -package main +package ethrepl import ( - "bufio" "fmt" - "github.com/ethereum/eth-go" "github.com/ethereum/eth-go/ethpub" "github.com/ethereum/eth-go/ethutil" "github.com/obscuren/otto" - "io" - "os" - "path" ) -type Repl interface { - Start() - Stop() -} - -type JSRepl struct { - re *JSRE - - prompt string - - history *os.File - - running bool -} - -func NewJSRepl(ethereum *eth.Ethereum) *JSRepl { - hist, err := os.OpenFile(path.Join(ethutil.Config.ExecPath, "history"), os.O_RDWR|os.O_CREATE, os.ModePerm) - if err != nil { - panic(err) - } - - return &JSRepl{re: NewJSRE(ethereum), prompt: "> ", history: hist} -} - -func (self *JSRepl) Start() { - if !self.running { - self.running = true - logger.Infoln("init JS Console") - reader := bufio.NewReader(self.history) - for { - line, err := reader.ReadString('\n') - if err != nil && err == io.EOF { - break - } else if err != nil { - fmt.Println("error reading history", err) - break - } - - addHistory(line[:len(line)-1]) - } - self.read() - } -} - -func (self *JSRepl) Stop() { - if self.running { - self.running = false - self.re.Stop() - logger.Infoln("exit JS Console") - self.history.Close() - } +type JSStateObject struct { + *ethpub.PStateObject + eth *JSEthereum } -func (self *JSRepl) parseInput(code string) { - defer func() { - if r := recover(); r != nil { - fmt.Println("[native] error", r) - } - }() +func (self *JSStateObject) EachStorage(call otto.FunctionCall) otto.Value { + cb := call.Argument(0) + self.PStateObject.EachStorage(func(key string, value *ethutil.Value) { + value.Decode() - value, err := self.re.Run(code) - if err != nil { - fmt.Println(err) - return - } + cb.Call(self.eth.toVal(self), self.eth.toVal(key), self.eth.toVal(ethutil.Bytes2Hex(value.Bytes()))) + }) - self.PrintValue(value) + return otto.UndefinedValue() } // The JSEthereum object attempts to wrap the PEthereum object and returns @@ -110,7 +52,7 @@ func (self *JSEthereum) GetKey() otto.Value { } func (self *JSEthereum) GetStateObject(addr string) otto.Value { - return self.toVal(self.PEthereum.GetStateObject(addr)) + return self.toVal(&JSStateObject{self.PEthereum.GetStateObject(addr), self}) } func (self *JSEthereum) GetStateKeyVals(addr string) otto.Value { From 7d64b589b4cf3f71125d5bd0f0a8f6a560e909db Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 15:02:25 +0200 Subject: [PATCH 05/15] h scroll --- ethereal/assets/debugger/debugger.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ethereal/assets/debugger/debugger.qml b/ethereal/assets/debugger/debugger.qml index fa56737a22..34fe01253d 100644 --- a/ethereal/assets/debugger/debugger.qml +++ b/ethereal/assets/debugger/debugger.qml @@ -86,7 +86,7 @@ ApplicationWindow { TableView { id: asmTableView width: 200 - TableViewColumn{ role: "value" ; title: "" ; width: 200 } + TableViewColumn{ role: "value" ; title: "" ; width: asmTableView.width - 2 } model: asmModel } From 6c565eae74b1e1a8175f12fd0e26b70e0ad730c1 Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 15:36:16 +0200 Subject: [PATCH 06/15] bump --- README.md | 2 +- ethereal/main.go | 2 +- ethereum/main.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 11b7ed7e94..29dae73418 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ Ethereum Ethereum Go Client © 2014 Jeffrey Wilcke. -Current state: Proof of Concept 0.5.16. +Current state: Proof of Concept 0.5.17. For the development package please see the [eth-go package](https://github.com/ethereum/eth-go). diff --git a/ethereal/main.go b/ethereal/main.go index 645e8f2ce5..e1cd43acec 100644 --- a/ethereal/main.go +++ b/ethereal/main.go @@ -10,7 +10,7 @@ import ( const ( ClientIdentifier = "Ethereal" - Version = "0.5.16" + Version = "0.5.17" ) func main() { diff --git a/ethereum/main.go b/ethereum/main.go index fd4a89aa9f..b670cb495b 100644 --- a/ethereum/main.go +++ b/ethereum/main.go @@ -9,7 +9,7 @@ import ( const ( ClientIdentifier = "Ethereum(G)" - Version = "0.5.16" + Version = "0.5.17" ) var logger = ethlog.NewLogger("CLI") From edf10ef8c5908ffdc787dc9457da6d735212423d Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 17:10:35 +0200 Subject: [PATCH 07/15] Fixed name reg --- ethereal/gui.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ethereal/gui.go b/ethereal/gui.go index 9f28045f86..39677c38fd 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -356,7 +356,7 @@ func (gui *Gui) address() []byte { } func (gui *Gui) RegisterName(name string) { - name = fmt.Sprintf("\"%s\"", name) + name = fmt.Sprintf("\"register\"\n\"%s\"", name) gui.pub.Transact(gui.privateKey(), "NameReg", "", "10000", "10000000000000", name) } From ba3fabda774cc3f0c12542985c7ff252abc034da Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 22:01:39 +0200 Subject: [PATCH 08/15] Added a catch up indicator --- ethereal/assets/qml/wallet.qml | 14 ++++++++++++++ ethereal/gui.go | 17 +++++++++++++---- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/ethereal/assets/qml/wallet.qml b/ethereal/assets/qml/wallet.qml index c783cde830..afb210bec9 100644 --- a/ethereal/assets/qml/wallet.qml +++ b/ethereal/assets/qml/wallet.qml @@ -419,6 +419,17 @@ ApplicationWindow { } } + ProgressBar { + id: syncProgressIndicator + visible: false + objectName: "syncProgressIndicator" + y: 3 + width: 140 + indeterminate: true + anchors.right: peerLabel.left + anchors.rightMargin: 5 + } + Label { y: 7 anchors.right: peerImage.left @@ -443,6 +454,7 @@ ApplicationWindow { Window { id: popup visible: false + flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint property var block width: root.width height: 300 @@ -577,6 +589,7 @@ ApplicationWindow { Window { id: addPeerWin + flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint visible: false minimumWidth: 230 maximumWidth: 230 @@ -743,6 +756,7 @@ ApplicationWindow { // ****************************************** Window { id: peerWindow + flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint height: 200 width: 700 Rectangle { diff --git a/ethereal/gui.go b/ethereal/gui.go index 39677c38fd..f777f64f7e 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -266,14 +266,18 @@ func (gui *Gui) setWalletValue(amount, unconfirmedFunds *big.Int) { func (gui *Gui) update() { reactor := gui.eth.Reactor() - blockChan := make(chan ethutil.React, 1) - txChan := make(chan ethutil.React, 1) - objectChan := make(chan ethutil.React, 1) - peerChan := make(chan ethutil.React, 1) + var ( + blockChan = make(chan ethutil.React, 1) + txChan = make(chan ethutil.React, 1) + objectChan = make(chan ethutil.React, 1) + peerChan = make(chan ethutil.React, 1) + chainSyncChan = make(chan ethutil.React, 1) + ) reactor.Subscribe("newBlock", blockChan) reactor.Subscribe("newTx:pre", txChan) reactor.Subscribe("newTx:post", txChan) + reactor.Subscribe("chainSync", chainSyncChan) nameReg := ethpub.EthereumConfig(gui.eth.StateManager()).NameReg() if nameReg != nil { @@ -287,6 +291,7 @@ func (gui *Gui) update() { unconfirmedFunds := new(big.Int) gui.win.Root().Call("setWalletValue", fmt.Sprintf("%v", ethutil.CurrencyToString(state.GetAccount(gui.address()).Amount))) + gui.win.Root().ObjectByName("syncProgressIndicator").Set("visible", !gui.eth.IsUpToDate()) for { select { @@ -328,6 +333,10 @@ func (gui *Gui) update() { state.UpdateStateObject(object) } + case msg := <-chainSyncChan: + sync := msg.Resource.(bool) + gui.win.Root().ObjectByName("syncProgressIndicator").Set("visible", sync) + case <-objectChan: gui.loadAddressBook() case <-peerChan: From 01d9107bce356e4de94b9506246672d003948203 Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 22:30:17 +0200 Subject: [PATCH 09/15] Add namecoin name if available to block --- ethereal/assets/qml/wallet.qml | 6 +++--- ethereal/gui.go | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ethereal/assets/qml/wallet.qml b/ethereal/assets/qml/wallet.qml index afb210bec9..a9e3093563 100644 --- a/ethereal/assets/qml/wallet.qml +++ b/ethereal/assets/qml/wallet.qml @@ -472,7 +472,7 @@ ApplicationWindow { Text { text: '

Block details

'; color: "#F2F2F2"} Text { text: 'Block number: ' + number; color: "#F2F2F2"} Text { text: 'Hash: ' + hash; color: "#F2F2F2"} - Text { text: 'Coinbase: ' + coinbase; color: "#F2F2F2"} + Text { text: 'Coinbase: <' + name + '> ' + coinbase; color: "#F2F2F2"} Text { text: 'Block found at: ' + prettyTime; color: "#F2F2F2"} Text { text: 'Gas used: ' + gasUsed + " / " + gasLimit; color: "#F2F2F2"} } @@ -699,9 +699,9 @@ ApplicationWindow { } if(initial){ - blockModel.append({number: block.number, gasLimit: block.gasLimit, gasUsed: block.gasUsed, coinbase: block.coinbase, hash: block.hash, txs: txs, txAmount: amount, time: block.time, prettyTime: convertToPretty(block.time)}) + blockModel.append({number: block.number, name: block.name, gasLimit: block.gasLimit, gasUsed: block.gasUsed, coinbase: block.coinbase, hash: block.hash, txs: txs, txAmount: amount, time: block.time, prettyTime: convertToPretty(block.time)}) }else{ - blockModel.insert(0, {number: block.number, gasLimit: block.gasLimit, gasUsed: block.gasUsed, coinbase: block.coinbase, hash: block.hash, txs: txs, txAmount: amount, time: block.time, prettyTime: convertToPretty(block.time)}) + blockModel.insert(0, {number: block.number, name: block.name, gasLimit: block.gasLimit, gasUsed: block.gasUsed, coinbase: block.coinbase, hash: block.hash, txs: txs, txAmount: amount, time: block.time, prettyTime: convertToPretty(block.time)}) } } diff --git a/ethereal/gui.go b/ethereal/gui.go index f777f64f7e..9a65ff3d07 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -243,7 +243,11 @@ func (gui *Gui) readPreviousTransactions() { } func (gui *Gui) processBlock(block *ethchain.Block, initial bool) { - gui.win.Root().Call("addBlock", ethpub.NewPBlock(block), initial) + name := ethpub.FindNameInNameReg(gui.eth.StateManager(), block.Coinbase) + b := ethpub.NewPBlock(block) + b.Name = name + + gui.win.Root().Call("addBlock", b, initial) } func (gui *Gui) setWalletValue(amount, unconfirmedFunds *big.Int) { From 44296c0b33de5f6c2ff28c6a0fd528d6ccd04dec Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 17 Jul 2014 23:17:10 +0200 Subject: [PATCH 10/15] html tags not allowed --- ethereal/assets/qml/wallet.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ethereal/assets/qml/wallet.qml b/ethereal/assets/qml/wallet.qml index a9e3093563..592698d8e5 100644 --- a/ethereal/assets/qml/wallet.qml +++ b/ethereal/assets/qml/wallet.qml @@ -472,7 +472,7 @@ ApplicationWindow { Text { text: '

Block details

'; color: "#F2F2F2"} Text { text: 'Block number: ' + number; color: "#F2F2F2"} Text { text: 'Hash: ' + hash; color: "#F2F2F2"} - Text { text: 'Coinbase: <' + name + '> ' + coinbase; color: "#F2F2F2"} + Text { text: 'Coinbase: <' + name + '> ' + coinbase; color: "#F2F2F2"} Text { text: 'Block found at: ' + prettyTime; color: "#F2F2F2"} Text { text: 'Gas used: ' + gasUsed + " / " + gasLimit; color: "#F2F2F2"} } From 34e2ab9f9fac7067fa4a4dbe6170283f1d9c682a Mon Sep 17 00:00:00 2001 From: obscuren Date: Fri, 18 Jul 2014 11:57:58 +0200 Subject: [PATCH 11/15] Added block update --- ethereal/assets/qml/wallet.qml | 52 +++++++++++++++++++++------------- ethereal/debugger.go | 3 ++ ethereal/gui.go | 15 ++++++++-- 3 files changed, 47 insertions(+), 23 deletions(-) diff --git a/ethereal/assets/qml/wallet.qml b/ethereal/assets/qml/wallet.qml index 592698d8e5..bb1f60260d 100644 --- a/ethereal/assets/qml/wallet.qml +++ b/ethereal/assets/qml/wallet.qml @@ -419,6 +419,17 @@ ApplicationWindow { } } + Label { + y: 6 + id: lastBlockLabel + objectName: "lastBlockLabel" + visible: true + text: "" + font.pixelSize: 10 + anchors.right: peerGroup.left + anchors.rightMargin: 5 + } + ProgressBar { id: syncProgressIndicator visible: false @@ -426,29 +437,30 @@ ApplicationWindow { y: 3 width: 140 indeterminate: true - anchors.right: peerLabel.left + anchors.right: peerGroup.left anchors.rightMargin: 5 } - Label { - y: 7 - anchors.right: peerImage.left - anchors.rightMargin: 5 - id: peerLabel - font.pixelSize: 8 - text: "0 / 0" - } - Image { - y: 7 - id: peerImage - anchors.right: parent.right - width: 10; height: 10 - MouseArea { - onDoubleClicked: peerWindow.visible = true - anchors.fill: parent - } - source: "../network.png" - } + RowLayout { + id: peerGroup + y: 7 + anchors.right: parent.right + MouseArea { + onDoubleClicked: peerWindow.visible = true + anchors.fill: parent + } + + Label { + id: peerLabel + font.pixelSize: 8 + text: "0 / 0" + } + Image { + id: peerImage + width: 10; height: 10 + source: "../network.png" + } + } } Window { diff --git a/ethereal/debugger.go b/ethereal/debugger.go index 997c2e8dd2..7742b16271 100644 --- a/ethereal/debugger.go +++ b/ethereal/debugger.go @@ -17,6 +17,8 @@ type DebuggerWindow struct { vm *ethchain.Vm Db *Debugger + + state *ethchain.State } func NewDebuggerWindow(lib *UiLib) *DebuggerWindow { @@ -53,6 +55,7 @@ func (self *DebuggerWindow) SetCode(code string) { func (self *DebuggerWindow) SetData(data string) { self.win.Set("dataText", data) } + func (self *DebuggerWindow) SetAsm(data []byte) { self.win.Root().Call("clearAsm") diff --git a/ethereal/gui.go b/ethereal/gui.go index 9a65ff3d07..ad701a584b 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -266,6 +266,10 @@ func (gui *Gui) setWalletValue(amount, unconfirmedFunds *big.Int) { gui.win.Root().Call("setWalletValue", str) } +func (self *Gui) getObjectByName(objectName string) qml.Object { + return self.win.Root().ObjectByName(objectName) +} + // Simple go routine function that updates the list of peers in the GUI func (gui *Gui) update() { reactor := gui.eth.Reactor() @@ -289,13 +293,16 @@ func (gui *Gui) update() { } reactor.Subscribe("peerList", peerChan) - ticker := time.NewTicker(5 * time.Second) + peerUpdateTicker := time.NewTicker(5 * time.Second) + generalUpdateTicker := time.NewTicker(1 * time.Second) state := gui.eth.StateManager().TransState() unconfirmedFunds := new(big.Int) gui.win.Root().Call("setWalletValue", fmt.Sprintf("%v", ethutil.CurrencyToString(state.GetAccount(gui.address()).Amount))) - gui.win.Root().ObjectByName("syncProgressIndicator").Set("visible", !gui.eth.IsUpToDate()) + gui.getObjectByName("syncProgressIndicator").Set("visible", !gui.eth.IsUpToDate()) + + lastBlockLabel := gui.getObjectByName("lastBlockLabel") for { select { @@ -345,8 +352,10 @@ func (gui *Gui) update() { gui.loadAddressBook() case <-peerChan: gui.setPeerInfo() - case <-ticker.C: + case <-peerUpdateTicker.C: gui.setPeerInfo() + case <-generalUpdateTicker.C: + lastBlockLabel.Set("text", "#"+gui.eth.BlockChain().CurrentBlock.Number.String()) } } } From 2b9f16802d22b8d743797aecc9bd040a38d6f1f4 Mon Sep 17 00:00:00 2001 From: Maran Date: Fri, 18 Jul 2014 12:01:26 +0200 Subject: [PATCH 12/15] WIP to expose hashrate to gui --- ethereal/gui.go | 8 ++++++++ utils/cmd.go | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/ethereal/gui.go b/ethereal/gui.go index 9a65ff3d07..8047db63e3 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -7,6 +7,7 @@ import ( "github.com/ethereum/eth-go/ethchain" "github.com/ethereum/eth-go/ethdb" "github.com/ethereum/eth-go/ethlog" + "github.com/ethereum/eth-go/ethminer" "github.com/ethereum/eth-go/ethpub" "github.com/ethereum/eth-go/ethutil" "github.com/ethereum/eth-go/ethwire" @@ -40,6 +41,8 @@ type Gui struct { Session string clientIdentity *ethwire.SimpleClientIdentity config *ethutil.ConfigManager + + miner *ethminer.Miner } // Create GUI, but doesn't start it @@ -124,6 +127,7 @@ func (gui *Gui) ToggleMining() { txt = "Start mining" } else { utils.StartMining(gui.eth) + gui.miner = utils.GetMiner() txt = "Stop mining" } @@ -346,6 +350,10 @@ func (gui *Gui) update() { case <-peerChan: gui.setPeerInfo() case <-ticker.C: + if gui.miner != nil { + pow := gui.miner.GetPow() + fmt.Println("HashRate from miner", pow.GetHashrate()) + } gui.setPeerInfo() } } diff --git a/utils/cmd.go b/utils/cmd.go index 1e15995820..638114bbe3 100644 --- a/utils/cmd.go +++ b/utils/cmd.go @@ -236,6 +236,10 @@ func StartRpc(ethereum *eth.Ethereum, RpcPort int) { var miner ethminer.Miner +func GetMiner() *ethminer.Miner { + return &miner +} + func StartMining(ethereum *eth.Ethereum) bool { if !ethereum.Mining { ethereum.Mining = true From 4572d4940c5b027918364e0600fc88a50f73ed16 Mon Sep 17 00:00:00 2001 From: obscuren Date: Fri, 18 Jul 2014 12:02:45 +0200 Subject: [PATCH 13/15] Windows don't like dem flags --- ethereal/assets/qml/wallet.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ethereal/assets/qml/wallet.qml b/ethereal/assets/qml/wallet.qml index bb1f60260d..a79e4708c1 100644 --- a/ethereal/assets/qml/wallet.qml +++ b/ethereal/assets/qml/wallet.qml @@ -466,7 +466,7 @@ ApplicationWindow { Window { id: popup visible: false - flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint + //flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint property var block width: root.width height: 300 @@ -601,7 +601,7 @@ ApplicationWindow { Window { id: addPeerWin - flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint + //flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint visible: false minimumWidth: 230 maximumWidth: 230 @@ -768,7 +768,7 @@ ApplicationWindow { // ****************************************** Window { id: peerWindow - flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint + //flags: Qt.CustomizeWindowHint | Qt.Tool | Qt.WindowCloseButtonHint height: 200 width: 700 Rectangle { From 0c5a747ef1e9f64f7c5627256b87ed47d23438db Mon Sep 17 00:00:00 2001 From: Maran Date: Fri, 18 Jul 2014 12:29:14 +0200 Subject: [PATCH 14/15] Add mining hash to GUI --- ethereal/gui.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ethereal/gui.go b/ethereal/gui.go index cfe5e2269a..d816a774fa 100644 --- a/ethereal/gui.go +++ b/ethereal/gui.go @@ -14,6 +14,7 @@ import ( "github.com/ethereum/go-ethereum/utils" "github.com/go-qml/qml" "math/big" + "strconv" "strings" "time" ) @@ -369,11 +370,14 @@ func (gui *Gui) update() { } case <-generalUpdateTicker.C: + statusText := "#" + gui.eth.BlockChain().CurrentBlock.Number.String() if gui.miner != nil { pow := gui.miner.GetPow() - fmt.Println("HashRate from miner", pow.GetHashrate()) + if pow.GetHashrate() != 0 { + statusText = "Mining @ " + strconv.FormatInt(pow.GetHashrate(), 10) + "Khash - " + statusText + } } - lastBlockLabel.Set("text", "#"+gui.eth.BlockChain().CurrentBlock.Number.String()) + lastBlockLabel.Set("text", statusText) } } } From f702e27485981562ed7b88ecd3f8485af4c61b62 Mon Sep 17 00:00:00 2001 From: obscuren Date: Fri, 18 Jul 2014 13:49:52 +0200 Subject: [PATCH 15/15] Fixed miner stopping / starting:wq --- utils/cmd.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utils/cmd.go b/utils/cmd.go index f4d613c294..5d0b3463c5 100644 --- a/utils/cmd.go +++ b/utils/cmd.go @@ -247,7 +247,10 @@ func StartMining(ethereum *eth.Ethereum) bool { addr := ethereum.KeyManager().Address() go func() { - miner = ethminer.NewDefaultMiner(addr, ethereum) + if miner == nil { + miner = ethminer.NewDefaultMiner(addr, ethereum) + } + // Give it some time to connect with peers time.Sleep(3 * time.Second) for !ethereum.IsUpToDate() { @@ -255,7 +258,6 @@ func StartMining(ethereum *eth.Ethereum) bool { } logger.Infoln("Miner started") - miner := ethminer.NewDefaultMiner(addr, ethereum) miner.Start() }() RegisterInterrupt(func(os.Signal) { @@ -269,10 +271,14 @@ func StartMining(ethereum *eth.Ethereum) bool { func StopMining(ethereum *eth.Ethereum) bool { if ethereum.Mining && miner != nil { miner.Stop() + logger.Infoln("Miner stopped") + ethereum.Mining = false + return true } + return false }