eth/downloader: test registration rejection on head ban

eth/downloader/downloader_test.go

@@ -169,8 +169,9 @@ func (dl *downloadTester) getBlocks(id string) func([]common.Hash) error {
 	}
 }
 
-func (dl *downloadTester) newPeer(id string, td *big.Int, hash common.Hash) {
+// newPeer registers a new block download source into the syncer.
-	dl.downloader.RegisterPeer(id, hash, dl.getHashes, dl.getBlocks(id))
+func (dl *downloadTester) newPeer(id string, td *big.Int, hash common.Hash) error {
+	return dl.downloader.RegisterPeer(id, hash, dl.getHashes, dl.getBlocks(id))
 }
 
 // Tests that simple synchronization, without throttling from a good peer works.
@@ -559,6 +560,13 @@ func TestBannedChainStarvationAttack(t *testing.T) {
 		}
 		banned = bans
 	}
+	// Check that after banning an entire chain, bad peers get dropped
+	if err := tester.newPeer("new attacker", big.NewInt(10000), hashes[0]); err != errBannedHead {
+		t.Fatalf("peer registration mismatch: have %v, want %v", err, errBannedHead)
+	}
+	if peer := tester.downloader.peers.Peer("net attacker"); peer != nil {
+		t.Fatalf("banned attacker registered: %v", peer)
+	}
 }
 
 // Tests that if a peer sends excessively many/large invalid chains that are