From 62236dd95e6d069b8bd9895c9998676b8d946d37 Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 19 Mar 2015 23:20:41 +0100 Subject: [PATCH] copy over loop --- common/types.go | 11 ++--------- core/types/common.go | 7 ++----- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/common/types.go b/common/types.go index 38044d5c84..daefcde11e 100644 --- a/common/types.go +++ b/common/types.go @@ -35,10 +35,7 @@ func (h *Hash) SetBytes(b []byte) { b = b[len(b)-hashLength:] } - // reverse loop - for i := len(b) - 1; i >= 0; i-- { - h[hashLength-len(b)+i] = b[i] - } + copy(h[hashLength-len(b):], b) } // Set string `s` to h. If s is larger than len(h) it will panic @@ -73,11 +70,7 @@ func (a *Address) SetBytes(b []byte) { if len(b) > len(a) { b = b[len(b)-addressLength:] } - - // reverse loop - for i := len(b) - 1; i >= 0; i-- { - a[addressLength-len(b)+i] = b[i] - } + copy(a[addressLength-len(b):], b) } // Set string `s` to a. If s is larger than len(a) it will panic diff --git a/core/types/common.go b/core/types/common.go index 4e885c4c6b..ce1090919b 100644 --- a/core/types/common.go +++ b/core/types/common.go @@ -3,8 +3,8 @@ package types import ( "math/big" - "github.com/ethereum/go-ethereum/state" "github.com/ethereum/go-ethereum/common" + "github.com/ethereum/go-ethereum/state" "fmt" ) @@ -28,10 +28,7 @@ func (b *Bloom) SetBytes(d []byte) { panic(fmt.Sprintf("bloom bytes too big %d %d", len(b), len(d))) } - // reverse loop - for i := len(d) - 1; i >= 0; i-- { - b[bloomLength-len(d)+i] = b[i] - } + copy(b[bloomLength-len(d):], d) } func (b Bloom) Big() *big.Int {