From c599b78f62cda1ab91117b966f88f79fe4778f4f Mon Sep 17 00:00:00 2001 From: Jim McDonald Date: Wed, 11 Oct 2017 11:35:44 +0100 Subject: [PATCH] core/types: fix test for TransactionsByPriceAndNonce --- core/types/transaction_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/core/types/transaction_test.go b/core/types/transaction_test.go index 30ecb84ddb..82d74e3b34 100644 --- a/core/types/transaction_test.go +++ b/core/types/transaction_test.go @@ -147,12 +147,12 @@ func TestTransactionPriceNonceSort(t *testing.T) { txset := NewTransactionsByPriceAndNonce(signer, groups) txs := Transactions{} - for { - if tx := txset.Peek(); tx != nil { - txs = append(txs, tx) - txset.Shift() - } - break + for tx := txset.Peek(); tx != nil; tx = txset.Peek() { + txs = append(txs, tx) + txset.Shift() + } + if len(txs) != 25*25 { + t.Errorf("expected %d transactions, found %d", 25*25, len(txs)) } for i, txi := range txs { fromi, _ := Sender(signer, txi)