Merge pull request #21433 from holiman/statsync_exiter

eth/downloader: allow all timers to exit
pull/21434/head
Péter Szilágyi 4 years ago committed by GitHub
commit cbbc54c495
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      eth/downloader/statesync.go

@ -200,12 +200,7 @@ func (d *Downloader) runStateSync(s *stateSync) *stateSync {
}
// Start a timer to notify the sync loop if the peer stalled.
req.timer = time.AfterFunc(req.timeout, func() {
select {
case timeout <- req:
case <-s.done:
// Prevent leaking of timer goroutines in the unlikely case where a
// timer is fired just before exiting runStateSync.
}
timeout <- req
})
active[req.peer.id] = req
}
@ -217,7 +212,6 @@ func (d *Downloader) runStateSync(s *stateSync) *stateSync {
// are marked as idle and de facto _are_ idle.
func (d *Downloader) spindownStateSync(active map[string]*stateReq, finished []*stateReq, timeout chan *stateReq, peerDrop chan *peerConnection) {
log.Trace("State sync spinning down", "active", len(active), "finished", len(finished))
for len(active) > 0 {
var (
req *stateReq

Loading…
Cancel
Save