p2p: change ping ticker to timer (#15071)

Using a Timer over Ticker seems to be a lot better, though I cannot fully
account for why that it behaves so (since Ticker should be more bursty, but not
necessarily more active over time, but that may depend on how long window it
uses to decide on when to tick next)
pull/15073/merge
Martin Holst Swende 7 years ago committed by Felix Lange
parent d70536b5d4
commit dc92779c0a
  1. 3
      p2p/peer.go

@ -190,7 +190,7 @@ loop:
}
func (p *Peer) pingLoop() {
ping := time.NewTicker(pingInterval)
ping := time.NewTimer(pingInterval)
defer p.wg.Done()
defer ping.Stop()
for {
@ -200,6 +200,7 @@ func (p *Peer) pingLoop() {
p.protoErr <- err
return
}
ping.Reset(pingInterval)
case <-p.closed:
return
}

Loading…
Cancel
Save